NextGreaterElementII::nextGreaterElements() - Code Metrics - Inspection of "Add next-greater-element-ii solution" - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 58e792...7553cc )

by Jinyun

created 2021-08-19 10:29 UTC

NextGreaterElementII::nextGreaterElements() A

↳ Parent: NextGreaterElementII

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
c	1
b	0
f	0
dl	0
loc	16
rs	9.6111
cc	5
nc	4
nop	1

<?php

declare(strict_types=1);

namespace leetcode;

class NextGreaterElementII
{
    public static function nextGreaterElements(array $nums): array
    {
        if (empty($nums)) {
            return [];
        }
        $n = count($nums);
        [$ans, $stack] = [array_fill(0, $n, -1), []];
        for ($i = 0; $i < $n * 2; $i++) {
            $k = $i % $n;
            while ($stack && $nums[end($stack)] < $nums[$k]) {

                $ans[array_pop($stack)] = $nums[$k];
            }
            array_push($stack, $k);
        }

        return $ans;
    }

    public static function nextGreaterElements2(array $nums): array
    {
        if (empty($nums)) {
            return [];
        }
        $n = count($nums);
        [$ans, $stack] = [array_fill(0, $n, -1), []];
        for ($i = 0; $i < $n; $i++) {
            while ($stack && $nums[end($stack)] < $nums[$i]) {

                $ans[array_pop($stack)] = $nums[$i];
            }
            array_push($stack, $i);
        }

        for ($i = 0; $i < $n; $i++) {
            while ($stack && $nums[end($stack)] < $nums[$i]) {
                $ans[array_pop($stack)] = $nums[$i];
            }
            if (empty($stack)) {
                break;
            }
        }

        return $ans;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			class NextGreaterElementII
8			{
9			public static function nextGreaterElements(array $nums): array
10			{
11			if (empty($nums)) {
12			return [];
13			}
14			$n = count($nums);
15			[$ans, $stack] = [array_fill(0, $n, -1), []];
16			for ($i = 0; $i < $n * 2; $i++) {
17			$k = $i % $n;
18			while ($stack && $nums[end($stack)] < $nums[$k]) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-19 10:32 UTC by Report Bug Copy Issue Report The expression `$stack` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
19			$ans[array_pop($stack)] = $nums[$k];
20			}
21			array_push($stack, $k);
22			}
23
24			return $ans;
25			}
26
27			public static function nextGreaterElements2(array $nums): array
28			{
29			if (empty($nums)) {
30			return [];
31			}
32			$n = count($nums);
33			[$ans, $stack] = [array_fill(0, $n, -1), []];
34			for ($i = 0; $i < $n; $i++) {
35			while ($stack && $nums[end($stack)] < $nums[$i]) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-19 10:32 UTC by Report Bug Copy Issue Report The expression `$stack` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
36			$ans[array_pop($stack)] = $nums[$i];
37			}
38			array_push($stack, $i);
39			}
40
41			for ($i = 0; $i < $n; $i++) {
42			while ($stack && $nums[end($stack)] < $nums[$i]) {
43			$ans[array_pop($stack)] = $nums[$i];
44			}
45			if (empty($stack)) {
46			break;
47			}
48			}
49
50			return $ans;
51			}
52			}
53

imajinyun / leetcode-php

Push — master ( 58e792...7553cc )

NextGreaterElementII::nextGreaterElements() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like