leetcode\NextGreaterElementI::nextGreaterElement()

Complexity

Conditions	7
Paths	7

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function nextGreaterElement(array $num1, array $num2): array
    {
        if (empty($num1) || empty($num2)) {
            return [];
        }
        $ans = $stack = $map = [];
        foreach ($num2 as $num) {
            while ($stack && end($stack) < $num) {

The expression $stack of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $map[array_pop($stack)] = $num;
            }
            array_push($stack, $num);
        }
        foreach ($num1 as $num) {
            array_push($ans, $map[$num] ?? -1);
        }

        return $ans;
    }