BinaryTreeInorderTraversal::inorderTraversal() - Code Metrics - Inspection of "Add binary-tree-inorder-traversal solution" - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 6bacec...0f6593 )

by Jinyun

created 2021-06-21 06:20 UTC

BinaryTreeInorderTraversal::inorderTraversal() A

↳ Parent: BinaryTreeInorderTraversal

Complexity

Conditions	6
Paths	6

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	12
c	1
b	0
f	0
dl	0
loc	20
rs	9.2222
cc	6
nc	6
nop	1

<?php

declare(strict_types=1);

namespace leetcode;

use leetcode\util\TreeNode;

class BinaryTreeInorderTraversal
{
    public static function inorderTraversal(TreeNode $root): array
    {
        if (empty($root)) {
            return [];
        }
        [$ans, $curr, $stack] = [[], $root, []];
        while ($curr || $stack) {
            while ($curr) {
                array_push($stack, $curr);
                $curr = $curr->left;
            }
            /** @var \leetcode\util\TreeNode $curr */
            $curr = array_pop($stack);
            if ($curr->val) {
                array_push($ans, $curr->val);
            }
            $curr = $curr->right;
        }

        return $ans;
    }

    public static function inorderTraversal2(TreeNode $root): array
    {
        if (empty($root)) {
            return [];
        }
        $ans = [];
        self::helper($root, $ans);

        return $ans;
    }

    private static function helper(TreeNode $root, array & $arr): void
    {
        if ($root) {

            if ($root->left) {
                self::helper($root->left, $arr);
            }
            if ($root->val) {
                array_push($arr, $root->val);
            }
            if ($root->right) {
                self::helper($root->right, $arr);
            }
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			use leetcode\util\TreeNode;
8
9			class BinaryTreeInorderTraversal
10			{
11			public static function inorderTraversal(TreeNode $root): array
12			{
13			if (empty($root)) {
14			return [];
15			}
16			[$ans, $curr, $stack] = [[], $root, []];
17			while ($curr \|\| $stack) {
18			while ($curr) {
19			array_push($stack, $curr);
20			$curr = $curr->left;
21			}
22			/** @var \leetcode\util\TreeNode $curr */
23			$curr = array_pop($stack);
24			if ($curr->val) {
25			array_push($ans, $curr->val);
26			}
27			$curr = $curr->right;
28			}
29
30			return $ans;
31			}
32
33			public static function inorderTraversal2(TreeNode $root): array
34			{
35			if (empty($root)) {
36			return [];
37			}
38			$ans = [];
39			self::helper($root, $ans);
40
41			return $ans;
42			}
43
44			private static function helper(TreeNode $root, array & $arr): void
45			{
46			if ($root) {
			0 ignored issues – show introduced 2021-06-21 06:22 UTC by Report Bug Copy Issue Report `$root` is of type `leetcode\util\TreeNode`, thus it always evaluated to `true`. Loading history...
47			if ($root->left) {
48			self::helper($root->left, $arr);
49			}
50			if ($root->val) {
51			array_push($arr, $root->val);
52			}
53			if ($root->right) {
54			self::helper($root->right, $arr);
55			}
56			}
57			}
58			}
59

imajinyun / leetcode-php

Push — master ( 6bacec...0f6593 )

BinaryTreeInorderTraversal::inorderTraversal() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like