leetcode\InsertIntoABinarySearchTree::insertIntoBST2()

Complexity

Conditions	6
Paths	8

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function insertIntoBST2(?TreeNode $root, int $val): TreeNode
    {
        $curr = $root;
        while ($curr instanceof TreeNode) {
            if ($curr->val < $val) {
                if (!$curr->right) {
                    $curr->right = new TreeNode($val);
                    return $root;

The expression return $root could return the type null which is incompatible with the type-hinted return leetcode\util\TreeNode. Consider adding an additional type-check to rule them out.

                } else {
                    $curr = $curr->right;
                }
            }
            if ($curr->val > $val) {
                if (!$curr->left) {
                    $curr->left = new TreeNode($val);
                    return $root;

The expression return $root could return the type null which is incompatible with the type-hinted return leetcode\util\TreeNode. Consider adding an additional type-check to rule them out.

                } else {
                    $curr = $curr->left;
                }
            }
        }

        return new TreeNode($val);
    }