BinaryTreeRightSideView::dfs() - Code Metrics - Inspection of "Add binary-tree-right-side-view solution" - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 989c2e...a5addd )

by Jinyun

created 2021-08-20 06:28 UTC

BinaryTreeRightSideView::dfs() A

↳ Parent: BinaryTreeRightSideView

Complexity

Conditions	4
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	9
rs	10
cc	4
nc	3
nop	3

<?php

declare(strict_types=1);

namespace leetcode;

use leetcode\util\TreeNode;

class BinaryTreeRightSideView
{
    public static function rightSideView(?TreeNode $root): array
    {
        if (!$root) {
            return [];
        }
        $ans = $queue = [];

        $queue = [$root];
        while ($queue) {

            $n = count($queue);
            for ($i = 0; $i < $n; $i++) {
                /** @var \leetcode\util\TreeNode $node */
                $node = array_shift($queue);
                if ($node instanceof TreeNode) {
                    if ($i === $n - 1 && $node->val) {
                        array_push($ans, $node->val);
                    }
                    if ($node->left) {
                        array_push($queue, $node->left);
                    }
                    if ($node->right) {
                        array_push($queue, $node->right);
                    }
                }
            }
        }

        return $ans;
    }

    public static function rightSideView2(?TreeNode $root): array
    {
        if (!$root) {
            return [];
        }
        $ans = [];
        self::dfs($root, 0, $ans);

        return $ans;
    }

    private static function dfs(?TreeNode $node, int $depth, array & $ans): void
    {
        if ($node instanceof TreeNode && $node->val) {
            if ($depth + 1 > count($ans)) {
                array_push($ans, 0);
            }
            $ans[$depth] = $node->val;
            self::dfs($node->left, $depth + 1, $ans);
            self::dfs($node->right, $depth + 1, $ans);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			use leetcode\util\TreeNode;
8
9			class BinaryTreeRightSideView
10			{
11			public static function rightSideView(?TreeNode $root): array
12			{
13			if (!$root) {
14			return [];
15			}
16			$ans = $queue = [];
			0 ignored issues – show Unused Code introduced 2021-08-20 06:31 UTC by Report Bug Copy Issue Report The assignment to `$queue` is dead and can be removed. Loading history...
17			$queue = [$root];
18			while ($queue) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-20 06:31 UTC by Report Bug Copy Issue Report The expression `$queue` of type `array<integer,leetcode\util\TreeNode>` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
19			$n = count($queue);
20			for ($i = 0; $i < $n; $i++) {
21			/** @var \leetcode\util\TreeNode $node */
22			$node = array_shift($queue);
23			if ($node instanceof TreeNode) {
24			if ($i === $n - 1 && $node->val) {
25			array_push($ans, $node->val);
26			}
27			if ($node->left) {
28			array_push($queue, $node->left);
29			}
30			if ($node->right) {
31			array_push($queue, $node->right);
32			}
33			}
34			}
35			}
36
37			return $ans;
38			}
39
40			public static function rightSideView2(?TreeNode $root): array
41			{
42			if (!$root) {
43			return [];
44			}
45			$ans = [];
46			self::dfs($root, 0, $ans);
47
48			return $ans;
49			}
50
51			private static function dfs(?TreeNode $node, int $depth, array & $ans): void
52			{
53			if ($node instanceof TreeNode && $node->val) {
54			if ($depth + 1 > count($ans)) {
55			array_push($ans, 0);
56			}
57			$ans[$depth] = $node->val;
58			self::dfs($node->left, $depth + 1, $ans);
59			self::dfs($node->right, $depth + 1, $ans);
60			}
61			}
62			}
63

imajinyun / leetcode-php

Push — master ( 989c2e...a5addd )

BinaryTreeRightSideView::dfs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like