Triangle::minimumTotal2() - Code Metrics - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

Triangle::minimumTotal2() A
last analyzed 2022-03-29 06:17 UTC

↳ Parent: Triangle

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	7
c	2
b	0
f	0
dl	0
loc	14
rs	10
cc	4
nc	4
nop	1

<?php

declare(strict_types=1);

namespace leetcode;

class Triangle
{
    public static function minimumTotal(array $triangle)
    {
        if (0 === $n = count($triangle)) {
            return $n;
        }
        $dp = [];
        for ($i = 0; $i < count($triangle[$n - 1]); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $dp[$i] = $triangle[$n - 1][$i];
        }
        for ($i = $n - 2; $i >= 0; $i--) {
            for ($j = 0; $j <= $i; $j++) {
                $dp[$j] = min($dp[$j], $dp[$j + 1]) + $triangle[$i][$j];
            }
        }

        return $dp[0];
    }

    public static function minimumTotal2(array $triangle)
    {
        if (0 === $n = count($triangle)) {
            return $n;
        }

        $ans = $triangle[$n - 1];
        for ($i = $n - 2; $i >= 0; $i--) {
            for ($j = 0; $j <= $i; $j++) {
                $ans[$j] = $triangle[$i][$j] + min($ans[$j], $ans[$j + 1]);
            }
        }

        return $ans[0];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			class Triangle
8			{
9			public static function minimumTotal(array $triangle)
10			{
11			if (0 === $n = count($triangle)) {
12			return $n;
13			}
14			$dp = [];
15			for ($i = 0; $i < count($triangle[$n - 1]); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2021-05-03 03:21 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
16			$dp[$i] = $triangle[$n - 1][$i];
17			}
18			for ($i = $n - 2; $i >= 0; $i--) {
19			for ($j = 0; $j <= $i; $j++) {
20			$dp[$j] = min($dp[$j], $dp[$j + 1]) + $triangle[$i][$j];
21			}
22			}
23
24			return $dp[0];
25			}
26
27			public static function minimumTotal2(array $triangle)
28			{
29			if (0 === $n = count($triangle)) {
30			return $n;
31			}
32
33			$ans = $triangle[$n - 1];
34			for ($i = $n - 2; $i >= 0; $i--) {
35			for ($j = 0; $j <= $i; $j++) {
36			$ans[$j] = $triangle[$i][$j] + min($ans[$j], $ans[$j + 1]);
37			}
38			}
39
40			return $ans[0];
41			}
42			}
43

imajinyun / leetcode-php

Triangle::minimumTotal2() A last analyzed 2022-03-29 06:17 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Triangle::minimumTotal2() A
last analyzed 2022-03-29 06:17 UTC