FindLargestValueInEachTreeRow::dfs() - Code Metrics - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

FindLargestValueInEachTreeRow::dfs() A
last analyzed 2022-03-29 06:17 UTC

↳ Parent: FindLargestValueInEachTreeRow

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	10
rs	10
cc	3
nc	3
nop	3

<?php

declare(strict_types=1);

namespace leetcode;

use leetcode\util\TreeNode;

class FindLargestValueInEachTreeRow
{
    public static function largestValues(?TreeNode $tree): array
    {
        if (!$tree) {
            return [];
        }

        $ans = $queue = [];

        $queue = [$tree];
        while ($queue) {

            [$curr, $n] = [[], count($queue)];
            for ($i = 0; $i < $n; $i++) {
                $node = array_shift($queue);
                if ($node instanceof TreeNode) {
                    array_push($curr, $node->val);
                    if ($node->left) {
                        array_push($queue, $node->left);
                    }
                    if ($node->right) {
                        array_push($queue, $node->right);
                    }
                }
            }
            if ($curr) {

                array_push($ans, max($curr));
            }
        }

        return $ans;
    }

    public static function largestValues2(?TreeNode $tree): array
    {
        if (!$tree) {
            return [];
        }
        $ans = [];
        self::dfs($tree, 0, $ans);

        return $ans;
    }

    private static function dfs(?TreeNode $node, int $depth, array & $ans): void
    {
        if ($node instanceof TreeNode) {
            if ($depth === count($ans)) {
                array_push($ans, $node->val);
            } else {
                $ans[$depth] = max($ans[$depth], $node->val);
            }
            self::dfs($node->left, $depth + 1, $ans);
            self::dfs($node->right, $depth + 1, $ans);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			use leetcode\util\TreeNode;
8
9			class FindLargestValueInEachTreeRow
10			{
11			public static function largestValues(?TreeNode $tree): array
12			{
13			if (!$tree) {
14			return [];
15			}
16
17			$ans = $queue = [];
			0 ignored issues – show Unused Code introduced 2021-08-22 10:09 UTC by Report Bug Copy Issue Report The assignment to `$queue` is dead and can be removed. Loading history...
18			$queue = [$tree];
19			while ($queue) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-22 10:09 UTC by Report Bug Copy Issue Report The expression `$queue` of type `array<integer,leetcode\util\TreeNode>` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
20			[$curr, $n] = [[], count($queue)];
21			for ($i = 0; $i < $n; $i++) {
22			$node = array_shift($queue);
23			if ($node instanceof TreeNode) {
24			array_push($curr, $node->val);
25			if ($node->left) {
26			array_push($queue, $node->left);
27			}
28			if ($node->right) {
29			array_push($queue, $node->right);
30			}
31			}
32			}
33			if ($curr) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-22 10:09 UTC by Report Bug Copy Issue Report The expression `$curr` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
34			array_push($ans, max($curr));
35			}
36			}
37
38			return $ans;
39			}
40
41			public static function largestValues2(?TreeNode $tree): array
42			{
43			if (!$tree) {
44			return [];
45			}
46			$ans = [];
47			self::dfs($tree, 0, $ans);
48
49			return $ans;
50			}
51
52			private static function dfs(?TreeNode $node, int $depth, array & $ans): void
53			{
54			if ($node instanceof TreeNode) {
55			if ($depth === count($ans)) {
56			array_push($ans, $node->val);
57			} else {
58			$ans[$depth] = max($ans[$depth], $node->val);
59			}
60			self::dfs($node->left, $depth + 1, $ans);
61			self::dfs($node->right, $depth + 1, $ans);
62			}
63			}
64			}
65

imajinyun / leetcode-php

FindLargestValueInEachTreeRow::dfs() A last analyzed 2022-03-29 06:17 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FindLargestValueInEachTreeRow::dfs() A
last analyzed 2022-03-29 06:17 UTC