leetcode\BasicCalculatorII::calculate2()

Complexity

Conditions	8
Paths	19

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function calculate2(string $s): int
    {
        if (empty($s)) {
            return 0;
        }
        $s = str_replace(' ', '', $s);
        $n = strlen($s);
        [$stack, $operator] = [[], '+'];

        for ($i = 0; $i < $n; $i++) {
            $char = $s[$i];
            if (is_numeric($char)) {
                if ($operator === '+') {
                    array_push($stack, (int)$char);
                }
                if ($operator === '-') {
                    array_push($stack, -(int)$char);
                }
                if ($operator === '*') {
                    array_push($stack, array_pop($stack) * (int)$char);
                }
                if ($operator === '/') {
                    array_push($stack, (int)(array_pop($stack) / $char));
                }
            } else {
                $operator = $char;
            }
        }

        return array_sum($stack);

The expression return array_sum($stack) could return the type double which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }