Issues in lib_modules.php (development) - Issues in development - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1177)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

application/libraries/lib_modules.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use CI;
use Modules;

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

class Lib_modules
{

    /**
     *
     * @var array
     */
    private $modules = [];

    /**
     *
     * @var array
     */
    private $modulesAppRelPath = [];

    public function __construct() {

        $this->setModulesLocations();
        $this->loadModules();
    }

    /**
     * Adding dirs that may contain modules
     */
    private function setModulesLocations() {

        if (FALSE !== $modulesLocations = CI::$APP->config->item('modules_locations')) {
            $locationsToSet = [];
            $countModulesLocations = count($modulesLocations);
            for ($i = 0; $i < $countModulesLocations; $i++) {
                $withinPath = trim($modulesLocations[$i], '/') . '/';
                $locationsToSet[APPPATH . $withinPath] = "../{$withinPath}";
            }
            Modules::$locations = $locationsToSet;
        }
    }

    /**
     * Loading all modules names and their paths
     */
    private function loadModules() {

        CI::$APP->load->helper('file');
        foreach (Modules::$locations as $path => $relPath) {
            $modulesInLocation = get_dir_file_info($path);
            foreach ($modulesInLocation as $name => $info) {
                $fullModulePath = $path . $name . '/';
                if (is_dir($fullModulePath)) {
                    $this->modules[$name] = $fullModulePath;
                    $this->modulesAppRelPath[$name] = trim(str_replace(APPPATH, '', $path), '/');
                }
            }
        }
    }

    // ------------ useful methods section -------------

    /**
     *
     * @param string $moduleName
     * @return boolean|string
     */
    public function getModulePath($moduleName) {

        if (!is_string($moduleName) || empty($moduleName)) {
            throw new \InvalidArgumentException('Module name must be string');
        }
        if (!isset($this->modules[$moduleName])) {
            return false;
        }
        return $this->modules[$moduleName];
    }

    /**
     * @return array
     */
    public function getModulesPaths() {

        return $this->modules;
    }

    /**
     * @return array

     */
    public function getModulesNames() {

        return array_keys($this->modules);
    }

    /**
     *
     * @param string $moduleName
     * @return bool
     */
    public function moduleExists($moduleName) {

        if (!is_string($moduleName) || empty($moduleName)) {
            return false;
        }
        return array_key_exists($moduleName, $this->modules);
    }

    /**
     * Get module containing dir name
     *
     * @param string $moduleName
     * @return string
     */
    public function getModContDirName($moduleName) {

        if (!SHOP_INSTALLED && $moduleName == 'shop') {
            return;
        }
        if (!is_string($moduleName) || empty($moduleName)) {
            throw new \InvalidArgumentException('Module name must be string');
        }
        if (!array_key_exists($moduleName, $this->modulesAppRelPath)) {
            throw new \UnexpectedValueException("Module [{$moduleName}] not found");
        }
        return $this->modulesAppRelPath[$moduleName];
    }

}

1			<?php
2
3			use CI;
4			use Modules;
5
6			if (!defined('BASEPATH')) {
7			exit('No direct script access allowed');
8			}
9
10			class Lib_modules
11			{
12
13			/**
14			*
15			* @var array
16			*/
17			private $modules = [];
18
19			/**
20			*
21			* @var array
22			*/
23			private $modulesAppRelPath = [];
24
25			public function __construct() {
26
27			$this->setModulesLocations();
28			$this->loadModules();
29			}
30
31			/**
32			* Adding dirs that may contain modules
33			*/
34			private function setModulesLocations() {
35
36			if (FALSE !== $modulesLocations = CI::$APP->config->item('modules_locations')) {
37			$locationsToSet = [];
38			$countModulesLocations = count($modulesLocations);
39			for ($i = 0; $i < $countModulesLocations; $i++) {
40			$withinPath = trim($modulesLocations[$i], '/') . '/';
41			$locationsToSet[APPPATH . $withinPath] = "../{$withinPath}";
42			}
43			Modules::$locations = $locationsToSet;
44			}
45			}
46
47			/**
48			* Loading all modules names and their paths
49			*/
50			private function loadModules() {
51
52			CI::$APP->load->helper('file');
53			foreach (Modules::$locations as $path => $relPath) {
54			$modulesInLocation = get_dir_file_info($path);
55			foreach ($modulesInLocation as $name => $info) {
56			$fullModulePath = $path . $name . '/';
57			if (is_dir($fullModulePath)) {
58			$this->modules[$name] = $fullModulePath;
59			$this->modulesAppRelPath[$name] = trim(str_replace(APPPATH, '', $path), '/');
60			}
61			}
62			}
63			}
64
65			// ------------ useful methods section -------------
66
67			/**
68			*
69			* @param string $moduleName
70			* @return boolean\|string
71			*/
72			public function getModulePath($moduleName) {
73
74			if (!is_string($moduleName) \|\| empty($moduleName)) {
75			throw new \InvalidArgumentException('Module name must be string');
76			}
77			if (!isset($this->modules[$moduleName])) {
78			return false;
79			}
80			return $this->modules[$moduleName];
81			}
82
83			/**
84			* @return array
85			*/
86			public function getModulesPaths() {
87
88			return $this->modules;
89			}
90
91			/**
92			* @return array
			0 ignored issues – show Documentation introduced 2015-12-16 14:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `array<integer\|string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
93			*/
94			public function getModulesNames() {
95
96			return array_keys($this->modules);
97			}
98
99			/**
100			*
101			* @param string $moduleName
102			* @return bool
103			*/
104			public function moduleExists($moduleName) {
105
106			if (!is_string($moduleName) \|\| empty($moduleName)) {
107			return false;
108			}
109			return array_key_exists($moduleName, $this->modules);
110			}
111
112			/**
113			* Get module containing dir name
114			*
115			* @param string $moduleName
116			* @return string
117			*/
118			public function getModContDirName($moduleName) {
119
120			if (!SHOP_INSTALLED && $moduleName == 'shop') {
121			return;
122			}
123			if (!is_string($moduleName) \|\| empty($moduleName)) {
124			throw new \InvalidArgumentException('Module name must be string');
125			}
126			if (!array_key_exists($moduleName, $this->modulesAppRelPath)) {
127			throw new \UnexpectedValueException("Module [{$moduleName}] not found");
128			}
129			return $this->modulesAppRelPath[$moduleName];
130			}
131
132			}

imagecms / ImageCMS

Issues (1177)

Security Analysis not enabled

application/libraries/lib_modules.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like