Seoexpert_model

Complexity

Total Complexity

19

Size/Duplication

Total Lines	209
Duplicated Lines	19.14 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	6
Bugs	2	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	deinstall()	0	7	1
A	getBaseSettings()	0	15	4
A	getCategoriesByIdName()	0	18	2
A	getLangIdByLocale()	13	13	3
A	getSettings()	10	10	2
B	install()	0	35	1
B	setBaseSettings()	0	33	3
A	setSettings()	17	17	2

<?php

/**
 * @property CI_DB_active_record $db
 * @property DX_Auth $dx_auth
 */
class Seoexpert_model extends CI_Model
{

Opening brace of a class must be on the same line as the definition

    /**
     * Seoexpert_model constructor.
     */
    public function __construct() {

        parent::__construct();
    }

    /**
     * Deinstall
     * @return boolean|null

@return doc comment specified, but function has no return statement

     */
    public function deinstall() {

        $this->load->dbforge();
        $this->dbforge->drop_table('mod_seo');
        $this->dbforge->drop_table('mod_seo_products');
        $this->dbforge->drop_table('mod_seo_inflect');
    }

    /**
     * Get base settings
     * @param bool|int $langId
     * @return array|bool

Consider making the return type a bit more specific; maybe use false|array.

     */
    public function getBaseSettings($langId = false) {

        if (!$langId || is_numeric($langId) === false) {
            return false;
        }
        $settings = $this->db->select('add_site_name, add_site_name_to_cat, delimiter, create_keywords, create_description')->where('s_name', 'main')->get('settings')->row_array();
        $settingsIn = $this->db->where('lang_ident', $langId)->get('settings_i18n')->row_array();

        $res = array_merge($settings, $settingsIn);

        if ($res) {
            return $res;
        }
        return false;
    }

    /**
     * Get categories by ID, NAME
     * @param string  $term  id,name

Expected 1 spaces after parameter type; 2 found

     * @param integer $limit limit for results
     * @return boolean|array
     */
    public function getCategoriesByIdName($term, $limit = 7) {

        $locale = MY_Controller::defaultLocale();

        $sql = "SELECT *
                FROM  `shop_category_i18n`
                WHERE  (`locale` =  '$locale'
                AND  `name` LIKE  '%$term%')
                OR (`id` LIKE '%$term%' AND `locale` =  '$locale')
                LIMIT 0 , $limit";
        $query = $this->db->query($sql);

        if ($query) {
            return $query->result_array();
        } else {
            return false;
        }
    }

     /**
     * Get language id

Expected 6 space(s) before asterisk; 5 found

     * @param bool|string $locale

Expected 6 space(s) before asterisk; 5 found

     * @return bool|int

Expected 6 space(s) before asterisk; 5 found

     */

Expected 6 space(s) before asterisk; 5 found

    public function getLangIdByLocale($locale = false) {

        if (!$locale) {
            $locale = \MY_Controller::getCurrentLocale();
        }

        $res = $this->db->select('id')->where('identif', $locale)->get('languages')->row_array();
        if ($res) {
            return $res['id'];
        }

        return false;
    }

    /**
     * Get module settings
     * @param string $locale
     * @return array
     */
    public function getSettings($locale = 'ru') {

        $settings = $this->db->select('settings')
            ->where('locale', $locale)
            ->get('mod_seo')
            ->row_array();

        $settings = unserialize($settings['settings']);
        return $settings ?: false;
    }

    /**
     * Install
     * @return boolean
     */
    public function install() {

        $sql = 'CREATE TABLE IF NOT EXISTS `mod_seo` (
                    `id` int(11) NOT NULL AUTO_INCREMENT,
                    `locale` varchar(5) DEFAULT NULL,
                    `settings` text DEFAULT NULL,
                    PRIMARY KEY (`id`)
                    ) ENGINE=MyISAM DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;';

        $this->db->query($sql);

        $sql = 'CREATE TABLE IF NOT EXISTS `mod_seo_products` (
                    `id` int(11) NOT NULL AUTO_INCREMENT,
                    `cat_id` int(11) NOT NULL,
                    `locale` varchar(5) DEFAULT NULL,
                    `settings` text DEFAULT NULL,
                    `active` tinyint(4) DEFAULT NULL,
                    `empty_meta` int(11) DEFAULT NULL,
                    PRIMARY KEY (`id`)
                    ) ENGINE=MyISAM DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;';

        $this->db->query($sql);

        $sql = 'CREATE TABLE IF NOT EXISTS `mod_seo_inflect` (
                `id` int(11) NOT NULL AUTO_INCREMENT,
                `original` varchar(250) NOT NULL,
                `inflection_id` int(11) NOT NULL,
                `inflected` varchar(250) NOT NULL,
                PRIMARY KEY (`id`)
              ) ENGINE=InnoDB  DEFAULT CHARSET=utf8 AUTO_INCREMENT=1 ;';
        $this->db->query($sql);

        $this->db->where('name', 'mod_seo')->update('components', ['autoload' => 1, 'in_menu' => 1]);
        return true;
    }

    /**
     * Set Base settings
     * @param bool|int $langId
     * @param array    $settings

Expected 1 spaces after parameter type; 4 found

     * @return bool
     */
    public function setBaseSettings($langId = false, $settings) {

Parameters which have default values should be placed at the end.

        if (!$langId) {
            return false;
        }
        // Update shop settings table
        $mainSettings = [
            'add_site_name' => $settings['add_site_name'],
            'add_site_name_to_cat' => $settings['add_site_name_to_cat'],
            'delimiter' => $settings['delimiter'],
            'create_keywords' => $settings['create_keywords'],
            'create_description' => $settings['create_description']
        ];
        $this->db->where('s_name', 'main')->update('settings', $mainSettings);

        //Check exists settings with current langId
        $checkLangSettings = $this->db->where('lang_ident', $langId)->get('settings_i18n')->row_array();

        $mainSettingsIn = [
            'name' => $settings['name'],
            'short_name' => $settings['short_name'],
            'description' => $settings['description'],
            'keywords' => $settings['keywords']
        ];

        // Update or insert shop settings I18n table
        if ($checkLangSettings) {
            return $this->db->where('lang_ident', $langId)->update('settings_i18n', $mainSettingsIn);
        } else {
            $mainSettingsIn['lang_ident'] = $langId;
            return $this->db->insert('settings_i18n', $mainSettingsIn);
        }
    }

    /**
     * Save settings
     * @param array $settings
     * @param string $locale
     * @return bool
     */
    public function setSettings($settings, $locale = 'ru') {

        $data = $this->db->select('locale')
            ->where('locale', $locale)
            ->get('mod_seo')
            ->row_array();
        if (empty($data)) {
            return $this->db->insert('mod_seo', ['locale' => $locale, 'settings' => serialize($settings)]);
        }

        return $this->db->where('locale', $locale)
            ->update(
                'mod_seo',
                ['settings' => serialize($settings)
                ]
            );
    }

}