Cms_admin - Code Metrics - Inspection of "pre release" - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( a150a5...f82eb6 )

by Andrij

created 2016-05-10 10:01 UTC

Cms_admin B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	341
Duplicated Lines	5.87 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	20
loc	341
rs	8.3999
wmc	38
lcom	0
cbo	1

20 Methods

Rating	Name	Duplication	Size	Complexity
B	add_page()	0	22	6
A	get_page_by_lang()	0	12	2
A	get_page()	0	11	2
A	page_exists()	0	8	1
C	update_page()	0	37	7
A	create_category()	0	6	1
A	update_category()	0	5	1
A	get_categories()	0	4	1
A	get_category()	10	11	2
A	is_category()	0	7	1
A	save_settings()	0	5	1
A	get_settings()	0	4	1
A	editor_theme()	0	8	1
A	insert_lang()	0	6	1
A	get_langs()	0	15	3
A	get_lang()	10	11	2
A	update_lang()	0	5	1
A	delete_lang()	0	6	1
A	set_default_lang()	0	8	1
A	get_default_lang()	0	8	2

How to fix Duplicated Code

<?php

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * @property Cms_base $cms_base
 */
class Cms_admin extends CI_Model
{


    /*     * ***********************************************************
     * 	Pages
     * ********************************************************** */

    /**
     * Add page into content table
     *
     * @param array $data
     * @return integer
     */
    public function add_page($data) {

        $this->db->limit(1);
        if (!$data['comments_count']) {
            $data['comments_count'] = 0;
        }
        if (!$data['position']) {
            $data['position'] = 0;
        }
        if (!$data['updated']) {
            $data['updated'] = 0;
        }
        if (!$data['showed']) {
            $data['showed'] = 0;
        }
        if (!$data['lang_alias']) {
            $data['lang_alias'] = 0;
        }
        $this->db->insert('content', $data);

        return $this->db->insert_id();
    }

    /**
     * Select page by id and lang_id
     *
     * @param int $id
     * @param int $lang
     * @return array
     */
    public function get_page_by_lang($id, $lang = 0) {

        $this->db->where('id', $id);
        $this->db->where('lang', $lang);
        $query = $this->db->get('content', 1);

        if ($query->num_rows == 1) {
            return $query->row_array();
        }

        return FALSE;
    }

    /**
     * Select page by id
     *
     * @param integer $id
     * @return array
     */
    public function get_page($id) {

        $this->db->where('id', $id);
        $query = $this->db->get('content', 1);

        if ($query->num_rows > 0) {
            return $query->row_array();
        }

        return FALSE;
    }

    /**
     * @param integer $id
     * @return bool
     */
    public function page_exists($id) {

        $this->db->select('id');
        $this->db->where('id', $id);
        $query = $this->db->get('content', 1);

        return $query->num_rows == 1;
    }

    /**
     * @param $id

     * @param $data

     * @param bool $exists
     * @return bool
     */
    public function update_page($id, $data , $exists = false) {


        $lang_id = $this->input->post('lang_id');
        $pageExists = (int) $this->input->post('pageExists');

        if (!$pageExists && $exists == false) {
            unset($data['id']);
            $data['lang_alias'] = $id;
            $data['lang'] = $lang_id;
            $id = $this->add_page($data);
            $inserted = $id ? true : false;

        }

        $page = $this->get_page($id);
        $alias = $page['lang_alias'];

        if ($alias == 0) {
            $this->db->where('lang_alias', $page['id']);
            $this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url'], 'url' => $data['url']]);
        } else {
            $page = $this->get_page($alias);
            $this->db->where('lang_alias', $page['id']);
            $this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url']]);

            $this->db->where('id', $alias);
            $this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url']]);

            $data['url'] = $page['url'];
        }

        $this->db->where('id', $id);
        $this->db->update('content', $data);

        $affectedRows = $this->db->affected_rows();
        return ($affectedRows || $inserted) ? $id : false;
    }

    /**
     * Creates new category
     *
     * @param array $data
     * @return int
     */
    public function create_category($data) {

        $this->db->insert('category', $data);

        return $this->db->insert_id();
    }

    /**
     * Update category data
     *
     * @access public
     * @param array $data

     * @param int $id
     */
    public function update_category($data, $id) {

        $this->db->where('id', $id);
        $this->db->update('category', $data);
    }

    /**
     * Select all categories
     *
     * @access public
     * @return array
     */
    public function get_categories() {

        return $this->cms_base->get_categories();
    }

    /**
     * Get category by id
     * @param int $id
     * @return bool|array
     */
    public function get_category($id) {

        $this->db->where('id', $id);
        $query = $this->db->get('category', 1);

        if ($query->num_rows() > 0) {
            return $query->row_array();
        }

        return FALSE;
    }

    /**
     * Check if category is created
     *
     * @access public
     * @param string $url

     * @return bool
     */
    public function is_category($url) {

        $this->db->where('url', $url);
        $query = $this->db->get('category', 1);

        return $query->num_rows == 1;
    }

    /*     * ***********************************************************
     * 	Settings
     * ********************************************************** */

    /**
     *    Save settings

     *
     * @settings array
     * @access public
     * @param array $settings

     */
    public function save_settings($settings) {

        $this->db->where('s_name', 'main');
        $this->db->update('settings', $settings);
    }

    /**
     * Selecting main settings
     *
     * @access public
     * @return array
     */
    public function get_settings() {

        return $this->cms_base->get_settings();
    }

    /**
     * Get editor theme
     *
     * @access public
     * @return string
     */
    public function editor_theme() {

        $this->db->select('editor_theme');
        $this->db->where('s_name', 'main');
        $query = $this->db->get('settings', 1);

        return $query->row_array();
    }

    /*     * ***********************************************************
     * 	Languages
     * ********************************************************** */

    /**
     * Add page into content table
     *
     * @param array $data
     * @return int
     */
    public function insert_lang($data) {

        $this->db->insert('languages', $data);

        return $this->db->insert_id();
    }

    /**
     * @param bool|false $forShop
     * @return array
     */
    public function get_langs($forShop = false) {

        if ($forShop) {
            if (strpos(getCMSNumber(), 'Pro')) {
                return $this->db
                    ->where('default', true)
                    ->get('languages')
                    ->result_array();
            }
        }

        $query = $this->db->get('languages');

        return $query->result_array();
    }

    /**
     * @param $id

     * @return bool|array
     */
    public function get_lang($id) {

        $this->db->where('id', $id);
        $query = $this->db->get('languages', 1);

        if ($query->num_rows() == 1) {
            return $query->row_array();
        }

        return FALSE;
    }

    /**
     * @param array $data
     * @param int $id
     */
    public function update_lang($data, $id) {

        $this->db->where('id', $id);
        $this->db->update('languages', $data);
    }

    /**
     * @param integer $id
     */
    public function delete_lang($id) {

        $this->db->where('id', $id);
        $this->db->limit(1);
        $this->db->delete('languages');
    }

    /**
     * @param integer $id
     */
    public function set_default_lang($id) {

        $this->db->update('languages', ['default' => 0]);

        $this->db->where('id', $id);
        $this->db->limit(1);
        $this->db->update('languages', ['default' => 1, 'active' => 1]);
    }

    /**
     * @return array
     */
    public function get_default_lang() {

        if ($this->db) {
            $this->db->where('default', 1);
            $query = $this->db->get('languages', 1);
            return $query->row_array();
        }
    }

}

1		<?php
2
3		if (!defined('BASEPATH')) {
4		exit('No direct script access allowed');
5		}
6
7		/**
8		* @property Cms_base $cms_base
9		*/
10		class Cms_admin extends CI_Model
11		{
		0 ignored issues – show introduced 2015-11-28 17:40 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the same line as the definition Loading history...
12
13		/* * ***********************************************************
14		* Pages
15		* ********************************************************** */
16
17		/**
18		* Add page into content table
19		*
20		* @param array $data
21		* @return integer
22		*/
23		public function add_page($data) {
24
25		$this->db->limit(1);
26		if (!$data['comments_count']) {
27		$data['comments_count'] = 0;
28		}
29		if (!$data['position']) {
30		$data['position'] = 0;
31		}
32		if (!$data['updated']) {
33		$data['updated'] = 0;
34		}
35		if (!$data['showed']) {
36		$data['showed'] = 0;
37		}
38		if (!$data['lang_alias']) {
39		$data['lang_alias'] = 0;
40		}
41		$this->db->insert('content', $data);
42
43		return $this->db->insert_id();
44		}
45
46		/**
47		* Select page by id and lang_id
48		*
49		* @param int $id
50		* @param int $lang
51		* @return array
52		*/
53		public function get_page_by_lang($id, $lang = 0) {
54
55		$this->db->where('id', $id);
56		$this->db->where('lang', $lang);
57		$query = $this->db->get('content', 1);
58
59		if ($query->num_rows == 1) {
60		return $query->row_array();
61		}
62
63		return FALSE;
64		}
65
66		/**
67		* Select page by id
68		*
69		* @param integer $id
70		* @return array
71		*/
72		public function get_page($id) {
73
74		$this->db->where('id', $id);
75		$query = $this->db->get('content', 1);
76
77		if ($query->num_rows > 0) {
78		return $query->row_array();
79		}
80
81		return FALSE;
82		}
83
84		/**
85		* @param integer $id
86		* @return bool
87		*/
88		public function page_exists($id) {
89
90		$this->db->select('id');
91		$this->db->where('id', $id);
92		$query = $this->db->get('content', 1);
93
94		return $query->num_rows == 1;
95		}
96
97		/**
98		* @param $id
		0 ignored issues – show introduced 2015-12-16 14:14 UTC by Report Bug Copy Issue Report Missing parameter type Loading history...
99		* @param $data
		0 ignored issues – show introduced 2016-05-10 10:17 UTC by Report Bug Copy Issue Report Missing parameter type Loading history...
100		* @param bool $exists
101		* @return bool
102		*/
103		public function update_page($id, $data , $exists = false) {
		0 ignored issues – show Coding Style introduced 2016-05-10 10:17 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$data" and comma; 1 found Loading history...
104
105		$lang_id = $this->input->post('lang_id');
106		$pageExists = (int) $this->input->post('pageExists');
107
108		if (!$pageExists && $exists == false) {
109		unset($data['id']);
110		$data['lang_alias'] = $id;
111		$data['lang'] = $lang_id;
112		$id = $this->add_page($data);
113		$inserted = $id ? true : false;
114
115		}
116
117		$page = $this->get_page($id);
118		$alias = $page['lang_alias'];
119
120		if ($alias == 0) {
121		$this->db->where('lang_alias', $page['id']);
122		$this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url'], 'url' => $data['url']]);
123		} else {
124		$page = $this->get_page($alias);
125		$this->db->where('lang_alias', $page['id']);
126		$this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url']]);
127
128		$this->db->where('id', $alias);
129		$this->db->update('content', ['post_status' => $data['post_status'], 'category' => $data['category'], 'cat_url' => $data['cat_url']]);
130
131		$data['url'] = $page['url'];
132		}
133
134		$this->db->where('id', $id);
135		$this->db->update('content', $data);
136
137		$affectedRows = $this->db->affected_rows();
138		return ($affectedRows \|\| $inserted) ? $id : false;
139		}
140
141		/**
142		* Creates new category
143		*
144		* @param array $data
145		* @return int
146		*/
147		public function create_category($data) {
148
149		$this->db->insert('category', $data);
150
151		return $this->db->insert_id();
152		}
153
154		/**
155		* Update category data
156		*
157		* @access public
158		* @param array $data
		0 ignored issues – show introduced 2015-12-16 14:14 UTC by Report Bug Copy Issue Report Paramater tags must be grouped together in a doc commment Loading history...
159		* @param int $id
160		*/
161		public function update_category($data, $id) {
162
163		$this->db->where('id', $id);
164		$this->db->update('category', $data);
165		}
166
167		/**
168		* Select all categories
169		*
170		* @access public
171		* @return array
172		*/
173		public function get_categories() {
174
175		return $this->cms_base->get_categories();
176		}
177
178		/**
179		* Get category by id
180		* @param int $id
181		* @return bool\|array
182		*/
183	View Code Duplication	public function get_category($id) {
184
185		$this->db->where('id', $id);
186		$query = $this->db->get('category', 1);
187
188		if ($query->num_rows() > 0) {
189		return $query->row_array();
190		}
191
192		return FALSE;
193		}
194
195		/**
196		* Check if category is created
197		*
198		* @access public
199		* @param string $url
		0 ignored issues – show introduced 2015-12-16 14:14 UTC by Report Bug Copy Issue Report Paramater tags must be grouped together in a doc commment Loading history...
200		* @return bool
201		*/
202		public function is_category($url) {
203
204		$this->db->where('url', $url);
205		$query = $this->db->get('category', 1);
206
207		return $query->num_rows == 1;
208		}
209
210		/* * ***********************************************************
211		* Settings
212		* ********************************************************** */
213
214		/**
215		* Save settings
		0 ignored issues – show introduced 2015-11-28 17:40 UTC by Report Bug Copy Issue Report Function comment short description must start with exactly one space Loading history...
216		*
217		* @settings array
218		* @access public
219		* @param array $settings
		0 ignored issues – show introduced 2015-12-16 14:14 UTC by Report Bug Copy Issue Report Paramater tags must be grouped together in a doc commment Loading history...
220		*/
221		public function save_settings($settings) {
222
223		$this->db->where('s_name', 'main');
224		$this->db->update('settings', $settings);
225		}
226
227		/**
228		* Selecting main settings
229		*
230		* @access public
231		* @return array
232		*/
233		public function get_settings() {
234
235		return $this->cms_base->get_settings();
236		}
237
238		/**
239		* Get editor theme
240		*
241		* @access public
242		* @return string
243		*/
244		public function editor_theme() {
245
246		$this->db->select('editor_theme');
247		$this->db->where('s_name', 'main');
248		$query = $this->db->get('settings', 1);
249
250		return $query->row_array();
251		}
252
253		/* * ***********************************************************
254		* Languages
255		* ********************************************************** */
256
257		/**
258		* Add page into content table
259		*
260		* @param array $data
261		* @return int
262		*/
263		public function insert_lang($data) {
264
265		$this->db->insert('languages', $data);
266
267		return $this->db->insert_id();
268		}
269
270		/**
271		* @param bool\|false $forShop
272		* @return array
273		*/
274		public function get_langs($forShop = false) {
275
276		if ($forShop) {
277		if (strpos(getCMSNumber(), 'Pro')) {
278		return $this->db
279		->where('default', true)
280		->get('languages')
281		->result_array();
282		}
283		}
284
285		$query = $this->db->get('languages');
286
287		return $query->result_array();
288		}
289
290		/**
291		* @param $id
		0 ignored issues – show introduced 2016-05-10 10:17 UTC by Report Bug Copy Issue Report Missing parameter type Loading history...
292		* @return bool\|array
293		*/
294	View Code Duplication	public function get_lang($id) {
295
296		$this->db->where('id', $id);
297		$query = $this->db->get('languages', 1);
298
299		if ($query->num_rows() == 1) {
300		return $query->row_array();
301		}
302
303		return FALSE;
304		}
305
306		/**
307		* @param array $data
308		* @param int $id
309		*/
310		public function update_lang($data, $id) {
311
312		$this->db->where('id', $id);
313		$this->db->update('languages', $data);
314		}
315
316		/**
317		* @param integer $id
318		*/
319		public function delete_lang($id) {
320
321		$this->db->where('id', $id);
322		$this->db->limit(1);
323		$this->db->delete('languages');
324		}
325
326		/**
327		* @param integer $id
328		*/
329		public function set_default_lang($id) {
330
331		$this->db->update('languages', ['default' => 0]);
332
333		$this->db->where('id', $id);
334		$this->db->limit(1);
335		$this->db->update('languages', ['default' => 1, 'active' => 1]);
336		}
337
338		/**
339		* @return array
340		*/
341		public function get_default_lang() {
342
343		if ($this->db) {
344		$this->db->where('default', 1);
345		$query = $this->db->get('languages', 1);
346		return $query->row_array();
347		}
348		}
349
350		}

imagecms / ImageCMS

Push — development ( a150a5...f82eb6 )

Cms_admin B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like