PropelBaseModelClass - Code Metrics - Inspection of "Merge branch 'development' of github.com:imagecms/..." - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 67765c...7029e6 )

by Andrij

created 2016-10-28 09:36 UTC

PropelBaseModelClass C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	320
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	320
rs	6.8
c	0
b	0
f	0
wmc	55
lcom	1
cbo	2

23 Methods

Rating	Name	Size	Complexity
D	validateCustomData()	25	10
A	collectCustomData()	15	2
A	curentPostEntitySave()	6	2
C	saveCustomData()	38	8
A	getLabel()	11	3
A	getVirtual()	4	1
A	getVirtualColumn()	8	2
A	toCurrency()	16	4
A	__get()	10	3
A	getCache()	4	1
A	__call()	15	4
A	setVirtualColumn()	6	1
A	preSave()	3	1
A	postSave()	3	1
A	preInsert()	3	1
A	postInsert()	3	1
A	preUpdate()	3	1
A	postUpdate()	3	1
A	postDelete()	3	1
A	preDelete()	3	1
A	serialize()	21	3
A	prepareToSleep()	10	1
A	unserialize()	10	2

How to fix Complexity

<?php

namespace CMSFactory;

use CMSFactory\DependencyInjection\DependencyInjectionProvider;
use Currency\Currency;
use CustomFieldsData;
use CustomFieldsDataQuery;
use CustomFieldsQuery;
use Doctrine\Common\Cache\CacheProvider;
use MY_Controller;
use MY_Form_validation;
use Propel\Runtime\Connection\ConnectionInterface;

class PropelBaseModelClass implements \Serializable
{


    public $customFields;

    public $customData;

    public $hasCustomData = false;

    public $entityId;

    private $entities_locale = [
                                'product',
                                'category',
                                'brand',
                               ];

    /**
     * @param MY_Form_validation $validator
     * @return mixed

     */
    public function validateCustomData($validator) {
        if (!empty($this->entityName)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->collectCustomData($this->entityName, $this->getId());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            if ($this->hasCustomData !== false) {
                foreach ($_POST['custom_field'] as $key_post => $value_post) {
                    foreach ($this->customFields as $key => $value) {
                        if ((int) $key_post == $value['Id']) {

                            $validator_str = '';
                            if ($value['IsRequired'] && $this->curentPostEntitySave($key)) {
                                $validator_str = 'required';
                            }
                            if ($value['Validators'] && $this->curentPostEntitySave($key)) {
                                $validator_str .= '|' . $value['Validators'];
                            }
                            $name = array_shift($value['CustomFieldsI18ns'])['FieldLabel'];
                            $validator->set_rules("custom_field[$key]", $name, $validator_str);
                        }
                    }
                }
            }
        }
        return $validator;
    }

    /**
     * @param string $entityName
     * @param int $id
     * @return bool

     */
    public function collectCustomData($entityName, $id) {
        $this->entityId = $id;
        $this->customFields = CustomFieldsQuery::create()
            ->joinWithI18n(MY_Controller::defaultLocale())
            ->filterByIsActive(1)
            ->filterByEntity($entityName)
            ->find()
            ->toArray($keyColumn = 'id');

        if (count($this->customFields)) {
            $this->hasCustomData = true;
        } else {
            return false;
        }
    }

    /**
     * @param int $key
     * @return bool

     */
    public function curentPostEntitySave($key) {
        $entity = CustomFieldsQuery::create()->findPk($key);
        if ($entity) {
            return $entity->getEntity() == $this->entityName;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    public function saveCustomData() {

        $locale = in_array($this->entityName, $this->entities_locale, true) ? chose_language() : MY_Controller::defaultLocale();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->hasCustomData === false) {
            $this->collectCustomData($this->entityName, $this->getId());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $data = $_POST['custom_field'];

        foreach ($this->customFields as $fieldObject) {
            if (!array_key_exists($fieldObject['Id'], $_POST['custom_field'])) {
                $data[$fieldObject['Id']] = '';
            }
            foreach ($data as $key => $value) {
                if ((int) $key == $fieldObject['Id']) {

                    $objCustomData = CustomFieldsDataQuery::create()
                        ->filterByentityId($this->entityId)
                        ->filterByfieldId($key)
                        ->filterByLocale($locale)
                        ->findOne();
                    if ($objCustomData) {
                        $objCustomData->setdata($value);
                        $objCustomData->save();
                        break;
                    } else {
                        $fieldObject = new CustomFieldsData();
                        $fieldObject->setentityId($this->entityId);
                        $fieldObject->setfieldId($key);
                        $fieldObject->setdata($value);
                        $fieldObject->setLocale($locale);
                        $fieldObject->save();
                        break;
                    }
                }
            }
        }
    }

    /**
     * @param $attributeName

     * @return mixed
     */
    public function getLabel($attributeName) {
        if (method_exists($this, 'attributeLabels')) {
            $labels = $this->attributeLabels();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            if (isset($labels[$attributeName])) {
                return $labels[$attributeName];
            } else {
                return $attributeName;
            }
        }
    }

    /**
     * @param string $column
     * @return bool
     */
    public function getVirtual($column) {
        $column = strtolower($column);
        return $this->getVirtualColumn($column);
    }

    /**
     * @param string $name
     * @return bool
     */
    public function getVirtualColumn($name) {
        $name = strtolower($name);

        if (!$this->hasVirtualColumn($name)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return false;
        }
        return parent::getVirtualColumn($name);
    }

    /**
     * Convert model attribute(by default Price). e.g. "99.99 $"
     *
     * @param string $attributeName Optional. Attribute name to convert.
     * @access public
     * @return string
     */
    public function toCurrency($attributeName = 'Price', $cId = null, $convertForTemplate = false) {
        $attributeName = strtolower($attributeName);
        $get = 'get' . $attributeName;

        if (!$convertForTemplate) {
            if ($attributeName == 'origprice') {
                return Currency::create()->convert($this->getVirtualColumn('origprice'), $cId);
            }
            return Currency::create()->convert($this->$get(), $cId);
        } else {
            if ($attributeName == 'origprice') {
                return Currency::create()->convertForTemplate($this->getVirtualColumn('origprice'), $cId);
            }
            return Currency::create()->convertForTemplate($this->$get(), $cId);
        }
    }

    /**
     * Simple getter.
     *
     * @param  $name

     * @return

     */
    public function __get($name) {
        if (isset($this->$name)) {
            return $this->$name;
        }

        $call = 'get' . $name;
        if (method_exists($this, $call)) {
            return $this->$call();
        }
    }

    /**
     * @return CacheProvider

     */
    public function getCache() {

        return DependencyInjectionProvider::getContainer()->get('cache');
    }

    public function __call($name, $param) {

        if (preg_match('/get(\w+)/', $name, $matches)) {
            $virtualColumn = $matches[1];
            $virtualColumn = strtolower($virtualColumn);
            if ($this->hasVirtualColumn($virtualColumn)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->getVirtualColumn($virtualColumn);
            }
            // no lcfirst in php<5.3...
            $virtualColumn[0] = strtolower($virtualColumn[0]);
            if ($this->hasVirtualColumn($virtualColumn)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->getVirtualColumn($virtualColumn);
            }
        }
    }

    public function setVirtualColumn($name, $value) {

        $name = strtolower($name);

        parent::setVirtualColumn($name, $value);
    }

    public function preSave(ConnectionInterface $con = null) {
        return true;
    }

    public function postSave(ConnectionInterface $con = null) {
        return true;
    }

    public function preInsert(ConnectionInterface $con = null) {
        return true;
    }

    public function postInsert(ConnectionInterface $con = null) {
        return true;
    }

    public function preUpdate(ConnectionInterface $con = null) {
        return true;
    }

    public function postUpdate(ConnectionInterface $con = null) {
        return true;
    }

    public function postDelete(ConnectionInterface $con = null) {
        return true;
    }

    public function preDelete(ConnectionInterface $con = null) {
        return true;
    }

    /**
     * String representation of object
     * @link http://php.net/manual/en/serializable.serialize.php
     * @return string the string representation of the object or null
     * @since 5.1.0
     */
    public function serialize() {
        $this->prepareToSleep();

        $cls = new \ReflectionClass($this);
        $propertyNames = [];
        $serializableProperties = array_diff($cls->getProperties(), $cls->getProperties(\ReflectionProperty::IS_STATIC));

        foreach ($serializableProperties as $property) {

            $propertyName = $property->getName();
            $propertyValue = $this->$propertyName;

            if ($propertyValue !== null) {
                $propertyNames[$propertyName] = $propertyValue;

            }

        }

        return serialize($propertyNames);
    }

    private function prepareToSleep() {
        $this->collSCategoriesRelatedById = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->collSCategoryI18ns = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->collSProductss = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->collShopProductCategoriess = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->collShopProductPropertiesCategoriess = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->collProducts = null;

        $this->collProperties = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->aSCategory = null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Constructs the object
     * @link http://php.net/manual/en/serializable.unserialize.php
     * @param string $serialized <p>

     * The string representation of the object.
     * </p>

     * @return void

     * @since 5.1.0
     */
    public function unserialize($serialized) {
        $serialized = unserialize($serialized);

        foreach ($serialized as $key => $item) {

            $this->$key = $item;

        }

    }

}

1			<?php
2
3			namespace CMSFactory;
4
5			use CMSFactory\DependencyInjection\DependencyInjectionProvider;
6			use Currency\Currency;
7			use CustomFieldsData;
8			use CustomFieldsDataQuery;
9			use CustomFieldsQuery;
10			use Doctrine\Common\Cache\CacheProvider;
11			use MY_Controller;
12			use MY_Form_validation;
13			use Propel\Runtime\Connection\ConnectionInterface;
14
15			class PropelBaseModelClass implements \Serializable
16			{
			0 ignored issues – show introduced 2016-10-28 09:50 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the same line as the definition Loading history...
17
18			public $customFields;
19
20			public $customData;
21
22			public $hasCustomData = false;
23
24			public $entityId;
25
26			private $entities_locale = [
27			'product',
28			'category',
29			'brand',
30			];
31
32			/**
33			* @param MY_Form_validation $validator
34			* @return mixed
			0 ignored issues – show Documentation introduced 2016-10-28 09:50 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `MY_Form_validation`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
35			*/
36			public function validateCustomData($validator) {
37			if (!empty($this->entityName)) {
			0 ignored issues – show Documentation introduced 2016-10-28 09:50 UTC by Report Bug Copy Issue Report The property `entityName` does not exist on `object<CMSFactory\PropelBaseModelClass>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...

imagecms / ImageCMS

Push — development ( 67765c...7029e6 )

PropelBaseModelClass C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

23 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like