Found_less_expensive::_install() - Code Metrics - Inspection of "prep 4.11" - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( ef9e73...b2c3e4 )

by Andrij

created 2016-08-02 13:25 UTC

Found_less_expensive::_install() A

↳ Parent: Found_less_expensive

Complexity

Conditions	2
Paths	2

Size

Total Lines	69
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	2
eloc	50
c	4
b	0
f	0
nc	2
nop	0
dl	0
loc	69
rs	9.2083

How to fix Long Method

<?php

use cmsemail\email;
use CMSFactory\assetManager;

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * @property Found_less_expensive_model found_less_expensive_model
 * @author Igor R.
 * @copyright ImageCMS (c) 2013, Igor R. <[email protected]>
 *
 * In order to render button and link insert into product template
 * {$CI->load->module('found_less_expensive')->showButtonWithForm()}
 *
 * Нашли дешевле
 */
class Found_less_expensive extends MY_Controller
{


    public function __construct() {

        parent::__construct();
        $this->load->model('found_less_expensive_model');
        $this->load->library('email');
        $lang = new MY_Lang();
        $lang->load('found_less_expensive');
    }

    public static function adminAutoload() {
        parent::adminAutoload();
    }

    /**
     * Display button and form
     */
    public function showButtonWithForm() {
        assetManager::create()
                ->registerStyle('style')
                ->registerScript('scripts')
                ->render('buttonWithForm', true);
    }

    /**
     * @return array|string
     */
    public function save_message() {

        $this->load->library('from_validation');
        $this->form_validation->set_rules('name', lang('Name', 'admin'), 'required');
        $this->form_validation->set_rules('phone', lang('Phone', 'admin'), 'required|numeric');
        $this->form_validation->set_rules('email', lang('Email', 'admin'), 'required|valid_email');
        $this->form_validation->set_rules('link', lang('link', 'admin'), 'required');

        if (!$this->form_validation->run()) {
            return [
                    'message' => validation_errors(),
                    'errors'  => $this->form_validation->getErrorsArray(),
                   ];
        }

        $data = $this->input->post();
        $data['date'] = time();
        $data['status'] = 0;
        unset($data['cms_token']);
        if ($this->db->insert('mod_found_less_expensive', $data)) {
            $this->sendEmail($data);
            return 'success';
        }
    }

    /**
     * Send email
     * @param array $messageData
     * @return bool

     */
    public function sendEmail(array $messageData) {

        $variables = [
                      'userName'    => $messageData['name'],
                      'userEmail'   => $messageData['email'],
                      'userPhone'   => $messageData['phone'],
                      'userLink'    => $messageData['link'],
                      'userMessage' => $messageData['question'],
                      'date'        => date('d-m-Y H:i:s', $messageData['date']),
                      'productUrl'  => $messageData['productUrl'],

                     ];
        return email::getInstance()->sendEmail($this->dx_auth->get_user_email(), 'Found_less_expensive', $variables);
    }

    /**
     * Install module
     */
    public function _install() {

        $email_patterns = $this->found_less_expensive_model->getEmailPatterns();
        $this->db->insert('mod_email_paterns', $email_patterns);

        $email_patterns_i18n = $this->found_less_expensive_model->getEmailPatternsI18n();
        $this->db->insert('mod_email_paterns_i18n', $email_patterns_i18n);

        $this->load->dbforge();
        ($this->dx_auth->is_admin()) OR exit;
        $fields = [
                   'id'         => [
                                    'type'           => 'INT',
                                    'auto_increment' => TRUE,
                                   ],
                   'name'       => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '70',
                                    'null'       => TRUE,
                                   ],
                   'email'      => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '50',
                                    'null'       => TRUE,
                                   ],
                   'phone'      => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '50',
                                    'null'       => TRUE,
                                   ],
                   'question'   => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '250',
                                    'null'       => TRUE,
                                   ],
                   'link'       => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '150',
                                    'null'       => TRUE,
                                   ],
                   'productUrl' => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '250',
                                    'null'       => TRUE,
                                   ],
                   'date'       => [
                                    'type' => 'INT',
                                    'null' => TRUE,
                                   ],
                   'status'     => [
                                    'type'       => 'VARCHAR',
                                    'constraint' => '150',
                                    'null'       => TRUE,
                                   ],
                  ];

        $this->dbforge->add_field($fields);
        $this->dbforge->add_key('id', TRUE);
        $this->dbforge->create_table('mod_found_less_expensive');

        $this->db->where('name', 'found_less_expensive');
        $this->db->update(
            'components',
            [
             'enabled'  => 1,
             'autoload' => 1,
            ]
        );
    }

    /**
     * Deinstall module
     */
    public function _deinstall() {
        $this->load->dbforge();
        ($this->dx_auth->is_admin()) OR exit;
        $this->dbforge->drop_table('mod_found_less_expensive');
    }

}

1		<?php
2
3		use cmsemail\email;
4		use CMSFactory\assetManager;
5
6		if (!defined('BASEPATH')) {
7		exit('No direct script access allowed');
8		}
9
10		/**
11		* @property Found_less_expensive_model found_less_expensive_model
12		* @author Igor R.
13		* @copyright ImageCMS (c) 2013, Igor R. <[email protected]>
14		*
15		* In order to render button and link insert into product template
16		* {$CI->load->module('found_less_expensive')->showButtonWithForm()}
17		*
18		* Нашли дешевле
19		*/
20		class Found_less_expensive extends MY_Controller
21		{
		0 ignored issues – show introduced 2016-05-10 10:17 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the same line as the definition Loading history...
22
23		public function __construct() {
24
25		parent::__construct();
26		$this->load->model('found_less_expensive_model');
27		$this->load->library('email');
28		$lang = new MY_Lang();
29		$lang->load('found_less_expensive');
30		}
31
32		public static function adminAutoload() {
33		parent::adminAutoload();
34		}
35
36		/**
37		* Display button and form
38		*/
39		public function showButtonWithForm() {
40		assetManager::create()
41		->registerStyle('style')
42		->registerScript('scripts')
43		->render('buttonWithForm', true);
44		}
45
46		/**
47		* @return array\|string
48		*/
49		public function save_message() {
50
51		$this->load->library('from_validation');
52		$this->form_validation->set_rules('name', lang('Name', 'admin'), 'required');
53		$this->form_validation->set_rules('phone', lang('Phone', 'admin'), 'required\|numeric');
54		$this->form_validation->set_rules('email', lang('Email', 'admin'), 'required\|valid_email');
55		$this->form_validation->set_rules('link', lang('link', 'admin'), 'required');
56
57	View Code Duplication	if (!$this->form_validation->run()) {
58		return [
59		'message' => validation_errors(),
60		'errors' => $this->form_validation->getErrorsArray(),
61		];
62		}
63
64		$data = $this->input->post();
65		$data['date'] = time();
66		$data['status'] = 0;
67		unset($data['cms_token']);
68		if ($this->db->insert('mod_found_less_expensive', $data)) {
69		$this->sendEmail($data);
70		return 'success';
71		}
72		}
73
74		/**
75		* Send email
76		* @param array $messageData
77		* @return bool
		0 ignored issues – show Documentation introduced 2016-08-02 13:45 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|array`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
78		*/
79		public function sendEmail(array $messageData) {
80
81		$variables = [
82		'userName' => $messageData['name'],
83		'userEmail' => $messageData['email'],
84		'userPhone' => $messageData['phone'],
85		'userLink' => $messageData['link'],
86		'userMessage' => $messageData['question'],
87		'date' => date('d-m-Y H:i:s', $messageData['date']),
88		'productUrl' => $messageData['productUrl'],
89
90		];
91		return email::getInstance()->sendEmail($this->dx_auth->get_user_email(), 'Found_less_expensive', $variables);
92		}
93
94		/**
95		* Install module
96		*/
97		public function _install() {
98
99		$email_patterns = $this->found_less_expensive_model->getEmailPatterns();
100		$this->db->insert('mod_email_paterns', $email_patterns);
101
102		$email_patterns_i18n = $this->found_less_expensive_model->getEmailPatternsI18n();
103		$this->db->insert('mod_email_paterns_i18n', $email_patterns_i18n);
104
105		$this->load->dbforge();
106		($this->dx_auth->is_admin()) OR exit;
107		$fields = [
108		'id' => [
109		'type' => 'INT',
110		'auto_increment' => TRUE,
111		],
112		'name' => [
113		'type' => 'VARCHAR',
114		'constraint' => '70',
115		'null' => TRUE,
116		],
117		'email' => [
118		'type' => 'VARCHAR',
119		'constraint' => '50',
120		'null' => TRUE,
121		],
122		'phone' => [
123		'type' => 'VARCHAR',
124		'constraint' => '50',
125		'null' => TRUE,
126		],
127		'question' => [
128		'type' => 'VARCHAR',
129		'constraint' => '250',
130		'null' => TRUE,
131		],
132		'link' => [
133		'type' => 'VARCHAR',
134		'constraint' => '150',
135		'null' => TRUE,
136		],
137		'productUrl' => [
138		'type' => 'VARCHAR',
139		'constraint' => '250',
140		'null' => TRUE,
141		],
142		'date' => [
143		'type' => 'INT',
144		'null' => TRUE,
145		],
146		'status' => [
147		'type' => 'VARCHAR',
148		'constraint' => '150',
149		'null' => TRUE,
150		],
151		];
152
153		$this->dbforge->add_field($fields);
154		$this->dbforge->add_key('id', TRUE);
155		$this->dbforge->create_table('mod_found_less_expensive');
156
157		$this->db->where('name', 'found_less_expensive');
158		$this->db->update(
159		'components',
160		[
161		'enabled' => 1,
162		'autoload' => 1,
163		]
164		);
165		}
166
167		/**
168		* Deinstall module
169		*/
170		public function _deinstall() {
171		$this->load->dbforge();
172		($this->dx_auth->is_admin()) OR exit;
173		$this->dbforge->drop_table('mod_found_less_expensive');
174		}
175
176		}

imagecms / ImageCMS

Push — development ( ef9e73...b2c3e4 )

Found_less_expensive::_install() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like