Lib_csrf::addDisabledCsrfUrls() - Code Metrics - Inspection of "4.9" - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( eb9524...db4517 )

by Andrij

created 2016-02-25 14:36 UTC

Lib_csrf::addDisabledCsrfUrls() F

↳ Parent: Lib_csrf

Complexity

Conditions	35
Paths	4096

Size

Total Lines	47
Code Lines	26

Duplication

Lines	18
Ratio	38.3 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	18
loc	47
rs	2.62
cc	35
eloc	26
nc	4096
nop	0

How to fix Complexity

<?php

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * Image CMS
 * CSRF Library Beta.
 */
class Lib_csrf
{


    public $ci = NULL;

    private $enc_key = '';

    private $tokens = [];     // User token.

    private $sess_id = NULL;     // Session id.

    private $hidden_name = 'cms_token';

    private $max_tokens = 10;

    public $log_errors = FALSE;

    public $log_ajax_requests = FALSE;

    public function __construct() {
        $this->ci = &get_instance();

        $this->_generate_token();

        if ($this->check_token() === FALSE) {
            if ($this->log_errors === TRUE) {
                $this->_write_message('Wrong code.');
            }

            $err_text = 'Подозрение на атаку Cross-Site Request Forgery.';
            show_error($err_text);
            die();
        }
    }

    private function addDisabledCsrfUrls() {

        // Diable CSRF library form web money service
        $ci = $this->ci;
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('result') == 'true' && $ci->input->get('pm') > 0) {
            define('ICMS_DISBALE_CSRF', true);
        }
        // Support for robokassa
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('getResult') == 'true') {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->uri->segment(1) == 'exchange') {
            define('ICMS_DISBALE_CSRF', true);
        }
        // Support for privat
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'order' && $ci->uri->segment(3) == 'view' && $ci->input->post()) {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('succes') == 'true') {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('fail') == 'true') {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->input->server('HTTP_REFERER') AND strpos($ci->input->server('HTTP_REFERER') . "", 'facebook.com')) {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->input->server('HTTP_REFERER') AND strpos($ci->input->server('HTTP_REFERER') . "", 'facebook.com')) {
            define('ICMS_DISBALE_CSRF', true);
        }
        // Support for privat

        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'order' && $ci->uri->segment(3) == 'view') {
            define('ICMS_DISBALE_CSRF', true);
        }
        //new payment system
        if (preg_match("/payment_method_/i", $ci->uri->segment(1)) || preg_match("/payment_method_/i", $ci->uri->segment(2))) {
            define('ICMS_DISBALE_CSRF', true);
        }
        if ($ci->uri->segment(1) == 'facebook_store' && $ci->uri->segment(2) == 'auth_from_fb_store') {
            define('ICMS_DISBALE_CSRF', true);
        }

        if ($ci->uri->segment(4) == 'xbanners') {
            define('ICMS_DISBALE_CSRF', true);
        }
    }

    private function check_token() {
        $this->addDisabledCsrfUrls();
        if (count($_POST) > 0) {

            if (defined('ICMS_DISBALE_CSRF') AND ICMS_DISBALE_CSRF === TRUE) {
                return TRUE;
            }
            // Don't check ajax requests
            if (isset($_SERVER['HTTP_X_REQUESTED_WITH'])) {
                if (strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
                    if ($this->log_ajax_requests === TRUE) {
                        $this->_write_message('Ajax Request');
                    }
                    return TRUE;
                }
            }

            $post_token = $this->ci->input->post($this->hidden_name);

            if (array_search($post_token, $this->tokens) == FALSE) {
                if ($this->tokens[0] != $post_token) {
                    return FALSE;
                }
            }
        }

        return TRUE;
    }

    /**
     * Create input hidden
     */
    public function create_hidden_html() {
        return '<input type="hidden" value="' . $this->get_token() . '" name="' . $this->hidden_name . '" />';
    }

    /**
     * @param string $text
     */
    private function _write_message($text) {
        $this->ci->load->helper('file');

        $post_data = '<br/>Post data:<br/>';
        foreach ($_POST as $k => $v) {

            $post_data .= $k . ': ' . $v . '<br/>';
        }

        $request_uri = 'Request uri: ' . $_SERVER['REQUEST_URI'] . '<br/><br/>';

        $new_text = '<p>' . date('d-m-Y H:i:s') . ' IP:' . $_SERVER['REMOTE_ADDR'] . ' Referer: ' . $_SERVER['HTTP_REFERER'] . '<br/>' . $request_uri . $text . $post_data . '<br/>________________</p>';


        @write_file('./application/logs/csrf.html', $new_text, 'a');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    private function _generate_token() {
        $this->sess_id = $this->_get_sess_id();
        $n_token = md5($this->sess_id . $this->enc_key);

        $this->tokens = $this->ci->session->userdata('ci_tokens');

        if (is_array($this->tokens) AND count($this->tokens) > $this->max_tokens) {
            $this->tokens = array_slice($this->tokens, -3, 3);
        }

        if (is_array($this->tokens)) {
            if (array_search($n_token, $this->tokens) === FALSE) {
                $this->tokens[] = $n_token;
            }
        } else {
            $this->tokens = [];
            $this->tokens[] = $n_token;
        }

        $this->ci->session->set_userdata('ci_tokens', $this->tokens);
    }

    public function get_token() {
        if (count($this->tokens) == 0) {
            $this->_generate_token();
        }
        return array_pop($this->tokens);
    }

    private function _get_sess_id() {
        return $this->ci->session->userdata('session_id');
    }

}

/* End of file lib_csfr.php */

1		<?php
2
3		if (!defined('BASEPATH')) {
4		exit('No direct script access allowed');
5		}
6
7		/**
8		* Image CMS
9		* CSRF Library Beta.
10		*/
11		class Lib_csrf
12		{
		0 ignored issues – show introduced 2016-02-25 15:02 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the same line as the definition Loading history...
13
14		public $ci = NULL;
15
16		private $enc_key = '';
17
18		private $tokens = []; // User token.
19
20		private $sess_id = NULL; // Session id.
21
22		private $hidden_name = 'cms_token';
23
24		private $max_tokens = 10;
25
26		public $log_errors = FALSE;
27
28		public $log_ajax_requests = FALSE;
29
30		public function __construct() {
31		$this->ci = &get_instance();
32
33		$this->_generate_token();
34
35		if ($this->check_token() === FALSE) {
36		if ($this->log_errors === TRUE) {
37		$this->_write_message('Wrong code.');
38		}
39
40		$err_text = 'Подозрение на атаку Cross-Site Request Forgery.';
41		show_error($err_text);
42		die();
43		}
44		}
45
46		private function addDisabledCsrfUrls() {
47
48		// Diable CSRF library form web money service
49		$ci = $this->ci;
50	View Code Duplication	if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('result') == 'true' && $ci->input->get('pm') > 0) {
51		define('ICMS_DISBALE_CSRF', true);
52		}
53		// Support for robokassa
54	View Code Duplication	if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('getResult') == 'true') {
55		define('ICMS_DISBALE_CSRF', true);
56		}
57		if ($ci->uri->segment(1) == 'exchange') {
58		define('ICMS_DISBALE_CSRF', true);
59		}
60		// Support for privat
61		if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'order' && $ci->uri->segment(3) == 'view' && $ci->input->post()) {
62		define('ICMS_DISBALE_CSRF', true);
63		}
64	View Code Duplication	if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('succes') == 'true') {
65		define('ICMS_DISBALE_CSRF', true);
66		}
67	View Code Duplication	if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('fail') == 'true') {
68		define('ICMS_DISBALE_CSRF', true);
69		}
70	View Code Duplication	if ($ci->input->server('HTTP_REFERER') AND strpos($ci->input->server('HTTP_REFERER') . "", 'facebook.com')) {
71		define('ICMS_DISBALE_CSRF', true);
72		}
73	View Code Duplication	if ($ci->input->server('HTTP_REFERER') AND strpos($ci->input->server('HTTP_REFERER') . "", 'facebook.com')) {
74		define('ICMS_DISBALE_CSRF', true);
75		}
76		// Support for privat
77
78		if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'order' && $ci->uri->segment(3) == 'view') {
79		define('ICMS_DISBALE_CSRF', true);
80		}
81		//new payment system
82		if (preg_match("/payment_method_/i", $ci->uri->segment(1)) \|\| preg_match("/payment_method_/i", $ci->uri->segment(2))) {
83		define('ICMS_DISBALE_CSRF', true);
84		}
85		if ($ci->uri->segment(1) == 'facebook_store' && $ci->uri->segment(2) == 'auth_from_fb_store') {
86		define('ICMS_DISBALE_CSRF', true);
87		}
88
89		if ($ci->uri->segment(4) == 'xbanners') {
90		define('ICMS_DISBALE_CSRF', true);
91		}
92		}
93
94		private function check_token() {
95		$this->addDisabledCsrfUrls();
96		if (count($_POST) > 0) {
		0 ignored issues – show introduced 2015-11-28 17:39 UTC by Report Bug Copy Issue Report The $_POST super global must not be accessed directly; use Security::getRequestData() instead Loading history...
97		if (defined('ICMS_DISBALE_CSRF') AND ICMS_DISBALE_CSRF === TRUE) {
98		return TRUE;
99		}
100		// Don't check ajax requests
101		if (isset($_SERVER['HTTP_X_REQUESTED_WITH'])) {
102		if (strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
103		if ($this->log_ajax_requests === TRUE) {
104		$this->_write_message('Ajax Request');
105		}
106		return TRUE;
107		}
108		}
109
110		$post_token = $this->ci->input->post($this->hidden_name);
111
112		if (array_search($post_token, $this->tokens) == FALSE) {
113		if ($this->tokens[0] != $post_token) {
114		return FALSE;
115		}
116		}
117		}
118
119		return TRUE;
120		}
121
122		/**
123		* Create input hidden
124		*/
125		public function create_hidden_html() {
126		return '<input type="hidden" value="' . $this->get_token() . '" name="' . $this->hidden_name . '" />';
127		}
128
129		/**
130		* @param string $text
131		*/
132		private function _write_message($text) {
133		$this->ci->load->helper('file');
134
135		$post_data = '<br/>Post data:<br/>';
136		foreach ($_POST as $k => $v) {
		0 ignored issues – show introduced 2015-11-28 17:39 UTC by Report Bug Copy Issue Report The $_POST super global must not be accessed directly; use Security::getRequestData() instead Loading history...
137		$post_data .= $k . ': ' . $v . '<br/>';
138		}
139
140		$request_uri = 'Request uri: ' . $_SERVER['REQUEST_URI'] . '<br/><br/>';
141
142		$new_text = '<p>' . date('d-m-Y H:i:s') . ' IP:' . $_SERVER['REMOTE_ADDR'] . ' Referer: ' . $_SERVER['HTTP_REFERER'] . '<br/>' . $request_uri . $text . $post_data . '<br/>________________</p>';
		0 ignored issues – show introduced 2015-11-28 17:39 UTC by Report Bug Copy Issue Report Use the function ip_address() instead of $_SERVER['REMOTE_ADDR'] Loading history...
143
144		@write_file('./application/logs/csrf.html', $new_text, 'a');
		0 ignored issues – show Security Best Practice introduced 2015-11-28 17:39 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
145		}
146
147		private function _generate_token() {
148		$this->sess_id = $this->_get_sess_id();
149		$n_token = md5($this->sess_id . $this->enc_key);
150
151		$this->tokens = $this->ci->session->userdata('ci_tokens');
152
153		if (is_array($this->tokens) AND count($this->tokens) > $this->max_tokens) {
154		$this->tokens = array_slice($this->tokens, -3, 3);
155		}
156
157		if (is_array($this->tokens)) {
158		if (array_search($n_token, $this->tokens) === FALSE) {
159		$this->tokens[] = $n_token;
160		}
161		} else {
162		$this->tokens = [];
163		$this->tokens[] = $n_token;
164		}
165
166		$this->ci->session->set_userdata('ci_tokens', $this->tokens);
167		}
168
169		public function get_token() {
170		if (count($this->tokens) == 0) {
171		$this->_generate_token();
172		}
173		return array_pop($this->tokens);
174		}
175
176		private function _get_sess_id() {
177		return $this->ci->session->userdata('session_id');
178		}
179
180		}
181
182		/* End of file lib_csfr.php */

imagecms / ImageCMS

Push — development ( eb9524...db4517 )

Lib_csrf::addDisabledCsrfUrls() F

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like