Banners\Statistic\ClickStatistic

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	run()	0	9	2
A	increaseClicks()	0	5	1
A	goToUrl()	0	4	1

<?php

namespace xbanners\src\Statistic;

use xbanners\models\BannerImageQuery;

/**
 * Click Statistic class
 */
class ClickStatistic
{

Opening brace of a class must be on the same line as the definition

    /**
     * Banner image object
     * @var array|\Banners\Models\BannerImage|mixed
     */
    private $bannerImage;

    public function __construct($imageIdMd5, $locale = NULL) {

        $locale = $locale ? $locale : \MY_Controller::getCurrentLocale();

        $this->bannerImage = BannerImageQuery::create()
            ->joinWithI18n($locale)
            ->where('md5(BannerImage.Id) = ?', $imageIdMd5)
            ->findOne();
    }

    /**
     * Run click statistic
     */
    public function run() {

        if ($this->bannerImage->getUrl()) {
            $this->increaseClicks();
            $this->goToUrl();
        } else {
            \CI::$APP->core->error_404();
        }
    }

    /**
     * Increase banner image clicks value
     * @throws \Propel\Runtime\Exception\PropelException

Comment missing or not on the next line for @throws tag in function comment

     */
    public function increaseClicks() {

        $this->bannerImage->setClicks($this->bannerImage->getClicks() + 1);
        $this->bannerImage->save();
    }

    /**
     * Go to banner image url
     */
    private function goToUrl() {

        redirect($this->bannerImage->getUrl(), 'location', '301');
    }

    /**
     * Get click statistic
     * @param $imageId - banner image id

Missing parameter type

     * @return string
     */
    public static function getUrl($imageId) {

        return site_url('xbanners/go') . '/' . md5($imageId);
    }

}