Banners\Managers\BannerPageTypesManager

Complexity

Total Complexity

15

Size/Duplication

Total Lines	108
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getInstance()	0	6	2
B	getPagesTypes()	0	34	2
B	getView()	12	12	5
B	getPages()	12	12	5

<?php
namespace xbanners\src\Managers;

class BannerPageTypesManager

Since you have declared the constructor as private, maybe you should also declare the class as final.

{

Opening brace of a class must be on the same line as the definition

    const PAGE_TYPE_MAIN = 'main';
    const PAGE_TYPE_SHOP_CATEGORY = 'shop_category';
    const PAGE_TYPE_PRODUCT = 'product';
    const PAGE_TYPE_CATEGORY = 'category';
    const PAGE_TYPE_PAGE = 'page';
    const PAGE_TYPE_BRAND = 'brand';
    const PAGE_TYPE_SEARCH = 'search';

    /**
     * @var BannerPageTypesManager instance
     */
    private static $instance = NULL;

    private function __construct() {

    }

    /**
     * Get BannerPageTypesManager instance
     * @return BannerPageTypesManager instance
     */
    public static function getInstance() {
        if (null === self::$instance) {
            self::$instance = new self();
        }
        return self::$instance;
    }

    /**
     * Get banner pages type|types: ['main', 'shop_category', 'product',...] on nothing to get all types array
     * @param string $type - banner type

Should the type for parameter $type not be string|null?

     * @return array
     */
    public function getPagesTypes($type = NULL) {
        $pageTypes = [
            'main' => [
                'name' => lang('Main', 'xbanners'),
                'class' => NULL
            ],
            'shop_category' => [
                'name' => lang('Product category', 'xbanners'),
                'class' => '\xbanners\src\BannerPagesTypes\ShopCategory'
            ],
            'product' => [
                'name' => lang('Product', 'xbanners'),
                'class' => '\xbanners\src\BannerPagesTypes\Product'
            ],
            'category' => [
                'name' => lang('Page category', 'xbanners'),
                'class' => '\xbanners\src\BannerPagesTypes\Category'
            ],
            'page' => [
                'name' => lang('Page', 'xbanners'),
                'class' => '\xbanners\src\BannerPagesTypes\Page'
            ],
            'brand' => [
                'name' => lang('Product brand', 'xbanners'),
                'class' => '\xbanners\src\BannerPagesTypes\Brand'
            ],
            'search' => [
                'name' => lang('Search page', 'xbanners'),
                'class' => NULL
            ],
        ];

        return $type ? $pageTypes[$type] : $pageTypes;
    }

    /**
     * Get banner type view
     * @param string $type - banner page type name type: ['main', 'shop_category', 'product',...]
     * @param string $locale - locale name

Should the type for parameter $locale not be string|null?

     * @return array
     */
    public function getView($type, $locale = NULL) {
        $locale = $locale ? $locale : \MY_Controller::defaultLocale();
        $type = $this->getPagesTypes($type);

        if (!$type OR !$type['class'] OR !class_exists($type['class'])) {
            return NULL;
        }

        $typeObj = new $type['class']($locale);

        return $typeObj->getView();
    }

    /**
     * Get banner page type allowed pages list
     * @param string $type - banner page type name type: ['main', 'shop_category', 'product',...]
     * @param string $locale - locale name

Should the type for parameter $locale not be string|null?

     * @return array
     */
    public function getPages($type, $locale = NULL) {
        $locale = $locale ? $locale : \MY_Controller::defaultLocale();
        $type = $this->getPagesTypes($type);

        if (!$type OR !$type['class'] OR !class_exists($type['class'])) {
            return NULL;
        }

        $typeObj = new $type['class']($locale);

        return $typeObj->getPages();
    }
}