Banners\Entities\BannerView

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getBanner()	0	3	1
A	show()	0	6	1
A	render()	0	3	1

<?php

namespace xbanners\src\Entities;

use xbanners\models\Banners;

class BannerView
{

Opening brace of a class must be on the same line as the definition

    /**
     * @var \Banners\Models\Banners
     */
    protected $banner;

    /**
     * @param Banners $banner
     */
    public function __construct(Banners $banner) {
        $this->banner = $banner;

$banner is of type object<xbanners\models\Banners>, but the property $banner was declared to be of type object<Banners\Models\Banners>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @return Banners

Consider making the return type a bit more specific; maybe use \Banners\Models\Banners.

     */
    public function getBanner() {
        return $this->banner;
    }

    /**
     * @return string
     */
    public function show() {
        $data = [
            'banner' => $this->banner,
        ];
        return $this->render($data);
    }

    /**
     * @return string
     */
    protected function render($data) {
        return \Ci::$APP->load->module('xbanners')->show($data);
    }

}