Custom_model::getLastViewedPage() - Code Metrics - Inspection of "4.12.1" - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( cfd391...deed4d )

by Andrij

created 2017-03-23 14:49 UTC

Custom_model::getLastViewedPage() B

↳ Parent: Custom_model

Complexity

Conditions	6
Paths	6

Size

Total Lines	73
Code Lines	19

Duplication

Lines	73
Ratio	100 %

Importance

Changes

Metric	Value
cc	6
eloc	19
nc	6
nop	0
dl	73
loc	73
rs	8.5021
c	0
b	0
f	0

How to fix Long Method

<?php
use core\models\Route;
use core\models\RouteQuery;
use core\src\CoreFactory;

/**
 * Class Attendance_model for mod_stats module
 *
 * @uses          \CI_Model
 * @author        DevImageCms
 * @copyright (c) 2014, ImageCMS
 * @property CI_DB_active_record $db
 * @package       ImageCMSModule
 */
class Custom_model extends CI_Model
namespace YourVendor;

class YourClass { }
{

    /**
     *
     * @return int
     */
    public function getAllTimeCountUnique() {
        $query
            = '

            SELECT 
                COUNT(DISTINCT `id_user`) AS `count`
            FROM 
                `mod_stats_attendance`
        ';

        return $this->db->query($query)->row()->count;
    }

    /**
     *
     * @return int
     */
    public function getAllTimeCountUniqueRobots() {
        $query
            = '

            SELECT 
                COUNT(DISTINCT `id_robot`) AS `count`
            FROM 
                `mod_stats_attendance_robots`
        ';

        return $this->db->query($query)->row()->count;
    }

    /**
     *
     * @return int
     */
    public function getLastViewedPage() {
        $locale = MY_Controller::getCurrentLocale();

        $query
                = "

SELECT
    `users`.`username`,
    `type_id`,
    `route`.`type`,
    `id_entity`,
    (CASE `mod_stats_attendance`.`type_id` 
    WHEN 1 THEN `content`.`title` 
    WHEN 2 THEN `category`.`name`
    WHEN 3 THEN `shop_category_i18n`.`name` 
    WHEN 4 THEN `shop_products_i18n`.`name`
END) AS `page_name`
FROM
    `mod_stats_attendance`
LEFT JOIN
    route
ON
    route.entity_id = mod_stats_attendance.id_entity
LEFT JOIN
    `content`
ON
    `content`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 1
LEFT JOIN
    `category`
ON
    `category`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 2
LEFT JOIN
    `shop_category`
ON
    `shop_category`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 3
LEFT JOIN
    `shop_products`
ON
    `shop_products`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 4
LEFT JOIN
    `shop_category_i18n`
ON
    `shop_category`.`id` = `shop_category_i18n`.`id` AND `shop_category_i18n`.`locale` = '{$locale}'
LEFT JOIN
    `shop_products_i18n`
ON
    `shop_products`.`id` = `shop_products_i18n`.`id` AND `shop_products_i18n`.`locale` = '{$locale}'
LEFT JOIN
    `users`
ON
    `users`.`id` = `mod_stats_attendance`.`id_user`
ORDER BY
    `mod_stats_attendance`.`time_add`
DESC
LIMIT 1
        ";
        $result = $this->db->query($query);
        if ($result) {
            $result = $result->row_array();
            if ($result['type_id'] == Attendance::PAGE) {
                $result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_PAGE);
            } elseif ($result['type_id'] == Attendance::CATEGORY) {
                $result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_CATEGORY);
            } elseif ($result['type_id'] == Attendance::SHOP_CATEGORY) {
                $result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_SHOP_CATEGORY);
            } elseif ($result['type_id'] == Attendance::PRODUCT) {
                $result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_PRODUCT);
            }

            return $result;
        }

        return false;
    }

    protected function getUrl($id, $type) {
        $urlConfiguration = CoreFactory::getConfiguration()->getUrlRules();
        $url              = RouteQuery::create()->filterByEntityId($id)->filterByType($type)->findOneOrCreate();
        if ($type == Route::TYPE_SHOP_CATEGORY) {
            if ($urlConfiguration['shop_category']['parent'] === '1') {
                $url = $url->getFullUrl();
            } else {
                $url = $url->getUrl();
            }
            if ($urlConfiguration['shop_category']['prefix'] != '') {
                $url = rtrim($urlConfiguration['shop_category']['prefix'], '/') . '/' . $url;
            }

            return $url;
        } elseif ($type == Route::TYPE_PRODUCT) {
            if ($urlConfiguration['product']['parent'] === '1') {
                $url = $url->getFullUrl();
            } else {
                $url = $url->getUrl();
            }
            if ($urlConfiguration['product']['prefix'] != '') {
                $url = rtrim($urlConfiguration['product']['prefix'], '/') . '/' . $url;
            }

            return $url;
        } else {
            return $url->getFullUrl();
        }

    }

    protected function getCategoryUrl($id) {
        $res = $this->db->select(
            [
             'url',
             'parent_id',
            ]
        )->where('id', $id)->get('category');
        if ($res = $res->row_array()) {
            $parent_url = $this->getCategoryUrl($res['parent_id']);

            return ($parent_url ? $parent_url . '/' : '') . $res['url'];
        }
    }

}

1		<?php
2		use core\models\Route;
3		use core\models\RouteQuery;
4		use core\src\CoreFactory;
5
6		/**
7		* Class Attendance_model for mod_stats module
8		*
9		* @uses \CI_Model
10		* @author DevImageCms
11		* @copyright (c) 2014, ImageCMS
12		* @property CI_DB_active_record $db
13		* @package ImageCMSModule
14		*/
15		class Custom_model extends CI_Model
		0 ignored issues – show Coding Style Compatibility introduced 2017-03-21 09:28 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2017-03-21 09:28 UTC by Report Bug Copy Issue Report This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider becomes `DatabaseProvider`. Loading history...
16		{
17
18		/**
19		*
20		* @return int
21		*/
22		public function getAllTimeCountUnique() {
23		$query
24		= '
		0 ignored issues – show introduced 2017-03-23 15:00 UTC by Report Bug Copy Issue Report Multi-line assignment not indented correctly; expected 10 spaces but found 12 Loading history...
25		SELECT
26		COUNT(DISTINCT `id_user`) AS `count`
27		FROM
28		`mod_stats_attendance`
29		';
30
31		return $this->db->query($query)->row()->count;
32		}
33
34		/**
35		*
36		* @return int
37		*/
38		public function getAllTimeCountUniqueRobots() {
39		$query
40		= '
		0 ignored issues – show introduced 2017-03-23 15:00 UTC by Report Bug Copy Issue Report Multi-line assignment not indented correctly; expected 10 spaces but found 12 Loading history...
41		SELECT
42		COUNT(DISTINCT `id_robot`) AS `count`
43		FROM
44		`mod_stats_attendance_robots`
45		';
46
47		return $this->db->query($query)->row()->count;
48		}
49
50		/**
51		*
52		* @return int
53		*/
54	View Code Duplication	public function getLastViewedPage() {
55		$locale = MY_Controller::getCurrentLocale();
56
57		$query
58		= "
		0 ignored issues – show introduced 2017-03-23 15:00 UTC by Report Bug Copy Issue Report Multi-line assignment not indented correctly; expected 10 spaces but found 16 Loading history... Coding Style introduced 2017-03-23 15:00 UTC by Report Bug Copy Issue Report Multi-line assignment not indented correctly; expected 12 spaces but found 16 Loading history...
59		SELECT
60		`users`.`username`,
61		`type_id`,
62		`route`.`type`,
63		`id_entity`,
64		(CASE `mod_stats_attendance`.`type_id`
65		WHEN 1 THEN `content`.`title`
66		WHEN 2 THEN `category`.`name`
67		WHEN 3 THEN `shop_category_i18n`.`name`
68		WHEN 4 THEN `shop_products_i18n`.`name`
69		END) AS `page_name`
70		FROM
71		`mod_stats_attendance`
72		LEFT JOIN
73		route
74		ON
75		route.entity_id = mod_stats_attendance.id_entity
76		LEFT JOIN
77		`content`
78		ON
79		`content`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 1
80		LEFT JOIN
81		`category`
82		ON
83		`category`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 2
84		LEFT JOIN
85		`shop_category`
86		ON
87		`shop_category`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 3
88		LEFT JOIN
89		`shop_products`
90		ON
91		`shop_products`.`id` = `mod_stats_attendance`.`id_entity` AND `mod_stats_attendance`.`type_id` = 4
92		LEFT JOIN
93		`shop_category_i18n`
94		ON
95		`shop_category`.`id` = `shop_category_i18n`.`id` AND `shop_category_i18n`.`locale` = '{$locale}'
96		LEFT JOIN
97		`shop_products_i18n`
98		ON
99		`shop_products`.`id` = `shop_products_i18n`.`id` AND `shop_products_i18n`.`locale` = '{$locale}'
100		LEFT JOIN
101		`users`
102		ON
103		`users`.`id` = `mod_stats_attendance`.`id_user`
104		ORDER BY
105		`mod_stats_attendance`.`time_add`
106		DESC
107		LIMIT 1
108		";
109		$result = $this->db->query($query);
110		if ($result) {
111		$result = $result->row_array();
112		if ($result['type_id'] == Attendance::PAGE) {
113		$result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_PAGE);
114		} elseif ($result['type_id'] == Attendance::CATEGORY) {
115		$result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_CATEGORY);
116		} elseif ($result['type_id'] == Attendance::SHOP_CATEGORY) {
117		$result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_SHOP_CATEGORY);
118		} elseif ($result['type_id'] == Attendance::PRODUCT) {
119		$result['url'] = $this->getUrl($result['id_entity'], Route::TYPE_PRODUCT);
120		}
121
122		return $result;
123		}
124
125		return false;
126		}
127
128	View Code Duplication	protected function getUrl($id, $type) {
129		$urlConfiguration = CoreFactory::getConfiguration()->getUrlRules();
130		$url = RouteQuery::create()->filterByEntityId($id)->filterByType($type)->findOneOrCreate();
131		if ($type == Route::TYPE_SHOP_CATEGORY) {
132		if ($urlConfiguration['shop_category']['parent'] === '1') {
133		$url = $url->getFullUrl();
134		} else {
135		$url = $url->getUrl();
136		}
137		if ($urlConfiguration['shop_category']['prefix'] != '') {
138		$url = rtrim($urlConfiguration['shop_category']['prefix'], '/') . '/' . $url;
139		}
140
141		return $url;
142		} elseif ($type == Route::TYPE_PRODUCT) {
143		if ($urlConfiguration['product']['parent'] === '1') {
144		$url = $url->getFullUrl();
145		} else {
146		$url = $url->getUrl();
147		}
148		if ($urlConfiguration['product']['prefix'] != '') {
149		$url = rtrim($urlConfiguration['product']['prefix'], '/') . '/' . $url;
150		}
151
152		return $url;
153		} else {
154		return $url->getFullUrl();
155		}
156
157		}
158
159		protected function getCategoryUrl($id) {
160		$res = $this->db->select(
161		[
162		'url',
163		'parent_id',
164		]
165		)->where('id', $id)->get('category');
166		if ($res = $res->row_array()) {
167		$parent_url = $this->getCategoryUrl($res['parent_id']);
168
169		return ($parent_url ? $parent_url . '/' : '') . $res['url'];
170		}
171		}
172
173		}

imagecms / ImageCMS

Push — development ( cfd391...deed4d )

Custom_model::getLastViewedPage() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like