core\src\Router

Complexity

Total Complexity

23

Size/Duplication

Total Lines	109
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setModules()	0	3	1
A	findRoute()	0	17	4
B	checkUrl()	0	15	5
A	isMainPage()	0	8	2
A	isRoute()	0	10	3
A	checkRoute()	0	8	2
B	isModule()	0	21	6

<?php

namespace core\src;

use core\models\Route;
use core\models\RouteQuery;
use core\src\Exception\PageNotFoundException;

/**
 * Class Router
 *
 * @package core\src
 * @todo    remove PageException and url check
 */
class Router
{

    private $modules = [];

    private $deniedSegments
                     = [

Multi-line assignment not indented correctly; expected 6 spaces but found 21

Multi-line assignment not indented correctly; expected 8 spaces but found 21

                        '_install',
                        '_deinstall',
                        '_install_rules',
                        'autoload',
                        '__construct',
                       ];

    public function setModules(array $modules) {
        $this->modules = $modules;
    }

    public function findRoute($url) {
        $this->checkUrl($url);
        $url = trim($url, '/');

        if ($route = $this->isMainPage($url)) {
            return $route;
        }

        if ($route = $this->isModule($url)) {
            return $route;
        }

        if ($route = $this->isRoute($url)) {
            return $route;
        }

    }

    private function checkUrl($url) {
        if (strpos($url, '//') !== false) {
            throw new PageNotFoundException();
        }

        if (count(explode('/_', $url)) > 1) {
            throw  new PageNotFoundException();
        }

        foreach ($this->segments as $segment) {

The property segments does not seem to exist. Did you mean deniedSegments?

            if (in_array($segment, $this->deniedSegments) == true) {
                throw new PageNotFoundException();
            }
        }
    }

    private function isMainPage($url) {
        if ($url == '') {
            $route = new Route();
            $route->setType(Route::TYPE_MAIN);

            return $route;
        }
    }

    private function isRoute($url) {
        $routeUrl = explode('/', $url);
        $last     = array_pop($routeUrl);

        $route = RouteQuery::create()->filterByUrl($last)->findOne();

        if ($route && $this->checkRoute($route, $url)) {
            return $route;
        }
    }

    private function checkRoute(Route $route, $url) {
        if ($route->getRouteUrl() !== $url) {
            throw new PageNotFoundException();
        }

        return true;

    }

    /**
     * @param $url

Missing parameter type

     *
     * @return bool|Route

Should the return type not be false|Route|null?

     */
    private function isModule($url) {
        if (strpos(trim($url, '/'), 'shop/category') === 0) {
            return false;
        }
        if (strpos(trim($url, '/'), 'shop/product') === 0) {
            return false;
        }
        $moduleSegments = explode('/', $url);
        $moduleName     = array_shift($moduleSegments);

        foreach ($this->modules as $module) {
            if ($module['identif'] === $moduleName AND $module['enabled'] == 1) {

As per coding-style, PHP keywords should be in lowercase; expected and, but found AND.

                $route = new Route();
                $route->setType(Route::TYPE_MODULE);
                $route->setUrl($url);

                return $route;
            }
        }
    }

}