discount_api - Code Metrics - Inspection of "4.12.1" - imagecms/ImageCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( cfd391...deed4d )

by Andrij

created 2017-03-23 14:49 UTC

discount_api C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	384
Duplicated Lines	4.17 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	16
loc	384
rs	6.3005
c	0
b	0
f	0
wmc	58
lcom	1
cbo	5

21 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	isGiftCertificat()	0	9	3
B	getGiftCertificate()	0	20	6
C	getDiscount()	16	30	7
A	getDiscountProduct()	0	14	4
C	getUserDiscount()	0	23	7
A	discountsExists()	0	6	4
A	userDiscountExists()	0	3	1
A	groupDiscountExists()	0	3	1
A	getComulativDiscount()	0	10	2
B	getDiscountBy()	0	22	6
A	getAllDiscount()	0	5	1
B	applyProductDiscount()	0	32	5
A	is_gift_certificat()	0	3	1
A	render_gift_input()	0	7	3
A	render_gift_succes()	0	4	1
A	get_user_discount_api()	0	3	1
A	get_discount_product_api()	0	3	1
A	get_discount_tpl_from_json_api()	0	5	1
A	get_discount_api()	0	3	1
A	get_gift_certificate()	0	3	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like discount_api often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use discount_api, and based on these observations, apply Extract Interface, too.

<?php

use Cart\BaseCart;
use CMSFactory\assetManager;
use mod_discount\classes\BaseDiscount;
use mod_discount\classes\DiscountManager;
use mod_discount\Discount_product;

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * Class discount_api for Mod_Discount module
 * @property BaseDiscount baseDiscount
 * @uses \MY_Controller
 * @author DevImageCms
 * @copyright (c) 2013, ImageCMS
 * @package ImageCMSModule
 */
class discount_api extends MY_Controller
namespace YourVendor;

class YourClass { }
{

    /**
     * __construct base object loaded
     * @access public
     * @author DevImageCms
     * @copyright (c) 2013, ImageCMS
     */
    public function __construct() {
        parent::__construct();
        $lang = new MY_Lang();
        $lang->load('mod_discount');
    }

    /**
     * is in project gift certificate
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     */
    public function isGiftCertificat() {
        $this->baseDiscount = BaseDiscount::create();
        foreach ($this->baseDiscount->discountType['certificate'] as $disc) {
            if ($disc['is_gift']) {
                return true;
            }
        }
        return false;
    }

    /**
     * get gift certificate in json format
     * @access public
     * @author DevImageCms
     * @param (string) key optional

     * @param (float) totalPrice optional

     * @return string
     * @copyright (c) 2013, ImageCMS
     */
    public function getGiftCertificate($key = null, $totalPrice = null) {
        $cart = BaseCart::getInstance();
        $this->baseDiscount = BaseDiscount::create();
        if ($totalPrice === null) {
            $totalPrice = $cart->getTotalPrice();
        }

        if (null === $key) {
            $key = strip_tags(trim($this->input->get('key')));
        }

        foreach ($this->baseDiscount->discountType['certificate'] as $disc) {
            if ($disc['key'] == $key and $disc['is_gift']) {
                $value = $this->baseDiscount->getDiscountValue($disc, $totalPrice);
                return json_encode(['key' => $disc['key'], 'val_orig' => $value, 'value' => ShopCore::app()->SCurrencyHelper->convert($value), 'gift_array' => $disc]);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            }
        }
        return json_encode(['error' => true, 'mes' => lang('Invalid code try again', 'mod_discount')]);
    }

    /**
     * get discount in json format
     * @access public
     * @author DevImageCms
     * @param array $option

     * @param array $typeReturn params:

     * - (float) price:

     * - (int) userId:
     * - (bool) ignoreCart: ignore cart Data:
     * - (bool) new: for redeclare singelton:

     * @return json

     * @internal param $ (bool) typeReturn optional
     * @copyright (c) 2013, ImageCMS
     */
    public function getDiscount($option = [], $typeReturn = null) {

        if (count($option) > 0) {
            BaseDiscount::prepareOption($option);
        }

        $this->baseDiscount = BaseDiscount::create();
        if (BaseDiscount::checkModuleInstall()) {
            $discount['max_discount'] = $this->baseDiscount->discountMax;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $discount['sum_discount_product'] = $this->baseDiscount->discountProductVal;
            $discount['sum_discount_no_product'] = $this->baseDiscount->discountNoProductVal;

            if ($this->baseDiscount->discountProductVal > $this->baseDiscount->discountNoProductVal) {

                $discount['result_sum_discount'] = $this->baseDiscount->discountProductVal;
                $discount['type'] = 'product';
            } else {
                $discount['result_sum_discount'] = $this->baseDiscount->discountNoProductVal;

                $discount['type'] = 'user';
            }
            $discount['result_sum_discount_convert'] = ShopCore::app()->SCurrencyHelper->convert($discount['result_sum_discount']);
        }
        if ($discount['result_sum_discount']) {
            if ($this->input->server('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest' && !$typeReturn) {
                echo json_encode($discount);
            } else {
                return $discount;
            }
        } else {
            echo '';
        }
    }

    /**
     * get discount product
     * @access public
     * @author DevImageCms
     * @param float|null $product

     * @param array [pid,vid], (float) price optional

     * @return array
     * @copyright (c) 2013, ImageCMS
     */
    public function getDiscountProduct($product, $price = null) {
        if (BaseDiscount::checkModuleInstall()) {
            $DiscProdObj = Discount_product::create();
            if ($DiscProdObj->getProductDiscount($product, $price)) {
                $arr = assetManager::create()->discount;

                if ($this->input->server('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest') {
                    echo json_encode($arr);
                } else {
                    return $arr;
                }
            }
        }
        return false;
    }

    /**
     * get all discount information without maximized
     * @access public
     * @author DevImageCms
     * @param array $option params:

     * - (float) price:

     * - (int) userId:
     * - (bool) ignoreCart: ignore cart Data:
     * - (bool) new: for redeclare singelton:

     * @return array

     * @copyright (c) 2013, ImageCMS
     */
    public function getUserDiscount($option = []) {
        if (count($option) > 0) {
            BaseDiscount::prepareOption($option);
        }

        $this->baseDiscount = BaseDiscount::create();
        if (BaseDiscount::checkModuleInstall()) {
            $this->baseDiscount->discountType['comulativ'] = $this->getComulativDiscount($option);

            foreach ($this->baseDiscount->discountType['user'] as $user) {
                if ($user['user_id'] == $this->dx_auth->get_user_id()) {
                    $this->baseDiscount->discountType['user'][0] = $user;
                }
            }

            foreach ($this->baseDiscount->discountType['group_user'] as $group) {
                if ($group['group_id'] == $this->dx_auth->get_role_id()) {
                    $this->baseDiscount->discountType['group_user'][0] = $group;
                }
            }
            return $this->baseDiscount->discountType;
        }
    }

    /**
     * If discount for current user exist or nots
     * @return boolean
     */
    public function discountsExists() {
        $ud = $this->userDiscountExists();
        $gd = $this->groupDiscountExists();
        $userDiscount = $this->getUserDiscount();
        return $ud || $gd || (bool) $userDiscount['comulativ'] ? TRUE : FALSE;
    }

    public function userDiscountExists() {
        return (bool) !DiscountManager::validateUserDiscount(CI::$APP->dx_auth->get_user_id());
    }

    public function groupDiscountExists() {
        return (bool) !DiscountManager::validateGroupDiscount(CI::$APP->dx_auth->get_role_id());
    }

    /**
     * get comulativ discount sorting
     * @access private
     * @author DevImageCms
     * @param (float) price optional

     * @param (float) userId optional

     * @param (bool) new optional

     * @return array
     * @copyright (c) 2013, ImageCMS
     */
    private function getComulativDiscount($option) {

        if (count($option) > 0) {
            BaseDiscount::prepareOption($option);
        }

        $this->baseDiscount = BaseDiscount::create();

        return user_function_sort($this->baseDiscount->discountType['comulativ'], 'begin_value');
    }

    /**
     * get one discount
     * @access public
     * @author DevImageCms
     * @param string $key: criteria
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param int $id: id discount
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return string|false
     * @copyright (c) 2013, ImageCMS
     */
    public function getDiscountBy($key, $id) {

        $this->baseDiscount = BaseDiscount::create();
        foreach ($this->baseDiscount->allDiscount as $disc) {
            switch ($key) {
                case 'key':
                    if ($disc['key'] == $id) {
                        return json_encode($disc);
                    }
                    break;

                case 'id':
                    if ($disc['ids'] == $id) {
                        return json_encode($disc);
                    }
                    break;

                default:
                    break;
            }
        }
        return false;
    }

    /**
     * get all active discount
     * @access public
     * @author DevImageCms
     * @param (float) price optional

     * @param (float) userId optional

     * @param (bool) new optional

     * @return string
     * @copyright (c) 2013, ImageCMS
     */
    public function getAllDiscount() {

        $this->baseDiscount = BaseDiscount::create();
        return json_encode($this->baseDiscount->discountType);
    }

    /**
     * apply discount for all products
     * @access public
     * @author DevImageCms
     * @return (int) cnt: count update products
     * @copyright (c) 2013, ImageCMS
     */
    public function applyProductDiscount() {

        $productVariants = $this->db
            ->select('shop_product_variants.id as var_id, shop_product_variants.price as price, shop_products.id as id, shop_products.brand_id as brand_id, shop_products.category_id as category_id')
            ->from('shop_products')
            ->join('shop_product_variants', 'shop_product_variants.product_id = shop_products.id')
            ->get('shop_product_variants')
            ->result_array();
        foreach ($productVariants as $var) {
            $arr_for_discount = [
                                 'product_id'  => $var['id'],
                                 'category_id' => $var['category_id'],
                                 'brand_id'    => $var['brand_id'],
                                 'vid'         => $var['var_id'],
                                 'id'          => $var['id'],
                                ];
            assetManager::create()->discount = 0;

            Discount_product::create()->getProductDiscount($arr_for_discount);

            if ($discount = assetManager::create()->discount) {
                $priceNew = ((float) $var['price'] - (float) $discount['discount_value'] < 0) ? 1 : (float) $var['price'] - (float) $discount['discount_value'];
                $dataProductUpdate = [
                                      'price'         => ($discount) ? $priceNew : $var['price'],
                                      'price_no_disc' => $var['price'],
                                      'disc'          => $discount['discount_value'],
                                     ];
                $this->db->where('id', $var['var_id'])->update('shop_product_variants', $dataProductUpdate);
                $cnt++;
            }
        }
        return $cnt;
    }

    /**
     * is in project gift certificate
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     */
    public function is_gift_certificat() {
        return $this->isGiftCertificat();

    }

    /**
     * render gift input
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     */
    public function render_gift_input($mes = null) {
        if (BaseDiscount::checkModuleInstall()) {
            if ($this->is_gift_certificat()) {

                assetManager::create()->setData(['mes' => $mes])->render('gift', true);
            }
        }
    }

    /**
     * get gift certificate in tpl
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     */
    public function render_gift_succes() {
        $json = json_decode($this->input->get('json'));
        assetManager::create()->setData(['gift' => $json])->render('gift_succes', true);
    }

    /**
     * get all discount information without maximized
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     * @param array $option

     * @return array

     */
    public function get_user_discount_api($option = []) {
        return $this->getUserDiscount($option);
    }

    /**
     * get discount product
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     * @param $product

     * @param null $typeReturn
     * @param null $price
     * @return array
     */
    public function get_discount_product_api($product, $typeReturn = null, $price = null) {
        return $this->getDiscountProduct($product, $typeReturn = null, $price = null);
    }

    /**
     * get discount in tpl format from json
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     */
    public function get_discount_tpl_from_json_api() {
        $json = json_decode($this->input->get('json'));

        assetManager::create()->setData(['discount' => $json])->render('discount_order', true);
    }

    /**
     * get discount in json format
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     * @param array $option

     * @return json

     */
    public function get_discount_api($option = []) {
        return $this->getDiscount($option);
    }

    /**
     * get gift certificate in json format
     * @deprecated since version 4.5.2
     * @copyright (c) 2013, ImageCMS
     * @param null|string $key

     * @param null|string $totalPrice
     * @return string
     */
    public function get_gift_certificate($key = null, $totalPrice = null) {
        return $this->getGiftCertificate($key = null, $totalPrice = null);
    }

}

1			<?php
2
3			use Cart\BaseCart;
4			use CMSFactory\assetManager;
5			use mod_discount\classes\BaseDiscount;
6			use mod_discount\classes\DiscountManager;
7			use mod_discount\Discount_product;
8
9			if (!defined('BASEPATH')) {
10			exit('No direct script access allowed');
11			}
12
13			/**
14			* Class discount_api for Mod_Discount module
15			* @property BaseDiscount baseDiscount
16			* @uses \MY_Controller
17			* @author DevImageCms
18			* @copyright (c) 2013, ImageCMS
19			* @package ImageCMSModule
20			*/
21			class discount_api extends MY_Controller
			0 ignored issues – show introduced 2015-11-28 17:40 UTC by Report Bug Copy Issue Report Class name must begin with a capital letter Loading history... Coding Style Compatibility introduced 2017-03-21 09:28 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2017-03-21 09:28 UTC by Report Bug Copy Issue Report This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider becomes `DatabaseProvider`. Loading history...
22			{
23
24			/**
25			* __construct base object loaded
26			* @access public
27			* @author DevImageCms
28			* @copyright (c) 2013, ImageCMS
29			*/
30			public function __construct() {
31			parent::__construct();
32			$lang = new MY_Lang();
33			$lang->load('mod_discount');
34			}
35
36			/**
37			* is in project gift certificate
38			* @deprecated since version 4.5.2
39			* @copyright (c) 2013, ImageCMS

imagecms / ImageCMS