Feedback

Complexity

Total Complexity

13

Size/Duplication

Total Lines	116
Duplicated Lines	11.21 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	5
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	autoload()	0	3	1
A	captcha_check()	0	7	2
A	recaptcha_check()	8	8	2
B	index()	5	45	4
A	load_settings()	0	15	3

<?php

use cmsemail\email;

if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * Image CMS
 *
 * Feedback module
 */
class Feedback extends MY_Controller
{

Opening brace of a class must be on the same line as the definition

    public $username_max_len = 30;

    public $message_max_len = 600;

    public $theme_max_len = 150;

    public $admin_mail = 'admin@localhost';

    public $message = '';

    protected $formErrors = [];

    public function __construct() {
        parent::__construct();
        $this->load->module('core');
        $this->load_settings();

        $this->formErrors = [
                             'required'    => lang('Field is required'),
                             'min_length'  => lang('Length is less than the minimum'),
                             'valid_email' => lang('Email is not valid'),
                             'max_length'  => lang('Length greater than the maximum'),
                            ];
        $lang = new MY_Lang();
        $lang->load('feedback');
    }

    public function autoload() {

    }

    public function captcha_check($code) {
        if (!$this->dx_auth->captcha_check($code)) {

The if-else statement can be simplified to return (bool) $this->dx_auth->captcha_check($code);.

            return FALSE;
        } else {
            return TRUE;
        }
    }

    public function recaptcha_check() {
        $result = $this->dx_auth->is_recaptcha_match();
        if (!$result) {
            $this->form_validation->set_message('recaptcha_check', lang('Improper protection code', 'feedback'));
        }

        return $result;
    }

    // Index function

    public function index() {
        $this->template->registerMeta('ROBOTS', 'NOINDEX, NOFOLLOW');

        $this->core->set_meta_tags(lang('Feedback', 'feedback'));

        $this->load->library('form_validation');

        // Create captcha
        $this->dx_auth->captcha();
        $tpl_data['cap_image'] = $this->dx_auth->get_captcha_image();

$tpl_data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $tpl_data = array(); before regardless.

        $this->template->add_array($tpl_data);

        if (count($this->input->post()) > 0) {
            $this->form_validation->set_rules('name', lang('Your name', 'feedback'), 'trim|required|min_length[3]|max_length[' . $this->username_max_len . ']|xss_clean');
            $this->form_validation->set_rules('email', lang('Email', 'feedback'), 'trim|required|valid_email|xss_clean');
            $this->form_validation->set_rules('theme', lang('Subject', 'feedback'), 'trim|max_length[' . $this->theme_max_len . ']|xss_clean');
            $this->form_validation->set_rules('message', lang('Message', 'feedback'), 'trim|required|max_length[' . $this->message_max_len . ']|xss_clean');

            if ($this->dx_auth->use_recaptcha) {
                $this->form_validation->set_rules('recaptcha_response_field', lang('Protection code', 'feedback'), 'trim|xss_clean|required|callback_recaptcha_check');
            } else {
                $this->form_validation->set_rules('captcha', lang('Protection code', 'feedback'), 'trim|required|xss_clean|callback_captcha_check');
            }

            if ($this->form_validation->run($this) == FALSE) { // there are errors

There should be no white space after an opening "{"

                $this->form_validation->set_error_delimiters('', '');
                CMSFactory\assetManager::create()->setData('validation', $this->form_validation);
                form_error();
            } else { // form is validate

There should be no white space after an opening "{"

                $feedback_variables = [
                                       'Theme'       => $this->input->post('theme'),
                                       'userName'    => $this->input->post('name'),
                                       'userEmail'   => $this->input->post('email'),
                                       'userMessage' => $this->input->post('message'),
                                      ];
                 email::getInstance()->sendEmail($this->input->post('email'), 'feedback', $feedback_variables);
                CMSFactory\assetManager::create()->appendData('message_sent', TRUE);

TRUE is of type boolean, but the function expects a string|integer|double.

            }
        }

        CMSFactory\assetManager::create()->render('feedback');
    }

    private function load_settings() {
        $this->db->limit(1);
        $this->db->where('name', 'feedback');
        $query = $this->db->get('components')->row_array();

        $settings = unserialize($query['settings']);

        if (is_int($settings['message_max_len'])) {
            $this->message_max_len = $settings['message_max_len'];
        }

        if ($settings['email']) {
            $this->admin_mail = $settings['email'];
        }
    }

}

/* End of file sample_module.php */