Issues in re-pro.php (master) - Issues in master - imFORZA/re-pro - Measure and Improve Code Quality continuously with Scrutinizer

Issues (557)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

re-pro.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Real Estate Pro
 *
 * @package re-pro
 */

/*
-------------------------------------------------------------------------------
	Plugin Name: Real Estate Pro
	Plugin URI: https://www.imforza.com
	Description: A WordPress plugin for Real Estate websites, offering tools such as widgets and badges. Built by <a href="https://www.imforza.com">imFORZA</a>.
	Version: 1.0.9
	Author: imFORZA
	Contributors: imforza, bhubbard, sfgarza, matoledo
	Text Domain: re-pro
	Author URI: https://www.imforza.com
	License: GPLv3 or later
	License URI: https://www.gnu.org/licenses/gpl-3.0.en.html
------------------------------------------------------------------------------
*/

/* Exit if accessed directly. */
if ( ! defined( 'ABSPATH' ) ) { exit; }

/** Instantiate the plugin. */
new RePro();
require_once( 'settings.php' );


/**
 * RePro class.
 */
class RePro {

	/**
	 * Constructor.
	 *
	 * @access public
	 * @return void
	 */
	public function __construct() {
		/* Define Constants */
		define( 'REPRO_BASE_NAME', plugin_basename( __FILE__ ) );
		define( 'REPRO_BASE_DIR', plugin_dir_path( __FILE__ ) );
		define( 'REPRO_PLUGIN_FILE', REPRO_BASE_DIR . 're-pro.php' );

		/* Include dependencies */
		require_once( 'includes.php' );

		$this->init();
	}


	/**
	 * Init.
	 *
	 * @access private
	 * @return void
	 */
	private function init() {
		$this->general_settings = get_option( 're_pro_settings' );
class MyClass { }

$x = new MyClass();
$x->foo = true;

		/* Language Support. */
		load_plugin_textdomain( 're-pro', false, dirname( REPRO_BASE_NAME ) . '/languages' );

		/* Plugin Activation/De-Activation. */
		register_activation_hook( REPRO_PLUGIN_FILE, array( $this, 'activate' ) );
		register_deactivation_hook( REPRO_PLUGIN_FILE, array( $this, 'deactivate' ) );

		/* Set menu page. */
		add_action( 'admin_menu', array( $this, 'admin_menu' ) );

		/** Enqueue css and js files. */
		add_action( 'admin_enqueue_scripts', array( $this, 'admin_scripts' ) );
		add_action( 'wp_enqueue_scripts', 	 array( $this, 'widget_styles' ) );

		/* Add link to settings in plugins admin page. */
		add_filter( 'plugin_action_links_' . REPRO_BASE_NAME , array( $this, 'plugin_links' ) );

		add_filter( 'wpapi_google_map_data', array( $this, 'gmap_style' ), 1 );

		$this->init_modules();
	}

	private function init_modules() {
		$gmaps_key = isset( $this->general_settings['gmaps_key'] ) ? $this->general_settings['gmaps_key'] : null;

		if ( isset( $this->general_settings['gmaps_active'] ) && isset( $gmaps_key ) ) {
			new WPAPI_GOOGLE_MAPS( $gmaps_key );
		}
	}

	public function gmap_style( $map_data ) {
		// Grab style option.
		$map_json = ( isset( $this->general_settings['gmaps_style'] ) ) ? $this->general_settings['gmaps_style'] : '[]';

		// Validate JSON.
		json_decode( $map_json );
		$json_valid = json_last_error();

		// Set style to map_data.
		$map_data['style'] = ( $json_valid === JSON_ERROR_NONE ) ? $map_json : '[]';

		return $map_data;
	}

	/**
	 * Method that runs on admin_menu hook.
	 */
	public function admin_menu() {

	}

	/**
	 * Enqueue CSS.
	 */
	public function admin_scripts() {
		if ( ! is_admin() ) {
			wp_register_style( 're-pro', plugins_url( 'assets/css/re-pro-min.css', REPRO_PLUGIN_FILE ) );
			// wp_enqueue_style( 're-pro' );
		}
	}

	/**
	 * Register Widget CSS.
	 */
	public function widget_styles() {
		wp_register_style( 're-pro-widgets', plugins_url( 'assets/css/re-pro-widgets.min.css', REPRO_PLUGIN_FILE ) );
		wp_enqueue_style( 're-pro-widgets' );
	}

	/**
	 * Method that executes on plugin activation.
	 */
	public function activate() {
		flush_rewrite_rules();
	}

	/**
	 * Method that executes on plugin de-activation.
	 */
	public function deactivate() {
		flush_rewrite_rules();
	}

	/**
	 * Add Tools link on plugin page.
	 *
	 * @param  [Array] $links : Array of links on plugin page.
	 * @return [Array]        : Array of links on plugin page.
	 */
	public function plugin_links( $links ) {
		$settings_link = '<a href="options-general.php?page=re-pro-settings">Settings</a>';
		array_unshift( $links, $settings_link );
		return $links;
	}
}


1			<?php
2			/**
3			* Real Estate Pro
4			*
5			* @package re-pro
6			*/
7
8			/*
9			-------------------------------------------------------------------------------
10			Plugin Name: Real Estate Pro
11			Plugin URI: https://www.imforza.com
12			Description: A WordPress plugin for Real Estate websites, offering tools such as widgets and badges. Built by <a href="https://www.imforza.com">imFORZA</a>.
13			Version: 1.0.9
14			Author: imFORZA
15			Contributors: imforza, bhubbard, sfgarza, matoledo
16			Text Domain: re-pro
17			Author URI: https://www.imforza.com
18			License: GPLv3 or later
19			License URI: https://www.gnu.org/licenses/gpl-3.0.en.html
20			------------------------------------------------------------------------------
21			*/
22
23			/* Exit if accessed directly. */
24			if ( ! defined( 'ABSPATH' ) ) { exit; }
25
26			/** Instantiate the plugin. */
27			new RePro();
28			require_once( 'settings.php' );
29
30
31			/**
32			* RePro class.
33			*/
34			class RePro {
35
36			/**
37			* Constructor.
38			*
39			* @access public
40			* @return void
41			*/
42			public function __construct() {
43			/* Define Constants */
44			define( 'REPRO_BASE_NAME', plugin_basename( __FILE__ ) );
45			define( 'REPRO_BASE_DIR', plugin_dir_path( __FILE__ ) );
46			define( 'REPRO_PLUGIN_FILE', REPRO_BASE_DIR . 're-pro.php' );
47
48			/* Include dependencies */
49			require_once( 'includes.php' );
50
51			$this->init();
52			}
53
54
55			/**
56			* Init.
57			*
58			* @access private
59			* @return void
60			*/
61			private function init() {
62			$this->general_settings = get_option( 're_pro_settings' );
			0 ignored issues – show Bug introduced 2017-02-17 02:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `general_settings` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63
64			/* Language Support. */
65			load_plugin_textdomain( 're-pro', false, dirname( REPRO_BASE_NAME ) . '/languages' );
66
67			/* Plugin Activation/De-Activation. */
68			register_activation_hook( REPRO_PLUGIN_FILE, array( $this, 'activate' ) );
69			register_deactivation_hook( REPRO_PLUGIN_FILE, array( $this, 'deactivate' ) );
70
71			/* Set menu page. */
72			add_action( 'admin_menu', array( $this, 'admin_menu' ) );
73
74			/** Enqueue css and js files. */
75			add_action( 'admin_enqueue_scripts', array( $this, 'admin_scripts' ) );
76			add_action( 'wp_enqueue_scripts', array( $this, 'widget_styles' ) );
77
78			/* Add link to settings in plugins admin page. */
79			add_filter( 'plugin_action_links_' . REPRO_BASE_NAME , array( $this, 'plugin_links' ) );
80
81			add_filter( 'wpapi_google_map_data', array( $this, 'gmap_style' ), 1 );
82
83			$this->init_modules();
84			}
85
86			private function init_modules() {
87			$gmaps_key = isset( $this->general_settings['gmaps_key'] ) ? $this->general_settings['gmaps_key'] : null;
88
89			if ( isset( $this->general_settings['gmaps_active'] ) && isset( $gmaps_key ) ) {
90			new WPAPI_GOOGLE_MAPS( $gmaps_key );
91			}
92			}
93
94			public function gmap_style( $map_data ) {
95			// Grab style option.
96			$map_json = ( isset( $this->general_settings['gmaps_style'] ) ) ? $this->general_settings['gmaps_style'] : '[]';
97
98			// Validate JSON.
99			json_decode( $map_json );
100			$json_valid = json_last_error();
101
102			// Set style to map_data.
103			$map_data['style'] = ( $json_valid === JSON_ERROR_NONE ) ? $map_json : '[]';
104
105			return $map_data;
106			}
107
108			/**
109			* Method that runs on admin_menu hook.
110			*/
111			public function admin_menu() {
112
113			}
114
115			/**
116			* Enqueue CSS.
117			*/
118			public function admin_scripts() {
119			if ( ! is_admin() ) {
120			wp_register_style( 're-pro', plugins_url( 'assets/css/re-pro-min.css', REPRO_PLUGIN_FILE ) );
121			// wp_enqueue_style( 're-pro' );
122			}
123			}
124
125			/**
126			* Register Widget CSS.
127			*/
128			public function widget_styles() {
129			wp_register_style( 're-pro-widgets', plugins_url( 'assets/css/re-pro-widgets.min.css', REPRO_PLUGIN_FILE ) );
130			wp_enqueue_style( 're-pro-widgets' );
131			}
132
133			/**
134			* Method that executes on plugin activation.
135			*/
136			public function activate() {
137			flush_rewrite_rules();
138			}
139
140			/**
141			* Method that executes on plugin de-activation.
142			*/
143			public function deactivate() {
144			flush_rewrite_rules();
145			}
146
147			/**
148			* Add Tools link on plugin page.
149			*
150			* @param [Array] $links : Array of links on plugin page.
151			* @return [Array] : Array of links on plugin page.
152			*/
153			public function plugin_links( $links ) {
154			$settings_link = '<a href="options-general.php?page=re-pro-settings">Settings</a>';
155			array_unshift( $links, $settings_link );
156			return $links;
157			}
158			}
159

imFORZA / re-pro

Issues (557)

Security Analysis no request data

re-pro.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like