TruliaRssListingWidget

Complexity

Total Complexity

8

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	class-listing-rss-widget.php ➔ trulia_force_feed()	0	5	1
A	__construct()	0	12	1
A	widget()	0	49	3
A	update()	0	8	2
A	form()	0	20	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 4.

/* Exit if accessed directly. */
if ( ! defined( 'ABSPATH' ) ) { exit; }

/**
 * Trulia Feed Widget
 *
 * @package RE-PRO
 */

/**
 * TruliaRssListingWidget class.
 *
 * @extends WP_Widget
 */
class TruliaRssListingWidget extends WP_Widget {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	/**
	 * __construct function.
	 *
	 * @access public
	 * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

	 */
	public function __construct() {

		parent::__construct(
			'trulia_rss_listing_widget',
			__( 'Trulia Listings RSS', 're-pro' ),
			array(
				'description' => __( 'Display listings from Trulia via a RSS Feed.', 're-pro' ),
				'classname'   => 're-pro re-pro-widget trulia-widget trulia-rss-listings-widget',
				'customize_selective_refresh' => true,
			)
		);
	}

	/**
	 * Widget function.
	 *
	 * @access public
	 * @param mixed $args Arguments.
	 * @param mixed $instance Instance.
	 * @return void
	 */
	public function widget( $args, $instance ) {

		$iframe_id = ! empty( $args['widget_id'] ) ? $args['widget_id'] : '';

$iframe_id is not used, you could remove the assignment.

		$title = ! empty( $instance['title'] ) ? $instance['title'] : '';


		echo $args['before_widget'];

		echo $args['before_title'] . esc_attr( $title ) . $args['after_title'];


		$rss =  fetch_feed( get_trulia_rss_listing_feed( 'for_sale', 'Sacramento', 'CA' ) );

		/* Sometimes the feed has errors so we must use SimplePie ForceFeed. */
		add_action('wp_feed_options', 'trulia_force_feed' , 10, 1);
		function trulia_force_feed($rss) {

It is generally recommended to explicitly declare the visibility for methods.

				$rss->force_feed(true);

		}

		// echo get_trulia_rss_listing_feed( 'for_sale', 'Sacramento', 'CA');

60% of this comment could be valid code. Did you maybe forget this after debugging?

		if( ! is_wp_error( $rss ) ) {

			$max_items = $rss->get_item_quantity(3);

$max_items is not used, you could remove the assignment.

			$rss_items = $rss->get_items(0,3);

			// echo $rss->get_title();

67% of this comment could be valid code. Did you maybe forget this after debugging?

			// echo $rss->get_description();

67% of this comment could be valid code. Did you maybe forget this after debugging?

			foreach( $rss_items as $item ) {

				echo '<div style="margin:20px 0;">';
				echo '<h4><a href="'. $item->get_link() .'" rel="nofollow" target="_blank">' . $item->get_title() . '</a></h4>';
				echo '</div>';

				echo $item->get_content();

				echo '<div style="margin:20px 0;text-align:right;">';
				echo '<small> Updated on '.$item->get_date('F j, Y') . '.</small>';
				echo '</div>';
			}

		} else {
			echo $rss->get_error_message();
		}

		echo $args['after_widget'];
	}

	/**
	 * Form function.
	 *
	 * @access public
	 * @param mixed $instance Instance.
	 * @return void
	 */
	public function form( $instance ) {

		// Set default values.
		$instance = wp_parse_args( (array) $instance, array(
			'title' => '',

		));

		// Retrieve an existing value from the database.
		$title = ! empty( $instance['title'] ) ? $instance['title'] : '';


		// Title.
		echo '<p>';
		echo '	<label for="' . $this->get_field_id( 'title' ) . '" class="title-label">' . __( 'Tile:', 're-pro' ) . '</label>';
		echo '	<input id="' . $this->get_field_id( 'title' ) . '" name="' . $this->get_field_name( 'title' ) . '" value="' . $title  . '" class="widefat">';
		echo '</p>';


	}

	/**
	 * Update.
	 *
	 * @access public
	 * @param mixed $new_instance New Instance.
	 * @param mixed $old_instance Old Instance.
	 * @return $instance

The doc-type $instance could not be parsed: Unknown type name "$instance" at position 0. (view supported doc-types)

	 */
	public function update( $new_instance, $old_instance ) {

		$instance = $old_instance;

		$instance['title'] = ! empty( $new_instance['title'] ) ? strip_tags( $new_instance['title'] ) : '';

		return $instance;
	}
}

/**
 * Register Widget.
 *
 * @access public
 * @return void
 */
function repro_trulia_rsslisting_widget() {

	register_widget( 'TruliaRssListingWidget' );
}
add_action( 'widgets_init', 'repro_trulia_rsslisting_widget' );