Ikechukwukalu\Sanctumauthstarter\Rules\DisallowOldPassword

Complexity

Total Complexity

10

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	message()	0	3	1
A	__construct()	0	11	3
A	getOldPasswords()	0	12	2
A	passes()	0	15	4

<?php

namespace Ikechukwukalu\Sanctumauthstarter\Rules;

use Ikechukwukalu\Sanctumauthstarter\Models\OldPassword;
use Illuminate\Contracts\Validation\Rule;
use Illuminate\Database\Eloquent\Collection as EloquentCollection;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;

class DisallowOldPassword implements Rule

The interface Illuminate\Contracts\Validation\Rule has been deprecated: see ValidationRule

{
    /**
     * Create a new rule instance.
     *
     * @return void
     */

    private int|bool $checkAll;
    private int $number;
    private $user;

    public function __construct($checkAll = true, $number = 4)
    {
        //
        $this->checkAll = $checkAll;
        $this->number = $number;

        if (is_int($this->checkAll) && !empty($this->checkAll)) {
            $this->number = $checkAll;
        }

        $this->user = Auth::user();
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        $oldpasswords = $this->getOldPasswords();

        if ($oldpasswords->count() === 0) {
            return !Hash::check($value, $this->user->password);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        foreach ($oldpasswords as $oldpassword) {
            if (Hash::check($value, $oldpassword->password)) {
                return false;
            }
        }

        return true;
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return trans_choice('sanctumauthstarter::passwords.exists', intval(is_int($this->checkAll)), ['number' => $this->number]);
    }

    /**
     * Get OldPin Model.
     *
     * @return \Illuminate\Database\Eloquent\Collection
     */
    private function getOldPasswords(): EloquentCollection
    {
        if ($this->checkAll === true) {
            return OldPassword::where('user_id', $this->user->id)

The expression return Ikechukwukalu\Sanctumauthstarter\Models\OldPassword::where('user_id', $this->user->id)->orderBy('created_at', 'desc')->get() could return the type Illuminate\Database\Eloquent\Relations\HasManyThrough|Illuminate\Database\Eloquent\Relations\HasOneThrough which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Collection. Consider adding an additional type-check to rule them out.

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    ->orderBy('created_at', 'desc')
                    ->get();
        }

        return OldPassword::where('user_id', $this->user->id)

The expression return Ikechukwukalu\Sanctumauthstarter\Models\OldPassword::where('user_id', $this->user->id)->orderBy('created_at', 'desc')->take($this->number)->get() could return the type Illuminate\Database\Eloquent\Relations\HasManyThrough|Illuminate\Database\Eloquent\Relations\HasOneThrough which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Collection. Consider adding an additional type-check to rule them out.

                ->orderBy('created_at', 'desc')
                ->take($this->number)
                ->get();
    }
}