ikechukwukalu / requirepin

src/Rules/CurrentPin.php

<?php

namespace Ikechukwukalu\Requirepin\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;

class CurrentPin implements Rule
{

    private bool $defaultPin = false;
    private bool $allowDefaultPin = false;
    /**
     * Create a new rule instance.
     *
     * @return void
     */
    public function __construct(bool $allowDefaultPin = false)
    {
        //
        $this->allowDefaultPin = $allowDefaultPin;
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        if (Auth::guard(config('requirepin.auth_guard', 'web'))->user()->default_pin && !$this->allowDefaultPin) {

Accessing default_pin on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->defaultPin = true;

            return false;
        }

        return Hash::check($value, Auth::guard(config('requirepin.auth_guard', 'web'))->user()->pin);

Accessing pin on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        if ($this->defaultPin) {
            return trans('requirepin::pin.default');

The expression return trans('requirepin::pin.default') also could return the type Illuminate\Contracts\Translation\Translator|array which is incompatible with the documented return type string.

        }

        return trans('requirepin::pin.wrong');

The expression return trans('requirepin::pin.wrong') also could return the type Illuminate\Contracts\Translation\Translator|array which is incompatible with the documented return type string.

    }
}