ikechukwukalu / dynamicdatabaseconfig

src/Console/Commands/EnvDatabaseConfigSeedCommand.php

<?php

namespace Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands;

use Illuminate\Console\Command;
use Ikechukwukalu\Dynamicdatabaseconfig\Trait\DatabaseConfig;

class EnvDatabaseConfigSeedCommand extends Command
{
    use DatabaseConfig;

The trait Ikechukwukalu\Dynamicdatabaseconfig\Trait\DatabaseConfig requires some properties which are not provided by Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand: $database, $configuration

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'env:seed
                            {database : The type of database}
                            {name : The name of the new database connection}
                            {postfix : The postfix for the database configuration}
                            {--seed : Running seeders}
                            {--seeder= : Running a single seeder class}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Seeding into databases from env';

    /**
     * Execute the console command.
     */
    public function handle(): void
    {
        $database = $this->argument('database');
        $name = $this->argument('name');
        $postFix = $this->argument('postfix');

        $this->components->info("Running seeder(s) for {$name}");

The property components does not exist on Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand. Did you maybe forget to declare it?

        $newConfig = $this->setNewEnvConfig($database, $postFix);

It seems like $postFix can also be of type array and null; however, parameter $postFix of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::setNewEnvConfig() does only seem to accept string, maybe add an additional type check?

It seems like $database can also be of type array and null; however, parameter $database of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::setNewEnvConfig() does only seem to accept string, maybe add an additional type check?

        $this->addNewConfig($database, $name, $newConfig);

It seems like $database can also be of type array and null; however, parameter $database of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::addNewConfig() does only seem to accept string, maybe add an additional type check?

It seems like $name can also be of type array and null; however, parameter $name of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::addNewConfig() does only seem to accept string, maybe add an additional type check?

        $this->createDatabase($database, $newConfig['database']);

It seems like $database can also be of type array and null; however, parameter $database of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::createDatabase() does only seem to accept string, maybe add an additional type check?

        $this->execSeederCommands($name);

It seems like $name can also be of type array and null; however, parameter $name of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\EnvDatabaseConfigSeedCommand::execSeederCommands() does only seem to accept string, maybe add an additional type check?

    }

    private function execSeederCommands(string $name)

The parameter $name is not used and could be removed.

    {

        if ($this->option('seed')) {
            $this->call('db:seed');
            return;
        }

        if ($seeder = $this->option('seeder')) {
            $this->call('db:seed', ['--class' => $seeder]);
        }
    }
}