ikechukwukalu / dynamicdatabaseconfig

src/Console/Commands/DynamicDatabaseConfigSeedCommand.php

<?php

namespace Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands;

use Ikechukwukalu\Dynamicdatabaseconfig\Trait\DatabaseConfig;
use Illuminate\Console\Command;

class DynamicDatabaseConfigSeedCommand extends Command
{
    use DatabaseConfig;

The trait Ikechukwukalu\Dynamicdatabaseconfig\Trait\DatabaseConfig requires some properties which are not provided by Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\DynamicDatabaseConfigSeedCommand: $database, $configuration

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'dynamic:seed
                            {ref : The ref for the database configuration}
                            {--seed : Running seeders}
                            {--seeder= : Running a single seeder class}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Seeding into databases from env';

    /**
     * Execute the console command.
     */
    public function handle(): void
    {
        $ref = $this->argument('ref');

        [$database, $configuration, $name] = $this->getDynamicDatabaseConfiguration($ref);

It seems like $ref can also be of type array and null; however, parameter $ref of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\DynamicDatabaseConfigSeedCommand::getDynamicDatabaseConfiguration() does only seem to accept string, maybe add an additional type check?

        if (!$database) {
            $this->components->error("No database configuration was found");

The property components does not exist on Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\DynamicDatabaseConfigSeedCommand. Did you maybe forget to declare it?

            return;
        }

        $this->components->info("Running seeder(s) for {$name} with ref={$ref}");

        $newConfig = $this->setNewDynamicConfig($database, $configuration);

$configuration of type null|string is incompatible with the type array expected by parameter $configuration of Ikechukwukalu\Dynamicdatabaseconfig\Console\Commands\DynamicDatabaseConfigSeedCommand::setNewDynamicConfig().

        $this->addNewConfig($database, $name, $newConfig);
        $this->createDatabase($database, $configuration['database']);
        $this->execSeederCommands($name);
    }

    private function execSeederCommands(string $name)

The parameter $name is not used and could be removed.

    {
        if ($this->option('seed')) {
            $this->call('db:seed');
            return;
        }

        if ($seeder = $this->option('seeder')) {
            $this->call('db:seed', ['--class' => $seeder]);
        }
    }
}