Ikechukwukalu\Dynamicdatabaseconfig\Middleware\DynamicDatabaseConfig::handle()

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(Request $request, Closure $next, null|string $ref = null)
    {
        if (!$ref) {
            $ref = session(config('dynamicdatabaseconfig.session_ref', '_db_ref'));
        }

        [$database, $configuration, $name] = $this->getDynamicDatabaseConfiguration($ref);

It seems like $ref can also be of type Illuminate\Session\SessionManager and Illuminate\Session\Store; however, parameter $ref of Ikechukwukalu\Dynamicdatabaseconfig\Middleware\DynamicDatabaseConfig::getDynamicDatabaseConfiguration() does only seem to accept string, maybe add an additional type check?

        $request->merge([config('dynamicdatabaseconfig.connection_name', '_db_connection') => $name]);

        if ($database) {
            $newConfig = $this->setNewDynamicConfig($database, $configuration);

$configuration of type null|string is incompatible with the type array expected by parameter $configuration of Ikechukwukalu\Dynamicdatabaseconfig\Middleware\DynamicDatabaseConfig::setNewDynamicConfig().

            $this->addNewConfig($database, $name, $newConfig);
            $this->createDatabase($database, $configuration['database']);
        }

        return $next($request);
    }