ijeffro / laralocker

src/LearningLocker/Visualisations/VisualisationHandler.php

<?php

namespace Ijeffro\Laralocker\LearningLocker\Visualisations;

use Ijeffro\Laralocker\LearningLocker\API\APIHandler;

class VisualisationHandler extends APIHandler implements VisualisationInterface {

    private $visualisation = '/visualisation';
    private $api = '/api';
    private $v1 = '/v1';

The private property $v1 is not used, and could be removed.

    private $v2 = '/v2';

    protected $headers = [
      'content-type' => 'application/json'
    ];

    function __construct($id = null) {
        parent::__construct();
        $this->id = $id;

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Learning Locker: Request Organisation Details
     *
     * @return  $response

The doc comment $response at position 0 could not be parsed: Unknown type name '$response' at position 0 in $response.

     */
    public function get() {
        try {
            $url = $this->url . $this->api . $this->v2 . $this->visualisation;
            $response = $this->request($url);
            return $response;
        } catch (Exception $e) {

The type Ijeffro\Laralocker\LearningLocker\Visualisations\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

            return $e;
        }
    }

    /**
     * Learning Locker: Request Organisation Details
     *
     * @return  $response

The doc comment $response at position 0 could not be parsed: Unknown type name '$response' at position 0 in $response.

     */
    public function update($data) {
        try {
            $url = $this->url . $this->api . $this->v2 . $this->visualisation . '/' . $this->id ?? $this->id;
            // dd($url);
            $response = $this->save($url, $data);
            return $response;
        } catch (Exception $e) {
            return $e;
        }
    }

}