ijeffro / laralocker

src/LearningLocker/Stores/StoreHandler.php

Braces +3 added lines, -1 removed lines

@@ -32,7 +32,9 @@
             $url = $this->url . $this->api . $this->v2 . $this->store . '/' . $this->id ?? $this->id;
             $response = $this->request($url);
 
-            if ($selected) $response = $this->select($selected, $response);
+            if ($selected) {
+                $response = $this->select($selected, $response);
+            }
 
             return $response;
 

src/LearningLocker/Client/ClientHandler.php

Braces +3 added lines, -1 removed lines

@@ -33,7 +33,9 @@
             $url = $this->url . $this->api . $this->v2 . $this->client . '/' . $this->id ??  $this->id;
             $response = $this->request($url);
 
-            if ($selected) $response = $this->select($selected, $response);
+            if ($selected) {
+                $response = $this->select($selected, $response);
+            }
 
             return $response;
         } catch (Exception $e) {

src/LearningLocker/Statements/StatementGenerator.php

Braces +3 added lines, -1 removed lines

@@ -397,7 +397,9 @@
   */
     public function sendRequestsOld(){
       $error = $this->checkError();
-      if( $error ) return false;
+      if( $error ) {
+          return false;
+      }
 
       $results = array();
 

src/LearningLocker/Statements/StatementHandler.php

Braces +3 added lines, -1 removed lines

@@ -31,7 +31,9 @@
      */
     public function forwarding($id = null)
     {
-        if ($this->statement_forwarding) return $this->statement_forwarding;
+        if ($this->statement_forwarding) {
+            return $this->statement_forwarding;
+        }
 
         $this->statement_forwarding = new StatementForwardingHandler($id ? $id : null);
         return $this->forwarding($id ? $id : null);

src/LearningLocker/API/APIHandler.php

Braces +12 added lines, -8 removed lines

@@ -18,8 +18,9 @@ 
                 'auth' => $this->auth(),
                 'headers' => $this->headers()
             ]);
-            if ( $response->getStatusCode() === 404 )
-                throw new ClientException(404);
+            if ( $response->getStatusCode() === 404 ) {
+                            throw new ClientException(404);
+            }
 
             return $response->getBody()->getContents();
         } catch (ClientException $e) {
@@ -36,8 +37,9 @@ 
                 'headers' => $this->headers(),
                 'body' => $data
             ]);
-            if ( $response->getStatusCode() === 404 )
-                throw new ClientException(404);
+            if ( $response->getStatusCode() === 404 ) {
+                            throw new ClientException(404);
+            }
 
             return $response->getBody()->getContents();
         } catch (ClientException $e) {
@@ -52,8 +54,9 @@ 
                 'auth' => $this->auth(),
                 'headers' => $this->headers()
             ]);
-            if ( $response->getStatusCode() === 404 )
-                throw new ClientException(404);
+            if ( $response->getStatusCode() === 404 ) {
+                            throw new ClientException(404);
+            }
 
             return $response->getBody()->getContents();
         } catch (ClientException $e) {
@@ -117,8 +120,9 @@ 
                 return true;
             }
 
-            if ( $response->getStatusCode() === 404 )
-                throw new ClientException(404);
+            if ( $response->getStatusCode() === 404 ) {
+                            throw new ClientException(404);
+            }
 
             return $response->getBody()->getContents();
         } catch (ClientException $e) {

src/LearningLocker/Journeys/JourneyHandler.php

Braces +3 added lines, -1 removed lines

@@ -30,7 +30,9 @@
      */
     public function progress($id = null)
     {
-        if ($this->journey_progress) return $this->journey_progress;
+        if ($this->journey_progress) {
+            return $this->journey_progress;
+        }
 
         $this->journey_progress = new JourneyProgressHandler($id ? $id : null);
         return $this->progress($id ? $id : null);

src/LearningLocker/StatementForwarding/StatementForward.php

Braces +6 added lines, -2 removed lines

@@ -103,7 +103,9 @@ 
    * @return  $response
    */
   public function check($statementForwardId) {
-    if (empty($statementForwardId)) return false;
+    if (empty($statementForwardId)) {
+        return false;
+    }
     return $this->get($statementForwardId);
   }
 
@@ -180,7 +182,9 @@ 
    * @return  $response
    */
   protected function update($statementForwardId, $data) {
-    if (empty($statementForwardId)) return false;
+    if (empty($statementForwardId)) {
+        return false;
+    }
     $update = json_encode($data);
     try {
       $url = $this->endpoint . $this->api . $this->v2 . $this->statementForward . '/' . $statementForwardId;

src/LearningLocker/StatementForwarding/Query.php

Braces +15 added lines, -5 removed lines

@@ -35,11 +35,21 @@
         $criteriaQuery['$comment'] = 'id:'  . $criterion->id . ', object_id:' . $criterion->object_id;
         $activity_id = $criterion->use_curatr_activity ? $criterion->object->getXapiUrl(true, true) : $criterion->activity_id;
         $criteriaQuery['statement.object.id'] = $activity_id;
-        if (!empty($criterion->verb)) $criteriaQuery['statement.verb.id'] = $criterion->verb;
-        if (!empty($criterion->completion)) $criteriaQuery['statement.result.completion'] = true;
-        if (!empty($criterion->success)) $criteriaQuery['statement.result.success'] = true;
-        if (is_numeric($criterion->raw)) $criteriaQuery['statement.result.score.raw'] = ['$gte' => floatval($criterion->raw)];
-        if (is_numeric($criterion->scaled)) $criteriaQuery['statement.result.score.scaled'] = ['$gte' => floatval($criterion->scaled)];
+        if (!empty($criterion->verb)) {
+            $criteriaQuery['statement.verb.id'] = $criterion->verb;
+        }
+        if (!empty($criterion->completion)) {
+            $criteriaQuery['statement.result.completion'] = true;
+        }
+        if (!empty($criterion->success)) {
+            $criteriaQuery['statement.result.success'] = true;
+        }
+        if (is_numeric($criterion->raw)) {
+            $criteriaQuery['statement.result.score.raw'] = ['$gte' => floatval($criterion->raw)];
+        }
+        if (is_numeric($criterion->scaled)) {
+            $criteriaQuery['statement.result.score.scaled'] = ['$gte' => floatval($criterion->scaled)];
+        }
 
         if (sizeof($criteriaQuery) > 0) {
           $queries[] = $criteriaQuery;

src/LearningLocker.php

Braces +84 added lines, -28 removed lines

@@ -65,7 +65,9 @@ 
      */
     public function connect($key, $secret, $url)
     {
-        if ($this->connection) return $this;
+        if ($this->connection) {
+            return $this;
+        }
 
         $this->connection = new Connection($key, $secret, $url);
         return $this->connect($key, $secret, $url);
@@ -78,7 +80,9 @@ 
      */
     public function clients()
     {
-        if ($this->clients) return $this->clients;
+        if ($this->clients) {
+            return $this->clients;
+        }
 
         $this->clients = new ClientHandler;
         return $this->clients();
@@ -92,7 +96,9 @@ 
      */
     public function client($id = null)
     {
-        if ($this->client) return $this->client;
+        if ($this->client) {
+            return $this->client;
+        }
         $this->client = new ClientHandler($id ? $id : null);
         return $this->client($id ? $id : null);
     }
@@ -104,7 +110,9 @@ 
      */
     public function users()
     {
-        if ($this->users) return $this->users;
+        if ($this->users) {
+            return $this->users;
+        }
 
         $this->users = new UserHandler;
         return $this->users();
@@ -118,7 +126,9 @@ 
      */
     public function user($id = null)
     {
-        if ($this->user) return $this->user;
+        if ($this->user) {
+            return $this->user;
+        }
 
         $this->user = new UserHandler($id ? $id : null);
         return $this->user($id ? $id : null);
@@ -131,7 +141,9 @@ 
      */
     public function roles()
     {
-        if ($this->roles) return $this->roles;
+        if ($this->roles) {
+            return $this->roles;
+        }
 
         $this->roles = new RoleHandler;
         return $this->roles();
@@ -145,7 +157,9 @@ 
      */
     public function role($id = null)
     {
-        if ($this->role) return $this->role;
+        if ($this->role) {
+            return $this->role;
+        }
 
         $this->role = new RoleHandler($id ? $id : null);
         return $this->role($id ? $id : null);
@@ -158,7 +172,9 @@ 
      */
     public function stores()
     {
-        if ($this->stores) return $this->stores;
+        if ($this->stores) {
+            return $this->stores;
+        }
 
         $this->stores = new StoreHandler;
         return $this->stores();
@@ -172,7 +188,9 @@ 
      */
     public function store($id = null)
     {
-        if ($this->store) return $this->store;
+        if ($this->store) {
+            return $this->store;
+        }
 
         $this->store = new StoreHandler($id ? $id : null);
         return $this->store($id ? $id : null);
@@ -185,7 +203,9 @@ 
      */
     public function queries()
     {
-        if ($this->queries) return $this->queries;
+        if ($this->queries) {
+            return $this->queries;
+        }
 
         $this->queries = new QueryHandler;
         return $this->queries();
@@ -198,7 +218,9 @@ 
      */
     public function query($id = null)
     {
-        if ($this->query) return $this->query;
+        if ($this->query) {
+            return $this->query;
+        }
 
         $this->query = new QueryHandler($id ? $id : null);
         return $this->query($id ? $id : null);
@@ -211,7 +233,9 @@ 
      */
     public function exports()
     {
-        if ($this->exports) return $this->exports;
+        if ($this->exports) {
+            return $this->exports;
+        }
 
         $this->exports = new ExportHandler;
         return $this->exports();
@@ -224,7 +248,9 @@ 
      */
     public function export($id = null)
     {
-        if ($this->export) return $this->export;
+        if ($this->export) {
+            return $this->export;
+        }
 
         $this->export = new ExportHandler($id ? $id : null);
         return $this->export($id ? $id : null);
@@ -237,7 +263,9 @@ 
      */
     public function personas()
     {
-        if ($this->personas) return $this->personas;
+        if ($this->personas) {
+            return $this->personas;
+        }
 
         $this->personas = new PersonaHandler;
         return $this->personas();
@@ -251,7 +279,9 @@ 
      */
     public function persona($id = null)
     {
-        if ($this->persona) return $this->persona;
+        if ($this->persona) {
+            return $this->persona;
+        }
 
         $this->persona = new PersonaHandler($id ? $id : null);
         return $this->persona($id ? $id : null);
@@ -264,7 +294,9 @@ 
      */
     public function journeys()
     {
-        if ($this->journeys) return $this->journeys;
+        if ($this->journeys) {
+            return $this->journeys;
+        }
 
         $this->journeys = new JourneyHandler;
         return $this->journeys();
@@ -278,7 +310,9 @@ 
      */
     public function journey($id = null)
     {
-        if ($this->journey) return $this->journey;
+        if ($this->journey) {
+            return $this->journey;
+        }
 
         $this->journey = new JourneyHandler($id ? $id : null);
         return $this->journey($id ? $id : null);
@@ -292,7 +326,9 @@ 
      */
     public function journeyProgress($id = null)
     {
-        if ($this->journey_progress) return $this->journey_progress;
+        if ($this->journey_progress) {
+            return $this->journey_progress;
+        }
 
         $this->journey_progress = new JourneyProgressHandler($id ? $id : null);
         return $this->journeyProgress($id ? $id : null);
@@ -305,7 +341,9 @@ 
      */
     public function dashboards()
     {
-        if ($this->dashboards) return $this->dashboards;
+        if ($this->dashboards) {
+            return $this->dashboards;
+        }
 
         $this->dashboards = new DashboardHandler;
         return $this->dashboards();
@@ -319,7 +357,9 @@ 
      */
     public function dashboard($id = null)
     {
-        if ($this->dashboard) return $this->dashboard;
+        if ($this->dashboard) {
+            return $this->dashboard;
+        }
 
         $this->dashboard = new DashboardHandler($id ? $id : null);
         return $this->dashboard($id ? $id : null);
@@ -332,7 +372,9 @@ 
      */
     public function downloads()
     {
-        if ($this->downloads) return $this->downloads;
+        if ($this->downloads) {
+            return $this->downloads;
+        }
 
         $this->downloads = new DownloadHandler;
         return $this->downloads();
@@ -345,7 +387,9 @@ 
      */
     public function download($id)
     {
-        if ($this->download) return $this->download;
+        if ($this->download) {
+            return $this->download;
+        }
 
         $this->download = new DownloadHandler($id);
         return $this->download($id);
@@ -358,7 +402,9 @@ 
      */
     public function statements()
     {
-        if ($this->statements) return $this->statements;
+        if ($this->statements) {
+            return $this->statements;
+        }
 
         $this->statements = new StatementHandler;
         return $this->statements();
@@ -372,7 +418,9 @@ 
      */
     public function statement($id = null)
     {
-        if ($this->statement) return $this->statement;
+        if ($this->statement) {
+            return $this->statement;
+        }
 
         $this->statement = new StatementHandler($id ?? $id);
         return $this->statement($id ?? $id);
@@ -385,7 +433,9 @@ 
      */
     public function statementForwarding($id = null)
     {
-        if ($this->statement_forwarding) return $this->statement_forwarding;
+        if ($this->statement_forwarding) {
+            return $this->statement_forwarding;
+        }
 
         $this->statement_forwarding = new StatementForwardingHandler($id ?? $id);
         return $this->statementForwarding($id ?? $id);
@@ -399,7 +449,9 @@ 
      */
     public function organisation($id)
     {
-        if ($this->organisation) return $this->organisation;
+        if ($this->organisation) {
+            return $this->organisation;
+        }
 
         $this->organisation = new OrganisationHandler($id);
         return $this->organisation($id);
@@ -413,7 +465,9 @@ 
      */
     public function visualisations()
     {
-        if ($this->visualisations) return $this->visualisations;
+        if ($this->visualisations) {
+            return $this->visualisations;
+        }
 
         $this->visualisations = new VisualisationHandler;
         return $this->visualisations();
@@ -427,7 +481,9 @@ 
      */
     public function visualisation($id = null)
     {
-        if ($this->visualisation) return $this->visualisation;
+        if ($this->visualisation) {
+            return $this->visualisation;
+        }
 
         $this->visualisation = new VisualisationHandler($id ? $id : null);
         return $this->visualisation($id ? $id : null);