Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class News |
|
|
|||
11 | { |
||
12 | use ImmutableTrait, SerializableTrait; |
||
13 | |||
14 | /** |
||
15 | * @var int |
||
16 | */ |
||
17 | private $id; |
||
18 | |||
19 | /** |
||
20 | * @var string |
||
21 | */ |
||
22 | private $title; |
||
23 | |||
24 | /** |
||
25 | * @var string |
||
26 | */ |
||
27 | private $content; |
||
28 | |||
29 | /** |
||
30 | * @var Carbon |
||
31 | */ |
||
32 | private $date; |
||
33 | |||
34 | /** |
||
35 | * News constructor. |
||
36 | * @param int $id |
||
37 | * @param string $title |
||
38 | * @param string $content |
||
39 | * @param Carbon $date |
||
40 | * @throws ImmutableException |
||
41 | */ |
||
42 | public function __construct(int $id, string $title, string $content, Carbon $date) |
||
51 | |||
52 | /** |
||
53 | * @return int |
||
54 | */ |
||
55 | public function getId(): int |
||
59 | |||
60 | /** |
||
61 | * @return string |
||
62 | */ |
||
63 | public function getTitle(): string |
||
67 | |||
68 | /** |
||
69 | * @return string |
||
70 | */ |
||
71 | public function getContent(): string |
||
75 | |||
76 | /** |
||
77 | * @return Carbon |
||
78 | */ |
||
79 | public function getDate(): Carbon |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.