Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class Houses |
|
|
|||
11 | { |
||
12 | use ImmutableTrait, SerializableTrait; |
||
13 | |||
14 | /** |
||
15 | * @var string |
||
16 | */ |
||
17 | private $town; |
||
18 | |||
19 | /** |
||
20 | * @var string |
||
21 | */ |
||
22 | private $world; |
||
23 | |||
24 | /** |
||
25 | * @var string |
||
26 | */ |
||
27 | private $type; |
||
28 | |||
29 | /** |
||
30 | * @var Collection |
||
31 | */ |
||
32 | private $houses; |
||
33 | |||
34 | /** |
||
35 | * Houses constructor. |
||
36 | * @param string $town |
||
37 | * @param string $world |
||
38 | * @param string $type |
||
39 | * @param array $houses |
||
40 | * @throws \Igorsgm\TibiaDataApi\Exceptions\ImmutableException |
||
41 | */ |
||
42 | public function __construct(string $town, string $world, string $type, Collection $houses) |
||
51 | |||
52 | /** |
||
53 | * @return string |
||
54 | */ |
||
55 | public function getTown(): string |
||
59 | |||
60 | /** |
||
61 | * @return string |
||
62 | */ |
||
63 | public function getWorld(): string |
||
67 | |||
68 | /** |
||
69 | * @return string |
||
70 | */ |
||
71 | public function getType(): string |
||
75 | |||
76 | /** |
||
77 | * @return House[] |
||
78 | */ |
||
79 | public function getHouses(): Collection |
||
83 | } |
||
84 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.