Completed
Pull Request — master (#23)
by Shestakov
15:36
created
Source/Ice/WidgetComponent/HtmlTag.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     }
82 82
 
83 83
     /**
84
-     * @return null
84
+     * @return null|\Exception
85 85
      * @throws Error
86 86
      */
87 87
     public function getRoute()
Please login to merge, or discard this patch.
Source/Ice/Action/Render.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Ice\Action\Render;
6 6
 use Ice\Core\Action;
7
-use Ice\Core\Debuger;
8 7
 use Ice\Core\Request;
9 8
 use Ice\Core\Resource;
10 9
 use Ice\Core\Route;
Please login to merge, or discard this patch.
Source/Ice/Action/Render/Excel.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -9,10 +9,8 @@
 block discarded – undo
9 9
 namespace Ice\Action;
10 10
 
11 11
 use Ice\Core\Action;
12
-use Ice\Core\Debuger;
13 12
 use Ice\Core\Widget;
14 13
 use Ice\DataProvider\Request;
15
-use Ice\DataProvider\Router;
16 14
 use Ice\Render\External_PHPExcel;
17 15
 
18 16
 class Render_Excel extends Action
Please login to merge, or discard this patch.
Source/Ice/Action/Security/Password/Login/RestorePassword/Submit.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Ice\Widget;
3 3
 
4 4
 use Ice\Action\Security_LoginEmailPassword_ChangePassword_Submit;
5
-use Ice\Core\Model;
6 5
 use Ice\Core\Widget_Security;
7 6
 use Ice\DataProvider\Request;
8 7
 
Please login to merge, or discard this patch.
Source/Ice/Action/Security/Password/LoginEmail/Login/Submit.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Ice\Action\Render;
6 6
 use Ice\Core\Action;
7
-use Ice\Core\Debuger;
8 7
 use Ice\Core\Request;
9 8
 use Ice\Core\Resource;
10 9
 use Ice\Core\Route;
Please login to merge, or discard this patch.
Source/Ice/Core/Action/Job.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@
 block discarded – undo
96 96
         ])->save();
97 97
     }
98 98
 
99
+    /**
100
+     * @param string $log
101
+     */
99 102
     protected function log(Worker_Task $task, $log)
100 103
     {
101 104
         $task->set(['log' => $log])->save();
Please login to merge, or discard this patch.
Source/Ice/Core/Message.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@
 block discarded – undo
211 211
     }
212 212
 
213 213
     /**
214
-     * @param array $attachments
214
+     * @param array $attachment
215 215
      */
216 216
     public function addAttachment($name, $attachment)
217 217
     {
Please login to merge, or discard this patch.
Source/Ice/Core/Model.php 1 patch
Doc Comments   +21 added lines, -8 removed lines patch added patch discarded remove patch
@@ -270,6 +270,10 @@  discard block
 block discarded – undo
270 270
         return $this;
271 271
     }
272 272
 
273
+    /**
274
+     * @param string $model
275
+     * @param boolean $isAffected
276
+     */
273 277
     private function setModelValue($model, $isAffected)
274 278
     {
275 279
         if (!($model instanceof Model)) {
@@ -321,7 +325,7 @@  discard block
 block discarded – undo
321 325
     /**
322 326
      * Gets full model field name if send short name (for example: '/name' for model User -> user_name)
323 327
      *
324
-     * @param  $fieldName
328
+     * @param  string|null $fieldName
325 329
      * @return string
326 330
      *
327 331
      * @author dp <[email protected]>
@@ -349,7 +353,7 @@  discard block
 block discarded – undo
349 353
     }
350 354
 
351 355
     /**
352
-     * @param $fieldName
356
+     * @param string $fieldName
353 357
      * @param $fieldValue
354 358
      * @return array
355 359
      *
@@ -427,7 +431,7 @@  discard block
 block discarded – undo
427 431
     }
428 432
 
429 433
     /**
430
-     * @param $fieldName
434
+     * @param string $fieldName
431 435
      * @param $fieldValue
432 436
      * @return array
433 437
      *
@@ -461,6 +465,9 @@  discard block
 block discarded – undo
461 465
         return $this->setValue($jsonFieldName, Json::encode($this->json[$fieldName]));
462 466
     }
463 467
 
468
+    /**
469
+     * @param string $fieldName
470
+     */
464 471
     private function setSpatialValue($fieldName, $fieldValue)
465 472
     {
466 473
         $geoFieldName = $fieldName . '__geo';
@@ -482,6 +489,9 @@  discard block
 block discarded – undo
482 489
         return $this->setValue($geoFieldName, $fieldValue);
483 490
     }
484 491
 
492
+    /**
493
+     * @param string $fieldName
494
+     */
485 495
     private function setFkValue($fieldName, $fieldValue)
486 496
     {
487 497
         $fkFieldName = $fieldName . '__fk';
@@ -1163,7 +1173,7 @@  discard block
 block discarded – undo
1163 1173
 
1164 1174
     /**
1165 1175
      * @param Model $modelClass
1166
-     * @param $dataSourceKey
1176
+     * @param string|null $dataSourceKey
1167 1177
      */
1168 1178
     private function update($modelClass, $dataSourceKey)
1169 1179
     {
@@ -1220,8 +1230,8 @@  discard block
 block discarded – undo
1220 1230
 
1221 1231
     /**
1222 1232
      * @param Model $modelClass
1223
-     * @param $isSmart
1224
-     * @param $dataSourceKey
1233
+     * @param boolean $isSmart
1234
+     * @param string|null $dataSourceKey
1225 1235
      */
1226 1236
     private function insert($modelClass, $isSmart, $dataSourceKey)
1227 1237
     {
@@ -1267,7 +1277,7 @@  discard block
 block discarded – undo
1267 1277
     /**
1268 1278
      * Execute select from data source
1269 1279
      *
1270
-     * @param  $fieldNames
1280
+     * @param  string $fieldNames
1271 1281
      * @param  string|null $dataSourceKey
1272 1282
      * @param  int $ttl
1273 1283
      * @return Model|null
@@ -1486,6 +1496,9 @@  discard block
 block discarded – undo
1486 1496
             : Query::getBuilder($selfModelClass)->pk($this->getPk());
1487 1497
     }
1488 1498
 
1499
+    /**
1500
+     * @param string $fieldNames
1501
+     */
1489 1502
     public function fetchOne($modelClass, $fieldNames, $lazy = false)
1490 1503
     {
1491 1504
         $modelClass = Model::getClass($modelClass);
@@ -1512,7 +1525,7 @@  discard block
 block discarded – undo
1512 1525
      * Return model by primary key
1513 1526
      *
1514 1527
      * @param  $pk
1515
-     * @param  array|string $fieldNames
1528
+     * @param  string $fieldNames
1516 1529
      * @param  string|null $dataSourceKey
1517 1530
      * @param  int $ttl
1518 1531
      * @return Model|null
Please login to merge, or discard this patch.
Source/Ice/Core/ModelScheme.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
      * @param mixed $class
13 13
      * @param null $postfix
14 14
      * @param bool $isRequired
15
-     * @param null $ttl
15
+     * @param integer $ttl
16 16
      * @param array $config
17 17
      * @return ModelScheme|Config
18 18
      */
Please login to merge, or discard this patch.