ifacesoft / ice

Source/Ice/Action/Security/Password/Login/ChangePassword/Submit.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Ice\Core\Model_Account;
 use Ice\Core\Security as Core_Security;
 use Ice\Model\Account;
-use Ice\Widget\Account_Password_Login_ChangePassword;
 
 class Security_Password_Login_ChangePassword_Submit extends Security
 {

Source/Ice/Action/Security/Password/Login/Register/Submit.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Ice\Action\Render;
 use Ice\Core\Action;
-use Ice\Core\Debuger;
 use Ice\Core\Request;
 use Ice\Core\Resource;
 use Ice\Core\Route;

Source/Ice/Action/Security/Password/Login/RestorePasswordConfirm/Submit.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Ice\Widget;
 
 use Ice\Action\Security_LoginEmailPassword_ChangePassword_Submit;
-use Ice\Core\Model;
 use Ice\Core\Widget_Security;
 use Ice\DataProvider\Request;
 

Source/Ice/Core/Config.php

Doc Comments +5 added lines, -5 removed lines

@@ -66,7 +66,7 @@ 
     /**
      * Return default config for class
      *
-     * @param  $key
+     * @param  string $key
      * @return Config
      *
      * @author dp <denis.a.shestakov@gmail.com>
@@ -80,7 +80,7 @@ 
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Config
      */
     public function getConfig($key)
@@ -159,7 +159,7 @@ 
      * Get config object by type or key
      *
      * @param  mixed $class
-     * @param  null $postfix
+     * @param  null|string $postfix
      * @param  bool $isRequired
      * @param  integer $ttl
      * @param array $selfConfig
@@ -239,7 +239,7 @@ 
     /**
      * Return default key
      *
-     * @return Core
+     * @return string
      *
      * @author dp <denis.a.shestakov@gmail.com>
      *
@@ -333,7 +333,7 @@ 
     /**
      * Save config
      *
-     * @param null $path
+     * @param string $path
      * @return Config
      * @author dp <denis.a.shestakov@gmail.com>
      *

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Ice\DataProvider\Repository;
 use Ice\Exception\Config_Error;
 use Ice\Exception\Config_Param_NotFound;
-use Ice\Exception\Error;
 use Ice\Exception\FileNotFound;
 use Ice\Helper\Config as Helper_Config;
 use Ice\Helper\File;

Source/Ice/Core/Environment.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
      * @param \Exception $exception
      * @param $output
      *
-     * @param $class
+     * @param string $class
      * @throws \Exception
      * @author dp <denis.a.shestakov@gmail.com>
      *

Source/Ice/Core/Logger.php

Doc Comments +11 added lines, -4 removed lines

@@ -390,6 +390,10 @@ 
         self::$log = [];
     }
 
+    /**
+     * @param string $value
+     * @param string $label
+     */
     public static function log($value, $label = null, $type = 'LOG', $options = [])
     {
         $value = str_replace(["\n", "\t"], ' ', $value);
@@ -522,6 +526,9 @@ 
         }
     }
 
+    /**
+     * @param string $type
+     */
     private function getFbType($type)
     {
         switch ($type) {
@@ -559,8 +566,8 @@ 
      * Warning
      *
      * @param  $message
-     * @param  $file
-     * @param  $line
+     * @param  string $file
+     * @param  integer $line
      * @param  \Exception $e
      * @param  null $errcontext
      * @param  int $errno
@@ -580,8 +587,8 @@ 
      * Fatal - throw ice exception
      *
      * @param  $message
-     * @param  $file
-     * @param  $line
+     * @param  string $file
+     * @param  integer $line
      * @param  \Exception $e
      * @param  null $errcontext
      * @param  int $errno

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Ice\Core;
 
 use Ice\Core;
-use Ice\Helper\String;
 
 /**
  * Class DataSource

Source/Ice/Core/Model.php

Doc Comments +20 added lines, -7 removed lines

@@ -272,6 +272,10 @@ 
         return $this;
     }
 
+    /**
+     * @param string $model
+     * @param boolean $isAffected
+     */
     private function setModelValue($model, $isAffected)
     {
         if (!($model instanceof Model)) {
@@ -323,7 +327,7 @@ 
     /**
      * Gets full model field name if send short name (for example: '/name' for model User -> user_name)
      *
-     * @param  $fieldName
+     * @param  string|null $fieldName
      * @return string
      *
      * @author dp <denis.a.shestakov@gmail.com>
@@ -347,7 +351,7 @@ 
     }
 
     /**
-     * @param $fieldName
+     * @param string $fieldName
      * @param $fieldValue
      * @return array
      *
@@ -425,7 +429,7 @@ 
     }
 
     /**
-     * @param $fieldName
+     * @param string $fieldName
      * @param $fieldValue
      * @return array
      *
@@ -459,6 +463,9 @@ 
         return $this->setValue($jsonFieldName, Json::encode($this->json[$fieldName]));
     }
 
+    /**
+     * @param string $fieldName
+     */
     private function setSpatialValue($fieldName, $fieldValue)
     {
         $geoFieldName = $fieldName . '__geo';
@@ -480,6 +487,9 @@ 
         return $this->setValue($geoFieldName, $fieldValue);
     }
 
+    /**
+     * @param string $fieldName
+     */
     private function setFkValue($fieldName, $fieldValue)
     {
         $fkFieldName = $fieldName . '__fk';
@@ -1146,7 +1156,7 @@ 
 
     /**
      * @param Model $modelClass
-     * @param $dataSourceKey
+     * @param string|null $dataSourceKey
      */
     private function update($modelClass, $dataSourceKey)
     {
@@ -1203,8 +1213,8 @@ 
 
     /**
      * @param Model $modelClass
-     * @param $isSmart
-     * @param $dataSourceKey
+     * @param boolean $isSmart
+     * @param string|null $dataSourceKey
      */
     private function insert($modelClass, $isSmart, $dataSourceKey)
     {
@@ -1247,7 +1257,7 @@ 
     /**
      * Execute select from data source
      *
-     * @param  $fieldNames
+     * @param  string $fieldNames
      * @param  string|null $dataSourceKey
      * @param  int $ttl
      * @return Model|null
@@ -1459,6 +1469,9 @@ 
             : Query::getBuilder($selfModelClass)->pk($this->getPk());
     }
 
+    /**
+     * @param string $fieldNames
+     */
     public function fetchOne($modelClass, $fieldNames, $lazy = false)
     {
         $modelClass = Model::getClass($modelClass);

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
 use Ice\Helper\Model as Helper_Model;
 use Ice\Helper\Object;
 use Ice\Helper\Spatial;
-use Ice\Widget\Model_Form;
-use Ice\Widget\Model_Table;
 
 /**
  * Class Model

Source/Ice/Core/Model/Account/Password.php

Doc Comments +3 added lines

@@ -172,6 +172,9 @@
             ->send();
     }
 
+    /**
+     * @param string $expired
+     */
     public function prolongate($expired)
     {
         // TODO: Implement prolongate() method.

Unused Use Statements -3 removed lines

@@ -2,16 +2,13 @@
 
 use Ice\Core\Config;
 use Ice\Core\DataSource;
-use Ice\Core\Debuger;
 use Ice\Core\Model;
 use Ice\Core\Model\Security_User;
 use Ice\Core\Model_Account;
 use Ice\Core\Request;
 use Ice\Core\Router;
 use Ice\Core\Security;
-use Ice\Exception\Security_Account_Login;
 use Ice\Exception\Security_Account_Verify;
-use Ice\Helper\Date;
 use Ice\Helper\String;
 use Ice\Message\Mail;
 use Ice\Model\Account;

Source/Ice/Core/QueryBuilder.php

Doc Comments +19 added lines, -15 removed lines

@@ -256,11 +256,11 @@ 
      *      ];
      * ```
      *
-     * @param $sqlLogical
+     * @param string $sqlLogical
      * @param $fieldNameValues
      * @param $sqlComparison
      * @param array|string $modelTableData Key -> modelClass, value -> tableAlias
-     * @param $isUse
+     * @param boolean $isUse
      * @return QueryBuilder
      * @author dp <denis.a.shestakov@gmail.com>
      *
@@ -390,8 +390,8 @@ 
      *
      * @param Model $modelClass
      * @param $fieldNames
-     * @param $isValidate
-     * @param $isInvalidate boolean
+     * @param boolean $isValidate
+     * @param boolean $isInvalidate boolean
      *
      * @author dp <denis.a.shestakov@gmail.com>
      *
@@ -417,7 +417,7 @@ 
     /**
      * Set in query part where expression 'IS NULL'
      *
-     * @param  $fieldName
+     * @param  string $fieldName
      * @param  array $modelTableData
      * @param  string $sqlLogical
      * @param bool $isUse
@@ -618,8 +618,8 @@ 
     /**
      * Set in query part where expression '> ?'
      *
-     * @param  $fieldName
-     * @param  $fieldValue
+     * @param  string $fieldName
+     * @param  string $fieldValue
      * @param  array $modelTableData
      * @param  string $sqlLogical
      * @param bool $isUse
@@ -705,7 +705,7 @@ 
      * Set in query part where expression '<> ?'
      *
      * @param  $fieldName
-     * @param  $fieldValue
+     * @param  string $fieldValue
      * @param  array $modelTableData
      * @param  string $sqlLogical
      * @param bool $isUse
@@ -754,7 +754,7 @@ 
     /**
      * Set in query part where expression '== 1' is boolean true(1)
      *
-     * @param  $fieldName
+     * @param  string $fieldName
      * @param  array $modelTableData
      * @param  string $sqlLogical
      * @return QueryBuilder
@@ -796,8 +796,8 @@ 
     /**
      * Set in query part where expression 'like ?'
      *
-     * @param  $fieldName
-     * @param  $fieldValue
+     * @param  string $fieldName
+     * @param  string $fieldValue
      * @param  array $modelTableData
      * @param  string $sqlLogical
      * @param bool $isUse
@@ -940,7 +940,7 @@ 
     /**
      * Return table alias for model class for query
      *
-     * @return Model
+     * @return null|string
      *
      * @author dp <denis.a.shestakov@gmail.com>
      *
@@ -1324,7 +1324,7 @@ 
      *
      * @param  array $rows Key-value array
      * @param  $part
-     * @param  $dataSourceKey
+     * @param  string|null $dataSourceKey
      * @return Query
      *
      * @author dp <denis.a.shestakov@gmail.com>
@@ -1837,6 +1837,10 @@ 
         return $this->addTrigger('afterSelect', $trigger, $params, $modelClass, $isUse);
     }
 
+    /**
+     * @param string $type
+     * @param boolean $isUse
+     */
     private function addTrigger($type, $trigger, $params, $modelClass, $isUse)
     {
         if (!$isUse) {
@@ -1888,7 +1892,7 @@ 
     }
 
     /**
-     * @param Widget[]|mixed $widgets
+     * @param string $widgets
      * @param bool $applyWidgetQueryBuilderParts
      * @return QueryBuilder
      */
@@ -1956,7 +1960,7 @@ 
      * Set query part limit
      *
      * @param  $limit
-     * @param  int|null $offset
+     * @param  integer $offset
      * @return QueryBuilder
      *
      * @author dp <denis.a.shestakov@gmail.com>