Completed
Pull Request — master (#23)
by Shestakov
08:07
created
Source/Ice/Render/Replace.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      * @param  array $data
57 57
      * @param null $layout
58 58
      * @param string $templateType
59
-     * @return mixed
59
+     * @return string
60 60
      * @throws \Exception
61 61
      * @author dp <[email protected]>
62 62
      *
Please login to merge, or discard this patch.
Source/Ice/Render/Smarty.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -91,9 +91,9 @@
 block discarded – undo
91 91
      *
92 92
      * @param string $template
93 93
      * @param  array $data
94
-     * @param null $layout
94
+     * @param string|null $layout
95 95
      * @param string $templateType
96
-     * @return mixed
96
+     * @return null|string
97 97
      * @throws \Exception
98 98
      * @author dp <[email protected]>
99 99
      *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use Ice\Core\Logger;
15 15
 use Ice\Core\Module;
16 16
 use Ice\Core\Render;
17
-use Ice\Core\ViiewOld;
18 17
 use Ice\Helper\Emmet;
19 18
 
20 19
 /**
Please login to merge, or discard this patch.
Source/Ice/Render/Twig.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      * @param  array $data
78 78
      * @param null $layout
79 79
      * @param string $templateType
80
-     * @return mixed
80
+     * @return string|null
81 81
      * @throws \Exception
82 82
      * @author dp <[email protected]>
83 83
      *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use Ice\Core\Logger;
15 15
 use Ice\Core\Module;
16 16
 use Ice\Core\Render;
17
-use Ice\Core\ViiewOld;
18 17
 
19 18
 /**
20 19
  * Class Twig
Please login to merge, or discard this patch.
Source/Ice/SessionHandler/DataSource.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      *
51 51
      * @link   http://php.net/manual/en/sessionhandlerinterafce.destroy.php
52 52
      * @param  int $session_id The session ID being destroyed.
53
-     * @return bool <p>
53
+     * @return boolean|null <p>
54 54
      * The return value (usually TRUE on success, FALSE on failure).
55 55
      * Note this value is returned internally to PHP for processing.
56 56
      * </p>
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
      * string and passing it as this parameter.
164 164
      * Please note sessions use an alternative serialization method.
165 165
      * </p>
166
-     * @return bool <p>
166
+     * @return boolean|null <p>
167 167
      * The return value (usually TRUE on success, FALSE on failure).
168 168
      * Note this value is returned internally to PHP for processing.
169 169
      * </p>
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -8,10 +8,8 @@
 block discarded – undo
8 8
 
9 9
 namespace Ice\WidgetComponent;
10 10
 
11
-use Ice\Core\Debuger;
12 11
 use Ice\Core\Render;
13 12
 use Ice\Core\Resource;
14
-use Ice\Exception\Error;
15 13
 use Ice\Helper\String;
16 14
 use Ice\Render\Replace;
17 15
 
Please login to merge, or discard this patch.
Source/Ice/SessionHandler/Native.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Close the session
12 12
      * @link http://php.net/manual/en/sessionhandlerinterface.close.php
13
-     * @return bool <p>
13
+     * @return boolean|null <p>
14 14
      * The return value (usually TRUE on success, FALSE on failure).
15 15
      * Note this value is returned internally to PHP for processing.
16 16
      * </p>
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      * Destroy a session
26 26
      * @link http://php.net/manual/en/sessionhandlerinterface.destroy.php
27 27
      * @param string $session_id The session ID being destroyed.
28
-     * @return bool <p>
28
+     * @return boolean|null <p>
29 29
      * The return value (usually TRUE on success, FALSE on failure).
30 30
      * Note this value is returned internally to PHP for processing.
31 31
      * </p>
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * Sessions that have not updated for
44 44
      * the last maxlifetime seconds will be removed.
45 45
      * </p>
46
-     * @return bool <p>
46
+     * @return boolean|null <p>
47 47
      * The return value (usually TRUE on success, FALSE on failure).
48 48
      * Note this value is returned internally to PHP for processing.
49 49
      * </p>
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      * @link http://php.net/manual/en/sessionhandlerinterface.open.php
60 60
      * @param string $save_path The path where to store/retrieve the session.
61 61
      * @param string $session_id The session id.
62
-     * @return bool <p>
62
+     * @return boolean|null <p>
63 63
      * The return value (usually TRUE on success, FALSE on failure).
64 64
      * Note this value is returned internally to PHP for processing.
65 65
      * </p>
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      * string and passing it as this parameter.
98 98
      * Please note sessions use an alternative serialization method.
99 99
      * </p>
100
-     * @return bool <p>
100
+     * @return boolean|null <p>
101 101
      * The return value (usually TRUE on success, FALSE on failure).
102 102
      * Note this value is returned internally to PHP for processing.
103 103
      * </p>
Please login to merge, or discard this patch.
Source/Ice/Widget/Form.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     /**
142 142
      * Add text type field
143 143
      *
144
-     * @param  $fieldName
144
+     * @param  string $fieldName
145 145
      * @param  array $options
146 146
      * @param  string $template
147 147
      * @return Form
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * Add password type field
184 184
      *
185
-     * @param  $fieldName
185
+     * @param  string $fieldName
186 186
      * @param  array $options
187 187
      * @param  string $template
188 188
      * @return Form
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
     }
411 411
 
412 412
     /**
413
-     * @param $fieldName
413
+     * @param string $fieldName
414 414
      * @param array $options
415 415
      * @param string $template
416 416
      * @return Form
Please login to merge, or discard this patch.
Source/Ice/Action/Resource/Dynamic.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
     /**
57 57
      * Runtime append resource
58 58
      *
59
-     * @param $resourceType
59
+     * @param string $resourceType
60 60
      * @param $resource
61 61
      *
62 62
      * @author dp <[email protected]>
Please login to merge, or discard this patch.
Source/Ice/Action/Security.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /**
160 160
      * @param Model_Account $account
161 161
      * @param $input
162
-     * @return null
162
+     * @return Model_Account
163 163
      * @throws Exception
164 164
      */
165 165
     final protected function restorePassword($account, $input)
@@ -214,6 +214,9 @@  discard block
 block discarded – undo
214 214
             ->exception(['Implement {$0} for {$1}', [__FUNCTION__, get_class($this)]], __FILE__, __LINE__);
215 215
     }
216 216
 
217
+    /**
218
+     * @param Model_Account $account
219
+     */
217 220
     final protected function changePassword($account, $accountData, $input)
218 221
     {
219 222
         $logger = $this->getLogger();
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Ice\Action;
4 4
 
5 5
 use Ice\Core\Config;
6
-use Ice\Core\DataSource;
7
-use Ice\Core\Debuger;
8 6
 use Ice\Core\Exception;
9 7
 use Ice\Core\Logger as Core_Logger;
10 8
 use Ice\Core\Model;
Please login to merge, or discard this patch.
Source/Ice/Action/Security/Password/Email/ChangePassword/Submit.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,9 @@
 block discarded – undo
3 3
 namespace Ice\Action;
4 4
 
5 5
 use Ice\Core\Logger;
6
-use Ice\Core\Model;
7 6
 use Ice\Core\Model_Account;
8 7
 use Ice\Core\Security as Core_Security;
9 8
 use Ice\Model\Account;
10
-use Ice\Widget\Account_Password_Email_ChangePassword;
11 9
 
12 10
 class Security_Password_Email_ChangePassword_Submit extends Security
13 11
 {
Please login to merge, or discard this patch.