Completed
Pull Request — master (#23)
by Shestakov
06:47
created
Source/Ice/Security/Ice.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     }
62 62
 
63 63
     /**
64
-     * @param Security_Account|Model $account
64
+     * @param Security_Account $account
65 65
      * @return bool
66 66
      */
67 67
     public function login(Security_Account $account)
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -3,13 +3,9 @@
 block discarded – undo
3 3
 namespace Ice\Security;
4 4
 
5 5
 use Ice\Core\Config;
6
-use Ice\Core\Debuger;
7 6
 use Ice\Core\Model;
8 7
 use Ice\Core\Security;
9 8
 use Ice\Core\Model\Security_Account;
10
-use Ice\Core\Model\Security_User;
11
-use Ice\DataProvider\Security as DataProvider_Security;
12
-use Ice\DataProvider\Session;
13 9
 use Ice\Exception\Security_Auth;
14 10
 use Ice\Model\Account_Phone_Password;
15 11
 use Ice\Model\User;
Please login to merge, or discard this patch.
Source/Ice/Security/Symfony.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
     }
101 101
 
102 102
     /**
103
-     * @param Security_Account|Model $account
104
-     * @return bool
103
+     * @param Security_Account $account
104
+     * @return Security_Account
105 105
      */
106 106
     public function login(Security_Account $account)
107 107
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,11 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use Application\Sonata\UserBundle\Entity\User;
6 6
 use Doctrine\ORM\EntityManager;
7
-use Ice\Core\Debuger;
8 7
 use Ice\Core\Model;
9 8
 use Ice\Core\Model\Security_Account;
10
-use Ice\DataProvider\Security as DataProvider_Security;
11
-use Ice\DataProvider\Session;
12 9
 use Symfony\Component\HttpKernel\Kernel;
13 10
 use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
14 11
 use Symfony\Component\Security\Core\Authorization\AuthorizationChecker;
Please login to merge, or discard this patch.
Source/Ice/SessionHandler/DataProvider.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      *
54 54
      * @link   http://php.net/manual/en/sessionhandlerinterafce.destroy.php
55 55
      * @param  int $session_id The session ID being destroyed.
56
-     * @return bool <p>
56
+     * @return boolean|null <p>
57 57
      * The return value (usually TRUE on success, FALSE on failure).
58 58
      * Note this value is returned internally to PHP for processing.
59 59
      * </p>
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      * string and passing it as this parameter.
147 147
      * Please note sessions use an alternative serialization method.
148 148
      * </p>
149
-     * @return bool <p>
149
+     * @return boolean|null <p>
150 150
      * The return value (usually TRUE on success, FALSE on failure).
151 151
      * Note this value is returned internally to PHP for processing.
152 152
      * </p>
Please login to merge, or discard this patch.
Source/Ice/SessionHandler/DataSource.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      *
51 51
      * @link   http://php.net/manual/en/sessionhandlerinterafce.destroy.php
52 52
      * @param  int $session_id The session ID being destroyed.
53
-     * @return bool <p>
53
+     * @return boolean|null <p>
54 54
      * The return value (usually TRUE on success, FALSE on failure).
55 55
      * Note this value is returned internally to PHP for processing.
56 56
      * </p>
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
      * string and passing it as this parameter.
164 164
      * Please note sessions use an alternative serialization method.
165 165
      * </p>
166
-     * @return bool <p>
166
+     * @return boolean|null <p>
167 167
      * The return value (usually TRUE on success, FALSE on failure).
168 168
      * Note this value is returned internally to PHP for processing.
169 169
      * </p>
Please login to merge, or discard this patch.
Source/Ice/SessionHandler/Native.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Close the session
12 12
      * @link http://php.net/manual/en/sessionhandlerinterface.close.php
13
-     * @return bool <p>
13
+     * @return boolean|null <p>
14 14
      * The return value (usually TRUE on success, FALSE on failure).
15 15
      * Note this value is returned internally to PHP for processing.
16 16
      * </p>
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      * Destroy a session
26 26
      * @link http://php.net/manual/en/sessionhandlerinterface.destroy.php
27 27
      * @param string $session_id The session ID being destroyed.
28
-     * @return bool <p>
28
+     * @return boolean|null <p>
29 29
      * The return value (usually TRUE on success, FALSE on failure).
30 30
      * Note this value is returned internally to PHP for processing.
31 31
      * </p>
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * Sessions that have not updated for
44 44
      * the last maxlifetime seconds will be removed.
45 45
      * </p>
46
-     * @return bool <p>
46
+     * @return boolean|null <p>
47 47
      * The return value (usually TRUE on success, FALSE on failure).
48 48
      * Note this value is returned internally to PHP for processing.
49 49
      * </p>
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      * @link http://php.net/manual/en/sessionhandlerinterface.open.php
60 60
      * @param string $save_path The path where to store/retrieve the session.
61 61
      * @param string $session_id The session id.
62
-     * @return bool <p>
62
+     * @return boolean|null <p>
63 63
      * The return value (usually TRUE on success, FALSE on failure).
64 64
      * Note this value is returned internally to PHP for processing.
65 65
      * </p>
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      * string and passing it as this parameter.
98 98
      * Please note sessions use an alternative serialization method.
99 99
      * </p>
100
-     * @return bool <p>
100
+     * @return boolean|null <p>
101 101
      * The return value (usually TRUE on success, FALSE on failure).
102 102
      * Note this value is returned internally to PHP for processing.
103 103
      * </p>
Please login to merge, or discard this patch.
Source/Ice/Validator/Pattern.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      *
53 53
      * @param  $data
54 54
      * @param  array $scheme
55
-     * @return boolean
55
+     * @return integer
56 56
      *
57 57
      * @author dp <[email protected]>
58 58
      *
Please login to merge, or discard this patch.
Source/Ice/Widget/Block/Render.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -8,8 +8,6 @@
 block discarded – undo
8 8
 
9 9
 namespace Ice\Widget;
10 10
 
11
-use Ice\Core\Debuger;
12
-
13 11
 class Block_Render extends Block
14 12
 {
15 13
     /** Build widget
Please login to merge, or discard this patch.
Source/Ice/Widget/Form.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     /**
142 142
      * Add text type field
143 143
      *
144
-     * @param  $fieldName
144
+     * @param  string $fieldName
145 145
      * @param  array $options
146 146
      * @param  string $template
147 147
      * @return Form
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * Add password type field
184 184
      *
185
-     * @param  $fieldName
185
+     * @param  string $fieldName
186 186
      * @param  array $options
187 187
      * @param  string $template
188 188
      * @return Form
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
     }
411 411
 
412 412
     /**
413
-     * @param $fieldName
413
+     * @param string $fieldName
414 414
      * @param array $options
415 415
      * @param string $template
416 416
      * @return Form
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace Ice\Widget;
4 4
 
5
-use Ice\Core\Action;
6
-use Ice\Core\Debuger;
7 5
 use Ice\Core\Module;
8 6
 use Ice\Core\Validator;
9 7
 use Ice\Core\Widget;
@@ -18,9 +16,7 @@  discard block
 block discarded – undo
18 16
 use Ice\WidgetComponent\FormElement;
19 17
 use Ice\WidgetComponent\FormElement_Button;
20 18
 use Ice\WidgetComponent\FormElement_Chosen;
21
-use Ice\WidgetComponent\FormElement_Period;
22 19
 use Ice\WidgetComponent\FormElement_TextInput;
23
-use Ice\WidgetComponent\FormElement_Typehead;
24 20
 
25 21
 class Form extends Widget
26 22
 {
Please login to merge, or discard this patch.
Source/Ice/Widget/Pagination.php 2 patches
Doc Comments   +16 added lines, -13 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     /**
60 60
      * @param null $route
61
-     * @return array
61
+     * @return Pagination
62 62
      * @throws Error
63 63
      */
64 64
     public function setRoute($route)
@@ -162,6 +162,9 @@  discard block
 block discarded – undo
162 162
             ->last($page, $pageCount);
163 163
     }
164 164
 
165
+    /**
166
+     * @param string $name
167
+     */
165 168
     public function li($name, array $options = [], $template = 'Ice\Widget\Pagination\Li')
166 169
     {
167 170
         $route = $this->getRoute();
@@ -180,8 +183,8 @@  discard block
 block discarded – undo
180 183
     }
181 184
 
182 185
     /**
183
-     * @param $page
184
-     * @param $pageCount
186
+     * @param double $page
187
+     * @param integer $pageCount
185 188
      * @return Pagination
186 189
      */
187 190
     private function last($page, $pageCount)
@@ -212,8 +215,8 @@  discard block
 block discarded – undo
212 215
     }
213 216
 
214 217
     /**
215
-     * @param $page
216
-     * @param $pageCount
218
+     * @param double $page
219
+     * @param integer $pageCount
217 220
      * @return Pagination
218 221
      */
219 222
     private function fastFastNext($page, $pageCount)
@@ -242,8 +245,8 @@  discard block
 block discarded – undo
242 245
     }
243 246
 
244 247
     /**
245
-     * @param $page
246
-     * @param $pageCount
248
+     * @param double $page
249
+     * @param integer $pageCount
247 250
      * @return Pagination
248 251
      */
249 252
     private function fastNext($page, $pageCount)
@@ -270,8 +273,8 @@  discard block
 block discarded – undo
270 273
     }
271 274
 
272 275
     /**
273
-     * @param $page
274
-     * @param $pageCount
276
+     * @param double $page
277
+     * @param integer $pageCount
275 278
      * @return Pagination
276 279
      */
277 280
     private function nextNext($page, $pageCount)
@@ -284,8 +287,8 @@  discard block
 block discarded – undo
284 287
     }
285 288
 
286 289
     /**
287
-     * @param $page
288
-     * @param $pageCount
290
+     * @param double $page
291
+     * @param integer $pageCount
289 292
      * @return Pagination
290 293
      */
291 294
     private function next($page, $pageCount)
@@ -299,7 +302,7 @@  discard block
 block discarded – undo
299 302
 
300 303
     /**
301 304
      * @param $page
302
-     * @param $pageCount
305
+     * @param integer $pageCount
303 306
      * @return Pagination
304 307
      */
305 308
     private function curr($page, $pageCount)
@@ -411,7 +414,7 @@  discard block
 block discarded – undo
411 414
     }
412 415
 
413 416
     /**
414
-     * @param $page
417
+     * @param integer $page
415 418
      * @param $currentPage
416 419
      * @return Pagination
417 420
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,12 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Ice\Widget;
4 4
 
5
-use Ice\Action\Render;
6
-use Ice\Core\Debuger;
7 5
 use Ice\Core\QueryBuilder;
8 6
 use Ice\Core\QueryResult;
9
-use Ice\Core\Request;
10
-use Ice\Core\Router;
11 7
 use Ice\Core\Widget;
12 8
 use Ice\DataProvider\Request as DataProvider_Request;
13 9
 use Ice\DataProvider\Router as DataProvider_Router;
Please login to merge, or discard this patch.