AppBundle\Controller\SancionController

Complexity

Total Complexity

24

Size/Duplication

Total Lines	262
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	18

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	sancionarAction()	0	49	4
C	listadoNotificarAction()	0	47	9
A	listarAction()	0	17	1
B	detalleAction()	0	51	5
B	informeAction()	0	41	4
A	detallePdfAction()	0	23	1

<?php
/*
  GESTCONV - Aplicación web para la gestión de la convivencia en centros educativos

  Copyright (C) 2015: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Controller;

use AppBundle\Entity\Alumno;
use AppBundle\Entity\AvisoSancion;
use AppBundle\Entity\ObservacionSancion;
use AppBundle\Entity\Sancion;
use AppBundle\Form\Type\NuevaObservacionType;
use AppBundle\Form\Type\NuevaSancionType;
use AppBundle\Form\Type\RangoFechasInformeType;
use AppBundle\Form\Type\SancionType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @Route("/sancion")
 */

class SancionController extends BaseController
{
    /**
     * @Route("/nueva/{alumno}", name="parte_sancionar",methods={"GET", "POST"})
     * @Security("has_role('ROLE_REVISOR')")
     */
    public function sancionarAction(Alumno $alumno, Request $peticion)
    {
        $sancion = new Sancion();
        $usuario = $this->getUser();

        $sancion->setFechaSancion(new \DateTime())
            ->setUsuario($usuario)

It seems like $usuario defined by $this->getUser() on line 50 can also be of type object; however, AppBundle\Entity\Sancion::setUsuario() does only seem to accept null|object<AppBundle\Entity\Usuario>, maybe add an additional type check?

            ->setRegistradoEnSeneca(false);

        $em = $this->getDoctrine()->getManager();

        $partes = $em->getRepository('AppBundle:Parte')->findAllSancionablesPorAlumno($alumno);

        $formulario = $this->createForm(new NuevaSancionType(), $sancion, array(
            'alumno' => $alumno
        ));

        $formulario->handleRequest($peticion);

        if ($formulario->isSubmitted() && $formulario->isValid()) {

            $em = $this->getDoctrine()->getManager();

            foreach($sancion->getPartes() as $parte) {
                $parte->setSancion($sancion);
            }
            $em->persist($sancion);
            $em->flush();

            $this->notificarSancion($alumno->getGrupo()->getTutores(), $sancion);
            $this->notificarSancion($em->getRepository('AppBundle:Usuario')->getUsuariosDeSancion($sancion), $sancion);

            $this->addFlash('success', 'Se ha registrado la sanción');

            // redireccionar a la portada
            return new RedirectResponse(
                $this->generateUrl('parte_pendiente')
            );
        }

        return $this->render('AppBundle:Parte:sancionar.html.twig',
            array(
                'alumno' => $alumno,
                'partes' => $partes,
                'sanciones' => $em->getRepository('AppBundle:Sancion')->findAllPorAlumno($alumno),
                'formulario' => $formulario->createView(),
                'usuario' => $usuario
            ));
    }

    /**
     * @Route("/notificar", name="sancion_listado_notificar",methods={"GET", "POST"})
     * @Security("has_role('ROLE_REVISOR') or has_role('ROLE_TUTOR') ")
     */
    public function listadoNotificarAction(Request $request)
    {
        $usuario = $this->getUser();
        $em = $this->getDoctrine()->getManager();

        if (($request->getMethod() === 'POST') && (($request->request->get('noNotificada')) || ($request->request->get('notificada')))) {

            $id = $request->request->get(($request->request->get('notificada')) ? 'notificada' : 'noNotificada');

            $sanciones = $em->getRepository('AppBundle:Sancion')
                ->findAllNoNotificadosPorAlumno($id);

            foreach ($sanciones as $sancion) {
                $avisoSancion = new AvisoSancion();
                $avisoSancion
                    ->setSancion($sancion)
                    ->setUsuario($usuario)

It seems like $usuario defined by $this->getUser() on line 103 can also be of type object; however, AppBundle\Entity\Aviso::setUsuario() does only seem to accept null|object<AppBundle\Entity\Usuario>, maybe add an additional type check?

                    ->setAnotacion($request->request->get('anotacion'))
                    ->setFecha(new \DateTime())
                    ->setTipo($em->getRepository('AppBundle:CategoriaAviso')->find($request->request->get('tipo')));

                if ($request->request->get('notificada')) {
                    $sancion->setFechaComunicado(new \DateTime());
                }

                $em->persist($avisoSancion);
            }
            $em->flush();
        }

        $alumnos = ($this->isGranted('ROLE_REVISOR'))
            ? $em->getRepository('AppBundle:Alumno')->findAllConSancionesAunNoNotificadas()
            : $em->getRepository('AppBundle:Alumno')->findAllConSancionesAunNoNotificadasPorTutoria($usuario);

        if (count($alumnos) == 0) {
            // redireccionar a la portada
            return new RedirectResponse(
                $this->generateUrl('portada')
            );
        }
        return $this->render('AppBundle:Sancion:notificar.html.twig',
            array(
                'usuario' => $usuario,
                'alumnos' => $alumnos,
                'tipos' => $em->getRepository('AppBundle:CategoriaAviso')->findAll()
            ));
    }


    /**
     * @Route("/listar", name="sancion_listar",methods={"GET"})
     * @Security("has_role('ROLE_REVISOR')")
     */
    public function listarAction()
    {
        $usuario = $this->getUser();
        $em = $this->getDoctrine()->getManager();

        $sanciones = $em->getRepository('AppBundle:Sancion')
            ->createQueryBuilder('s')
            ->orderBy('s.fechaSancion', 'DESC')
            ->getQuery()
            ->getResult();

        return $this->render('AppBundle:Sancion:listar.html.twig',
            array(
                'sanciones' => $sanciones,
                'usuario' => $usuario
            ));
    }

    /**
     * @Route("/detalle/{sancion}", name="sancion_detalle",methods={"GET", "POST"})
     * @Security("has_role('ROLE_REVISOR')")
     */
    public function detalleAction(Sancion $sancion, Request $request)
    {
        $usuario = $this->getUser();
        $em = $this->getDoctrine()->getManager();

        $formularioSancion = $this->createForm(new SancionType(), $sancion, array(
            'admin' => true,
            'bloqueado' => false
        ));

        $formularioSancion->get('sinSancion')->setData($sancion->getMotivosNoAplicacion() !== null);
        
        $observacion = new ObservacionSancion();
        $observacion
            ->setSancion($sancion)
            ->setFecha(new \DateTime())
            ->setUsuario($usuario);

It seems like $usuario defined by $this->getUser() on line 178 can also be of type object; however, AppBundle\Entity\Observacion::setUsuario() does only seem to accept null|object<AppBundle\Entity\Usuario>, maybe add an additional type check?

        $formularioObservacion = $this->createForm(new NuevaObservacionType(), $observacion, array(
            'admin' => $this->isGranted('ROLE_ADMIN')
        ));

        $formularioObservacion->handleRequest($request);

        if ($formularioObservacion->isSubmitted() && $formularioObservacion->isValid()) {
            $em->persist($observacion);
            $em->flush();
            $this->addFlash('success', 'Observación registrada correctamente');
        }

        $formularioSancion->handleRequest($request);

        if ($formularioSancion->isSubmitted() && $formularioSancion->isValid()) {

            $em->flush();

            $this->addFlash('success', 'Se han registrado correctamente los cambios en la sanción');

            return new RedirectResponse(
                $this->generateUrl('sancion_listar')
            );
        }

        return $this->render('AppBundle:Sancion:detalle.html.twig',
            array(
                'sancion' => $sancion,
                'formulario_sancion' => $formularioSancion->createView(),
                'formulario_observacion' => $formularioObservacion->createView(),
                'usuario' => $usuario
            ));
    }


    /**
     * @Route("/informe", name="sancion_informe",methods={"GET", "POST"})
     * @Security("has_role('ROLE_REVISOR')")
     */
    public function informeAction(Request $request)
    {
        $usuario = $this->getUser();
        $em = $this->getDoctrine()->getManager();

        $fechasPorDefecto = array('desde' => null, 'hasta' => null);

        $formFechas = $this->createForm(new RangoFechasInformeType(), $fechasPorDefecto)
            ->handleRequest($request);

        $fechas = ($formFechas->isValid()) ? $formFechas->getData() : array('desde' => null, 'hasta' => null);

        $alumnado = $em->getRepository('AppBundle:Alumno')->getSancionadosPorFecha($fechas);

        if ($formFechas->isValid() && $formFechas->get('generar')->isClicked()) {

The method isClicked() does not seem to exist on object<Symfony\Component\Form\Form>.

            $plantilla = $this->container->getParameter('listado');
            $logos = $this->container->getParameter('logos');

            $pdf = $this->generarPdf('Informe de sanciones', $logos, $plantilla, -15);

            $html = $this->renderView('AppBundle:Sancion:imprimir_informe.html.twig',
                array(
                    'items' => $alumnado,
                    'fechas' => $fechas
                ));

            $pdf->writeHTML($html);

            $response = new Response($pdf->Output( 'Informe_de_sanciones_' . date('Y-m-d H-i-s') . '.pdf'));
            $response->headers->set('Content-Type', 'application/pdf');

            return $response;
        }

        return $this->render('AppBundle:Sancion:listar_informe.html.twig',
            array(
                'formulario_fechas' => $formFechas->createView(),
                'items' => $alumnado,
                'usuario' => $usuario
            ));
    }

     /**
     * @Route("/imprimir/{sancion}", name="sancion_detalle_pdf",methods={"GET"})
     * @Security("has_role('ROLE_REVISOR')")
     */
    public function detallePdfAction(Sancion $sancion)
    {
        $usuario = $this->getUser();
        $plantilla = $this->container->getParameter('sancion');
        $logos = $this->container->getParameter('logos');

        $pdf = $this->generarPdf('Sancion #' . $sancion->getId(), $logos, $plantilla, -15, 'S' . $sancion->getId());

        $html = $this->renderView('AppBundle:Sancion:imprimir.html.twig',
            array(
                'sancion' => $sancion,
                'usuario' => $usuario,
                'localidad' => $this->container->getParameter('localidad'),
                'director' => $this->container->getParameter('director')
            ));

        $pdf->writeHTML($html);

        $response = new Response($pdf->Output('sancion_' . $sancion->getId() . '.pdf'));
        $response->headers->set('Content-Type', 'application/pdf');

        return $response;
    }
}