OrganizationVoter::voteOnAttribute() - Code Metrics - iesoretania/atica-ng - Measure and Improve Code Quality continuously with Scrutinizer

OrganizationVoter::voteOnAttribute() C
last analyzed 2017-12-09 11:59 UTC

↳ Parent: OrganizationVoter

Complexity

Conditions	11
Paths	7

Size

Total Lines	39
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	39
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	16
nc	7
nop	3

How to fix Complexity

<?php
/*
  ÁTICA - Aplicación web para la gestión documental de centros educativos

  Copyright (C) 2015-2017: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Security;

use AppBundle\Entity\Membership;
use AppBundle\Entity\Organization;
use AppBundle\Entity\User;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;

class OrganizationVoter extends Voter
{
    const MANAGE = 'ORGANIZATION_MANAGE';
    const ACCESS = 'ORGANIZATION_ACCESS';

    private $decisionManager;

    public function __construct(AccessDecisionManagerInterface $decisionManager) {
        $this->decisionManager = $decisionManager;
    }

    /**
     * {@inheritdoc}
     */
    protected function supports($attribute, $subject)
    {

        if (!$subject instanceof Organization) {
            return false;
        }

        if (!in_array($attribute, [self::MANAGE, self::ACCESS], true)) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
    {
        if (!$subject instanceof Organization) {
            return false;
        }

        // los administradores globales siempre tienen permiso
        if ($this->decisionManager->decide($token, ['ROLE_ADMIN'])) {
            return true;
        }

        /** @var User $user */
        $user = $token->getUser();

        if (!$user instanceof User) {
            // si el usuario no ha entrado, denegar
            return false;
        }

        // Si es administrador de la organización, permitir siempre
        if ($user->getManagedOrganizations()->contains($subject)) {
            return true;
        }

        // Si es permiso de acceso, comprobar que pertenece actualmente a la organización
        if ($attribute === self::ACCESS) {

            $date = new \DateTime();
            /** @var Membership $membership */
            foreach ($user->getMemberships() as $membership) {
                if ($membership->getOrganization() == $subject && $membership->getValidFrom() <= $date && ($membership->getValidUntil() === null || $membership->getValidUntil() >= $date)) {
                    return true;
                }
            }
        }

        // denegamos en cualquier otro caso
        return false;
    }
}


1			<?php
2			/*
3			ÁTICA - Aplicación web para la gestión documental de centros educativos
4
5			Copyright (C) 2015-2017: Luis Ramón López López
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU Affero General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU Affero General Public License for more details.
16
17			You should have received a copy of the GNU Affero General Public License
18			along with this program. If not, see [http://www.gnu.org/licenses/].
19			*/
20
21			namespace AppBundle\Security;
22
23			use AppBundle\Entity\Membership;
24			use AppBundle\Entity\Organization;
25			use AppBundle\Entity\User;
26			use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
27			use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
28			use Symfony\Component\Security\Core\Authorization\Voter\Voter;
29
30			class OrganizationVoter extends Voter
31			{
32			const MANAGE = 'ORGANIZATION_MANAGE';
33			const ACCESS = 'ORGANIZATION_ACCESS';
34
35			private $decisionManager;
36
37			public function __construct(AccessDecisionManagerInterface $decisionManager) {
38			$this->decisionManager = $decisionManager;
39			}
40
41			/**
42			* {@inheritdoc}
43			*/
44			protected function supports($attribute, $subject)
45			{
46
47			if (!$subject instanceof Organization) {
48			return false;
49			}
50
51			if (!in_array($attribute, [self::MANAGE, self::ACCESS], true)) {
52			return false;
53			}
54
55			return true;
56			}
57
58			/**
59			* {@inheritdoc}
60			*/
61			protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
62			{
63			if (!$subject instanceof Organization) {
64			return false;
65			}
66
67			// los administradores globales siempre tienen permiso
68			if ($this->decisionManager->decide($token, ['ROLE_ADMIN'])) {
69			return true;
70			}
71
72			/** @var User $user */
73			$user = $token->getUser();
74
75			if (!$user instanceof User) {
76			// si el usuario no ha entrado, denegar
77			return false;
78			}
79
80			// Si es administrador de la organización, permitir siempre
81			if ($user->getManagedOrganizations()->contains($subject)) {
82			return true;
83			}
84
85			// Si es permiso de acceso, comprobar que pertenece actualmente a la organización
86			if ($attribute === self::ACCESS) {
87
88			$date = new \DateTime();
89			/** @var Membership $membership */
90			foreach ($user->getMemberships() as $membership) {
91			if ($membership->getOrganization() == $subject && $membership->getValidFrom() <= $date && ($membership->getValidUntil() === null \|\| $membership->getValidUntil() >= $date)) {
92			return true;
93			}
94			}
95			}
96
97			// denegamos en cualquier otro caso
98			return false;
99			}
100			}
101

iesoretania / atica-ng

OrganizationVoter::voteOnAttribute() C last analyzed 2017-12-09 11:59 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

OrganizationVoter::voteOnAttribute() C
last analyzed 2017-12-09 11:59 UTC