AppBundle\Controller\Organization\Import\TeacherController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	160
Duplicated Lines	22.5 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	indexAction()	36	36	4
F	importTeachersFromCsv()	0	111	14

<?php
/*
  ÁTICA - Aplicación web para la gestión documental de centros educativos

  Copyright (C) 2015-2017: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Controller\Organization\Import;

use AppBundle\Entity\Membership;
use AppBundle\Entity\Organization;
use AppBundle\Entity\User;
use AppBundle\Form\Model\TeacherImport;
use AppBundle\Form\Type\Import\TeacherType;
use AppBundle\Security\OrganizationVoter;
use AppBundle\Utils\CsvImporter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Config\Definition\Exception\Exception;
use Symfony\Component\HttpFoundation\Request;

class TeacherController extends Controller
{
    /**
     * @Route("/centro/importar/profesorado", name="organization_import_teacher_form", methods={"GET", "POST"})
     */
    public function indexAction(Request $request)

This method seems to be duplicated in your project.

    {
        $organization = $this->get('AppBundle\Service\UserExtensionService')->getCurrentOrganization();
        $this->denyAccessUnlessGranted(OrganizationVoter::MANAGE, $organization);

        $formData = new TeacherImport();
        $form = $this->createForm(TeacherType::class, $formData);
        $form->handleRequest($request);

        $stats = null;
        $breadcrumb = [];

        if ($form->isSubmitted() && $form->isValid()) {

            $stats = $this->importTeachersFromCsv($formData->getFile()->getPathname(), $organization, [
                'generate_password' => $formData->getGeneratePassword(),
                'external_check' => $formData->isExternalPassword()
            ]);

            if (null !== $stats) {
                $this->addFlash('success', $this->get('translator')->trans('message.import_ok', [], 'import'));
                $breadcrumb[] = ['fixed' => $this->get('translator')->trans('title.import_result', [], 'import')];
            } else {
                $this->addFlash('error', $this->get('translator')->trans('message.import_error', [], 'import'));
            }
        }
        $title = $this->get('translator')->trans('title.teacher_import', [], 'import');

        return $this->render('admin/organization/import/teacher_form.html.twig', [
            'title' => $title,
            'breadcrumb' => $breadcrumb,
            'form' => $form->createView(),
            'generate_password' => $formData->getGeneratePassword(),
            'stats' => $stats
        ]);
    }

    /**
     * @param string $file
     * @param Organization $organization
     * @param array $options
     * @return array|null
     */
    private function importTeachersFromCsv($file, Organization $organization, $options = [])
    {
        $generatePassword = isset($options['generate_password']) && $options['generate_password'];
        $external = isset($options['external_check']) && $options['external_check'];
        $newUserCount = 0;
        $newMemberships = 0;
        $existingUsers = 0;
        $existingMemberships = 0;

        $em = $this->getDoctrine()->getManager();

        $importer = new CsvImporter($file, true);
        $encoder = $this->container->get('security.password_encoder');

        $userCollection = [];
        $newUserCollection = [];

        try {
            while ($data = $importer->get(100)) {
                foreach ($data as $userData) {
                    if (!isset($userData['Usuario IdEA'])) {
                        return null;
                    }
                    $userName = $userData['Usuario IdEA'];

                    $user = $em->getRepository('AppBundle:User')->findOneBy(['loginUsername' => $userName]);
                    $alreadyProcessed = isset($userCollection[$userName]);

                    if (null === $user) {
                        if ($alreadyProcessed) {
                            $user = $userCollection[$userName];
                        } else {
                            $user = new User();
                            $fullName = explode(', ', $userData['Empleado/a']);

                            $user
                                ->setLoginUsername($userName)
                                ->setFirstName($fullName[1])
                                ->setLastName($fullName[0])
                                ->setInternalCode($userData['Empleado/a'])
                                ->setEnabled(true)
                                ->setGlobalAdministrator(false)
                                ->setGender(User::GENDER_NEUTRAL)
                                ->setAllowExternalCheck($external)
                                ->setExternalCheck($external);

                            if ($generatePassword) {
                                $user
                                    ->setPassword($encoder->encodePassword($user, $userData['Usuario IdEA']));
                            }

                            $em->persist($user);

                            $userCollection[$userName] = $user;
                            $newUserCollection[$userName] = $user;

                            $newUserCount++;
                        }
                    } else {
                        if (!$alreadyProcessed) {
                            $existingUsers++;
                            $userCollection[$userName] = $user;
                        }
                    }

                    $validFrom = \DateTime::createFromFormat('d/m/Y H:i:s', $userData['Fecha de toma de posesión'].'00:00:00');
                    $validUntil = ($userData['Fecha de cese']) ? \DateTime::createFromFormat('d/m/Y H:i:s', $userData['Fecha de cese'].'23:59:59') : null;

                    if (false === $validFrom) {
                        continue;
                    }

                    /** @var Membership $membership */
                    $membership = $em->getRepository('AppBundle:Membership')->findOneBy([
                        'organization' => $organization,
                        'user' => $user,
                        'validFrom' => $validFrom
                    ]);

                    if (null === $membership) {
                        $membership = new Membership();
                        $membership
                            ->setOrganization($organization)
                            ->setUser($user)
                            ->setValidFrom($validFrom)
                            ->setValidUntil($validUntil);

                        $em->persist($membership);

                        $newMemberships++;
                    } else {
                        $membership
                            ->setValidUntil($validUntil);

                        $existingMemberships++;
                    }
                }
            }
            $em->flush();
        } catch (Exception $e) {
            return null;
        }

        return [
            'new_user_count' => $newUserCount,
            'new_membership_count' => $newMemberships,
            'existing_user_count' => $existingUsers,
            'existing_membership_count' => $existingMemberships,
            'user_collection' => $newUserCollection
        ];
    }
}