AppBundle\Security\AgreementVoter

Complexity

Total Complexity

13

Size/Duplication

Total Lines	67
Duplicated Lines	19.4 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	supports()	13	13	3
D	voteOnAttribute()	0	35	9

<?php
/*
  ÁTICA - Aplicación web para la gestión documental de centros educativos

  Copyright (C) 2015-2016: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Security;

use AppBundle\Entity\Agreement;
use AppBundle\Entity\User;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;

class AgreementVoter extends Voter
{
    const MANAGE = 'AGREEMENT_MANAGE';
    const ACCESS = 'AGREEMENT_ACCESS';

    private $decisionManager;

    public function __construct(AccessDecisionManagerInterface $decisionManager) {
        $this->decisionManager = $decisionManager;
    }

    /**
     * {@inheritdoc}
     */
    protected function supports($attribute, $subject)

This method seems to be duplicated in your project.

    {

        if (!$subject instanceof Agreement) {
            return false;
        }

        if (!in_array($attribute, [self::MANAGE, self::ACCESS], true)) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
    {
        if (!$subject instanceof Agreement) {
            return false;
        }
        // los administradores globales siempre tienen permiso
        if ($this->decisionManager->decide($token, ['ROLE_ADMIN'])) {
            return true;
        }

        /** @var User $user */
        $user = $token->getUser();

        if (!$user instanceof User) {
            // si el usuario no ha entrado, denegar
            return false;
        }

        // Si es el jefe de departamento, permitir
        if ($user->getDirects()->contains($subject->getTraining()->getDepartment())) {

The method getTraining() does not seem to exist on object<AppBundle\Entity\Agreement>.

            return true;
        }

        // Si es el propio estudiante, tutor de grupo, tutor docente o tutor loboral, sólo acceso de lectura
        if ($subject->getStudent() == $user
            || $user->getTutorizedGroups()->contains($subject)
            || $subject->getEducationalTutor() == $user
            || $subject->getWorkTutor() == $user) {

            return $attribute == self::ACCESS;
        }

        // denegamos en cualquier otro caso
        return false;
    }
}