SecurityController::passwordResetRequestAction() - Code Metrics - iesoretania/atica-fct - Measure and Improve Code Quality continuously with Scrutinizer

SecurityController::passwordResetRequestAction() C
last analyzed 2018-12-05 08:49 UTC

↳ Parent: SecurityController

Complexity

Conditions	10
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	83
rs	6.5042
c	0
b	0
f	0
cc	10
nc	6
nop	1

How to fix Long Method Complexity

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\User;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

class SecurityController extends Controller
{
    /**
     * @Route("/entrar", name="login", methods={"GET"})
     */
    public function loginAction()
    {
        $authenticationUtils = $this->get('security.authentication_utils');

        // obtener el error de entrada, si existe alguno
        $error = $authenticationUtils->getLastAuthenticationError();

        // último nombre de usuario introducido
        $lastUsername = $authenticationUtils->getLastUsername();

        return $this->render(
            'security/login.html.twig',
            array(
                'last_username' => $lastUsername,
                'login_error' => $error,
            )
        );
    }

    /**
     * @Route("/restablecer", name="login_password_reset", methods={"GET", "POST"})
     */
    public function passwordResetRequestAction(Request $request)
    {

        $data = [
            'email' => ''
        ];

        $form = $this->createForm('AppBundle\Form\Type\PasswordResetType', $data);

        $form->handleRequest($request);

        $data = $form->getData();
        $email = $data['email'];
        $error = '';

        // ¿se ha enviado una dirección?
        if ($form->isSubmitted() && $form->isValid()) {

            // comprobar que está asociada a un usuario
            $user = $this->getDoctrine()->getManager()->getRepository('AppBundle:User')->findOneBy(['email' => $email]);

            if (null === $user) {
                $error = $this->get('translator')->trans('form.reset.notfound', [], 'security');
            } else {
                // almacenar como último correo electrónico el indicado
                $this->get('session')->set('_security.last_username', $email);

                // obtener tiempo de expiración del token
                $expire = (int) $this->getParameter('password_reset.expire');

                if ($this->getParameter('external.enabled') && $user->getAllowExternalLogin() && $user->hasExternalLogin()) {
                    $this->addFlash('error', $this->get('translator')->trans('form.reset.external_login.error', [], 'security'));
                } else {
                    // comprobar que no se ha generado un token hace poco
                    if ($user->getToken() && $user->getTokenValidity() > new \DateTime()) {
                        $error = $this->get('translator')->trans('form.reset.wait', ['%expiry%' => $expire], 'security');
                    } else {
                        // generar un nuevo token
                        $token = bin2hex(random_bytes(16));
                        $user->setToken($token);

                        // calcular fecha de expiración del token
                        $validity = new \DateTime();
                        $validity->add(new \DateInterval('PT' . $expire . 'M'));
                        $user->setTokenValidity($validity);

                        // enviar correo
                        if (0 === $this->get('app.mailer')->sendEmail([$user],
                                ['id' => 'form.reset.email.subject', 'parameters' => []],
                                [
                                    'id' => 'form.reset.email.body',
                                    'parameters' => [
                                        '%name%' => $user->getFirstName(),
                                        '%link%' => $this->generateUrl('login_password_reset_do',
                                            ['userId' => $user->getId(), 'token' => $token],
                                            UrlGeneratorInterface::ABSOLUTE_URL),
                                        '%expiry%' => $expire
                                    ]
                                ], 'security')
                        ) {
                            $this->addFlash('error', $this->get('translator')->trans('form.reset.error', [], 'security'));
                        } else {

                            // guardar token
                            $this->get('doctrine')->getManager()->flush();

                            $this->addFlash('success',
                                $this->get('translator')->trans('form.reset.sent', ['%email%' => $email], 'security'));
                            return $this->redirectToRoute('login');
                        }
                    }
                }
            }
        }

        return $this->render(
            ':security:login_password_reset.html.twig', [
                'last_username' => $this->get('session')->get('_security.last_username', ''),
                'form' => $form->createView(),
                'error' => $error
            ]
        );
    }

    /**
     * @Route("/restablecer/{userId}/{token}", name="login_password_reset_do", methods={"GET", "POST"})
     */
    public function passwordResetAction(Request $request, $userId, $token)
    {
        /**
         * @var User|null
         */
        $user = $this->getDoctrine()->getManager()->getRepository('AppBundle:User')->findOneBy([
            'id' => $userId,
            'token' => $token
        ]);

        if (null === $user || ($user->getTokenValidity() < new \DateTime())) {
            $this->addFlash('error', $this->get('translator')->trans('form.reset.notvalid', [], 'security'));
            return $this->redirectToRoute('login');
        }

        $data = [
            'password' => '',
            'repeat' => ''
        ];

        $form = $this->createForm('AppBundle\Form\Type\NewPasswordType', $data);

        $form->handleRequest($request);

        $error = '';
        if ($form->isSubmitted() && $form->isValid()) {

            //codificar la nueva contraseña y asignarla al usuario
            $password = $this->container->get('security.password_encoder')
                ->encodePassword($user, $form->get('newPassword')->get('first')->getData());
            $user->setPassword($password)->setToken(null)->setTokenValidity(null);
            $this->getDoctrine()->getManager()->flush();

            // indicar que los cambios se han realizado con éxito y volver a la página de inicio
            $message = $this->get('translator')->trans('form.reset.message', [], 'security');
            $this->addFlash('success', $message);
            return new RedirectResponse(
                $this->generateUrl('frontpage')
            );
        }

        return $this->render(
            ':security:login_password_new.html.twig', [
                'user' => $user,
                'form' => $form->createView(),
                'error' => $error
            ]
        );
    }

    /**
     * @Route("/comprobar", name="login_check", methods={"POST"})
     * @Route("/salir", name="logout", methods={"GET"})
     */
    public function logInOutCheckAction()
    {
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use AppBundle\Entity\User;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\HttpFoundation\RedirectResponse;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
11
12			class SecurityController extends Controller
13			{
14			/**
15			* @Route("/entrar", name="login", methods={"GET"})
16			*/
17			public function loginAction()
18			{
19			$authenticationUtils = $this->get('security.authentication_utils');
20
21			// obtener el error de entrada, si existe alguno
22			$error = $authenticationUtils->getLastAuthenticationError();
23
24			// último nombre de usuario introducido
25			$lastUsername = $authenticationUtils->getLastUsername();
26
27			return $this->render(
28			'security/login.html.twig',
29			array(
30			'last_username' => $lastUsername,
31			'login_error' => $error,
32			)
33			);
34			}
35
36			/**
37			* @Route("/restablecer", name="login_password_reset", methods={"GET", "POST"})
38			*/
39			public function passwordResetRequestAction(Request $request)
40			{
41
42			$data = [
43			'email' => ''
44			];
45
46			$form = $this->createForm('AppBundle\Form\Type\PasswordResetType', $data);
47
48			$form->handleRequest($request);
49
50			$data = $form->getData();
51			$email = $data['email'];
52			$error = '';
53
54			// ¿se ha enviado una dirección?
55			if ($form->isSubmitted() && $form->isValid()) {
56
57			// comprobar que está asociada a un usuario
58			$user = $this->getDoctrine()->getManager()->getRepository('AppBundle:User')->findOneBy(['email' => $email]);
59
60			if (null === $user) {
61			$error = $this->get('translator')->trans('form.reset.notfound', [], 'security');
62			} else {
63			// almacenar como último correo electrónico el indicado
64			$this->get('session')->set('_security.last_username', $email);
65
66			// obtener tiempo de expiración del token
67			$expire = (int) $this->getParameter('password_reset.expire');
68
69			if ($this->getParameter('external.enabled') && $user->getAllowExternalLogin() && $user->hasExternalLogin()) {
70			$this->addFlash('error', $this->get('translator')->trans('form.reset.external_login.error', [], 'security'));
71			} else {
72			// comprobar que no se ha generado un token hace poco
73			if ($user->getToken() && $user->getTokenValidity() > new \DateTime()) {
74			$error = $this->get('translator')->trans('form.reset.wait', ['%expiry%' => $expire], 'security');
75			} else {
76			// generar un nuevo token
77			$token = bin2hex(random_bytes(16));
78			$user->setToken($token);
79
80			// calcular fecha de expiración del token
81			$validity = new \DateTime();
82			$validity->add(new \DateInterval('PT' . $expire . 'M'));
83			$user->setTokenValidity($validity);
84
85			// enviar correo
86			if (0 === $this->get('app.mailer')->sendEmail([$user],
87			['id' => 'form.reset.email.subject', 'parameters' => []],
88			[
89			'id' => 'form.reset.email.body',
90			'parameters' => [
91			'%name%' => $user->getFirstName(),
92			'%link%' => $this->generateUrl('login_password_reset_do',
93			['userId' => $user->getId(), 'token' => $token],
94			UrlGeneratorInterface::ABSOLUTE_URL),
95			'%expiry%' => $expire
96			]
97			], 'security')
98			) {
99			$this->addFlash('error', $this->get('translator')->trans('form.reset.error', [], 'security'));
100			} else {
101
102			// guardar token
103			$this->get('doctrine')->getManager()->flush();
104
105			$this->addFlash('success',
106			$this->get('translator')->trans('form.reset.sent', ['%email%' => $email], 'security'));
107			return $this->redirectToRoute('login');
108			}
109			}
110			}
111			}
112			}
113
114			return $this->render(
115			':security:login_password_reset.html.twig', [
116			'last_username' => $this->get('session')->get('_security.last_username', ''),
117			'form' => $form->createView(),
118			'error' => $error
119			]
120			);
121			}
122
123			/**
124			* @Route("/restablecer/{userId}/{token}", name="login_password_reset_do", methods={"GET", "POST"})
125			*/
126			public function passwordResetAction(Request $request, $userId, $token)
127			{
128			/**
129			* @var User\|null
130			*/
131			$user = $this->getDoctrine()->getManager()->getRepository('AppBundle:User')->findOneBy([
132			'id' => $userId,
133			'token' => $token
134			]);
135
136			if (null === $user \|\| ($user->getTokenValidity() < new \DateTime())) {
137			$this->addFlash('error', $this->get('translator')->trans('form.reset.notvalid', [], 'security'));
138			return $this->redirectToRoute('login');
139			}
140
141			$data = [
142			'password' => '',
143			'repeat' => ''
144			];
145
146			$form = $this->createForm('AppBundle\Form\Type\NewPasswordType', $data);
147
148			$form->handleRequest($request);
149
150			$error = '';
151			if ($form->isSubmitted() && $form->isValid()) {
152
153			//codificar la nueva contraseña y asignarla al usuario
154			$password = $this->container->get('security.password_encoder')
155			->encodePassword($user, $form->get('newPassword')->get('first')->getData());
156			$user->setPassword($password)->setToken(null)->setTokenValidity(null);
157			$this->getDoctrine()->getManager()->flush();
158
159			// indicar que los cambios se han realizado con éxito y volver a la página de inicio
160			$message = $this->get('translator')->trans('form.reset.message', [], 'security');
161			$this->addFlash('success', $message);
162			return new RedirectResponse(
163			$this->generateUrl('frontpage')
164			);
165			}
166
167			return $this->render(
168			':security:login_password_new.html.twig', [
169			'user' => $user,
170			'form' => $form->createView(),
171			'error' => $error
172			]
173			);
174			}
175
176			/**
177			* @Route("/comprobar", name="login_check", methods={"POST"})
178			* @Route("/salir", name="logout", methods={"GET"})
179			*/
180			public function logInOutCheckAction()
181			{
182			}
183			}
184

iesoretania / atica-fct

GitHub Access Token became invalid

SecurityController::passwordResetRequestAction() C last analyzed 2018-12-05 08:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

SecurityController::passwordResetRequestAction() C
last analyzed 2018-12-05 08:49 UTC