App\Http\Controllers\ApiDepartmentsController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	135
Duplicated Lines	16.3 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	22	2
A	show()	0	15	2
A	store()	11	11	1
A	update()	11	11	1
A	destroy()	0	15	2

<?php

namespace App\Http\Controllers;

use App\Departments;
use App\Http\Requests;
use League\Fractal\Manager;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use League\Fractal\Pagination\Cursor;
use App\Http\TransformersApi\DepartmentOutput;
use League\Fractal\Resource\Collection;
use League\Fractal\Resource\Item;

/**
 * Class ApiDepartmentsController
 * @package App\Http\Controllers
 */
class ApiDepartmentsController extends Controller
{
    private $transformer;
    private $fractal;

    /**
     * ApiDepartmentsController constructor.
     */
    public function __construct()
    {
        $this->transformer = new DepartmentOutput();
        $this->fractal     = new Manager();
    }

    /**
     * Display a listing of the resource.
     *
     * @TODO   Needs test
     * @TODO   Needs documentation
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $currentCursor  = $request->get('cursor', null);
        $previousCursor = $request->get('previous', null);
        $limit          = $request->get('limit', 10);

        if ($currentCursor) {
            $departments = Departments::with('managers')->where('id', '>', $currentCursor)->take($limit)->get();
        } else {
            $departments = Departments::with('managers')->take($limit)->get();
        }

        $newCursor = $departments->last()->id;
        $cursor    = new Cursor($currentCursor, $previousCursor, $newCursor, $departments->count());
        $resource  = new Collection($departments, $this->transformer);

        $resource->setCursor($cursor);
        $outputBody = $this->fractal->createData($resource)->toJson();

        return response($outputBody, 200)

The method header() does not exist on Symfony\Component\HttpFoundation\Response. Did you maybe mean sendHeaders()?

            ->header('Content-Type', 'application/json');
    }

    /**
     * Display the specified resource.
     *
     * @TODO   needs tests
     * @TODO   needs documentation
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $departments = Departments::find($id);

        if (count($departments) > 0) {
            $resource = new Item($departments, $this->transformer);
            $outputBody = $this->fractal->createData($resource)->toJson();
        } else {
            $outputBody = [];
            $outputBody['message'] = 'Could not found a department with that ID.';
        }

        return response($outputBody, 200)

It seems like $outputBody defined by array() on line 80 can also be of type array<string,string,{"message":"string"}>; however, response() does only seem to accept string, maybe add an additional type check?

The method header() does not exist on Symfony\Component\HttpFoundation\Response. Did you maybe mean sendHeaders()?

            ->header('Content-Type', 'application/json');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @TODO   needs test
     * @TODO   Needs documentation
     * @param  Requests\DepartmentsValidator $input the input bag from the request.
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\DepartmentsValidator $input)

This method seems to be duplicated in your project.

    {
        Departments::create($input->all());

        $output = [];
        $output['message'] = 'Department created';
        $output['data']    = $input->all();

        return response($output, 201)

$output is of type array<string,string|array,{"data":"array"}>, but the function expects a string.

The method header() does not exist on Symfony\Component\HttpFoundation\Response. Did you maybe mean sendHeaders()?

            ->header('Content-Type', 'application/json');
    }

    /**
     * Update the specified resource in storage.
     *
     * @TODO   Needs documentation
     * @TODO   Needs tests
     * @param  Requests\DepartmentsValidator $input the input bag from the request.
     * @param  \Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Requests\DepartmentsValidator $input, Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        Departments::find($id)->update($input->all());

        $output = [];
        $output['message']  = 'Department updated';
        $output['new_data'] = $input->all();

        return response($output, 200)

$output is of type array<string,string|array,{"new_data":"array"}>, but the function expects a string.

The method header() does not exist on Symfony\Component\HttpFoundation\Response. Did you maybe mean sendHeaders()?

            ->header('Content-Type', 'application/json');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @TODO   need tests
     * #TODO   needs documentation
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if (! empty($id)) {
            Departments::destroy($id);

            $data = [];
            $data['message'] = 'Department deleted';
        } else {
            $data = [];
            $data['message'] = 'Could not delete the department';
        }

        return response($data, 200)

$data is of type array<string,string,{"message":"string"}>, but the function expects a string.

The method header() does not exist on Symfony\Component\HttpFoundation\Response. Did you maybe mean sendHeaders()?

            ->header('Content-Type', 'application/json');
    }
}