DepartmentsController::search() - Code Metrics - Inspection of "Update master" - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#107)

by Tim

created 2016-05-04 09:18 UTC

DepartmentsController::search() A

↳ Parent: DepartmentsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	15
rs	9.4285
cc	2
eloc	9
nc	2
nop	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Departments;
use App\DepartmentMembers;
use Mail;
use App\User;
use App\Http\Controllers\Controller;

class DepartmentsController extends Controller
{
    /**
     * DepartmentsController Constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Get the departments index.
     *
     * @return view
     */ 
    public function index()
    {
        $departments = Departments::orderBy('department_name', 'asc')->with('managers')->paginate(10);
        return view('departments/list', ['departments' => $departments]);
    }

    /**
     * This is nothing for in the controller.
     * If you want to test this. You should create a phpunit function for the relation.$_COOKIE
     * 
     * TODO: Create phpunit testing function.
     */
    public function relationtest()
    {
        $departments = DepartmentMembers::All();
        return $departments;
    }    

    public function create()
    {
        $managers = User::all();
        return view('departments/create', ['managers' => $managers]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Requests\DepartmentsValidator|Request $request
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\DepartmentsValidator $request)
    {
        // TODO: Check for mass assign - SQL queries.
        
        $departments = new Departments;
        $departments->department_name = $request->get('department_name');
        $departments->department_manager = $request->get('department_manager');
        $departments->department_description = $request->get('department_description');
        $departments->save();

        $department_id = $departments->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $manager = new DepartmentMembers;
        $manager->departmentid = $department_id;
        $manager->userid = $request->get('department_manager');
        $manager->save();

         \Session::flash('message', "New department has been saved");
        return redirect('staff/departments');
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

    {
        return view('departments/edit');
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

    {
        //
    }

    /**
     * Search a department in the database.
     *
     * @param Request $request
     * @return \Illuminate\Http\Response
     */
    public function search(Request $request)
    {
        $term = $request->get('name');

        if (empty($term)) {
            return redirect('staff/departments', 302);
        }

        $data['departments'] = Departments::where('department_name', 'LIKE', "%$term%")
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            ->orderBy('department_name', 'asc')
            ->with('managers')
            ->paginate(10);

        return view('departments/list', $data);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  Request $request
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request)
    {
        $query = Departments::destroy($request->get('department_id'));
        session()->flash('message', "$query department(s) deleted");

        return redirect()->back(302);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Http\Requests;
7			use App\Departments;
8			use App\DepartmentMembers;
9			use Mail;
10			use App\User;
11			use App\Http\Controllers\Controller;
12
13			class DepartmentsController extends Controller
14			{
15			/**
16			* DepartmentsController Constructor.
17			*/
18			public function __construct()
19			{
20			$this->middleware('auth');
21			$this->middleware('lang');
22			}
23
24			/**
25			* Get the departments index.
26			*
27			* @return view
28			*/
29			public function index()
30			{
31			$departments = Departments::orderBy('department_name', 'asc')->with('managers')->paginate(10);
32			return view('departments/list', ['departments' => $departments]);
33			}
34
35			/**
36			* This is nothing for in the controller.
37			* If you want to test this. You should create a phpunit function for the relation.$_COOKIE
38			*
39			* TODO: Create phpunit testing function.
40			*/
41			public function relationtest()
42			{
43			$departments = DepartmentMembers::All();
44			return $departments;
45			}
46
47			public function create()
48			{
49			$managers = User::all();
50			return view('departments/create', ['managers' => $managers]);
51			}
52
53			/**
54			* Store a newly created resource in storage.
55			*
56			* @param Requests\DepartmentsValidator\|Request $request
57			* @return \Illuminate\Http\Response
58			*/
59			public function store(Requests\DepartmentsValidator $request)
60			{
61			// TODO: Check for mass assign - SQL queries.
62
63			$departments = new Departments;
64			$departments->department_name = $request->get('department_name');
65			$departments->department_manager = $request->get('department_manager');
66			$departments->department_description = $request->get('department_description');
67			$departments->save();
68
69			$department_id = $departments->id;
			0 ignored issues – show Documentation introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Departments>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
70
71			$manager = new DepartmentMembers;
72			$manager->departmentid = $department_id;
73			$manager->userid = $request->get('department_manager');
74			$manager->save();
75
76			\Session::flash('message', "New department has been saved");
77			return redirect('staff/departments');
78			}
79
80			/**
81			* Display the specified resource.
82			*
83			* @param int $id
84			* @return \Illuminate\Http\Response
85			*/
86			public function show($id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
87			{
88			//
89			}
90
91			/**
92			* Show the form for editing the specified resource.
93			*
94			* @param int $id
95			* @return \Illuminate\Http\Response
96			*/
97			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
98			{
99			return view('departments/edit');
100			}
101
102			/**
103			* Update the specified resource in storage.
104			*
105			* @param \Illuminate\Http\Request $request
106			* @param int $id
107			* @return \Illuminate\Http\Response
108			*/
109			public function update(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
110			{
111			//
112			}
113
114			/**
115			* Search a department in the database.
116			*
117			* @param Request $request
118			* @return \Illuminate\Http\Response
119			*/
120			public function search(Request $request)
121			{
122			$term = $request->get('name');
123
124			if (empty($term)) {
125			return redirect('staff/departments', 302);
126			}
127
128			$data['departments'] = Departments::where('department_name', 'LIKE', "%$term%")
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-03 10:05 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
129			->orderBy('department_name', 'asc')
130			->with('managers')
131			->paginate(10);
132
133			return view('departments/list', $data);
134			}
135
136			/**
137			* Remove the specified resource from storage.
138			*
139			* @param Request $request
140			* @return \Illuminate\Http\Response
141			*/
142			public function destroy(Request $request)
143			{
144			$query = Departments::destroy($request->get('department_id'));
145			session()->flash('message', "$query department(s) deleted");
146
147			return redirect()->back(302);
148			}
149			}
150

idevelopment / timecontrol

Pull Request — master (#107)

DepartmentsController::search() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like