App\Http\Controllers\TypesController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	5
Bugs	1	Features	4

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	5	1
A	create()	0	4	1
A	store()	0	9	1
A	show()	0	4	1
A	edit()	0	4	1
A	update()	0	4	1
A	destroy()	0	8	1

<?php

namespace App\Http\Controllers;

use App\Tasks;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;

class TypesController extends Controller
{
    /**
     * TypesController constructor.
     */ 
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data['tasks'] = Tasks::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('tasks.manage_types', $data);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Requests\taskValidator|Request $request
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\taskValidator $request)
    {
        // Input: name
        // Input: Priority.
        Tasks::create($request->except('_token'));

        session()->flash('message', 'The task is successfully added.');
        return redirect()->back();
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $tasks = Tasks::find($id);
        $tasks->delete();
        session()->flash('message', 'The task is successfully deleted');

        return redirect()->back();
    }
}