TypesController::edit() - Code Metrics - Inspection of "Update master" - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#107)

by Glenn

created 2016-04-29 04:46 UTC

TypesController::edit() A

↳ Parent: TypesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	1
nc	1
nop	1

<?php

namespace App\Http\Controllers;

use App\Tasks;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;

class TypesController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data['tasks'] = Tasks::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('tasks.manage_types', $data);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Requests\taskValidator|Request $request
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\taskValidator $request)
    {
        // Input: name
        // Input: Priority.
        Tasks::create($request->except('_token'));

        session()->flash('message', 'The task is successfully added.');
        return redirect()->back();
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $id)

    {
        $tasks = Tasks::find($id);
        $tasks->delete();
        session()->flash('message', 'The task is successfully deleted');

        return redirect()->back();
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Tasks;
6			use Illuminate\Http\Request;
7
8			use App\Http\Requests;
9			use App\Http\Controllers\Controller;
10
11			class TypesController extends Controller
12			{
13			/**
14			* Display a listing of the resource.
15			*
16			* @return \Illuminate\Http\Response
17			*/
18			public function index()
19			{
20			$data['tasks'] = Tasks::all();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-30 23:42 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
21			return view('tasks.manage_types', $data);
22			}
23
24			/**
25			* Show the form for creating a new resource.
26			*
27			* @return \Illuminate\Http\Response
28			*/
29			public function create()
30			{
31			//
32			}
33
34			/**
35			* Store a newly created resource in storage.
36			*
37			* @param Requests\taskValidator\|Request $request
38			* @return \Illuminate\Http\Response
39			*/
40			public function store(Requests\taskValidator $request)
41			{
42			// Input: name
43			// Input: Priority.
44			Tasks::create($request->except('_token'));
45
46			session()->flash('message', 'The task is successfully added.');
47			return redirect()->back();
48			}
49
50			/**
51			* Display the specified resource.
52			*
53			* @param int $id
54			* @return \Illuminate\Http\Response
55			*/
56			public function show($id)
			0 ignored issues – show Unused Code introduced 2016-03-30 23:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57			{
58			//
59			}
60
61			/**
62			* Show the form for editing the specified resource.
63			*
64			* @param int $id
65			* @return \Illuminate\Http\Response
66			*/
67			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-03-30 23:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
68			{
69			//
70			}
71
72			/**
73			* Update the specified resource in storage.
74			*
75			* @param \Illuminate\Http\Request $request
76			* @param int $id
77			* @return \Illuminate\Http\Response
78			*/
79			public function update(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-03-30 23:42 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-30 23:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
80			{
81			//
82			}
83
84			/**
85			* Remove the specified resource from storage.
86			*
87			* @param int $id
88			* @return \Illuminate\Http\Response
89			*/
90			public function destroy(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-03-31 03:45 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
91			{
92			$tasks = Tasks::find($id);
93			$tasks->delete();
94			session()->flash('message', 'The task is successfully deleted');
95
96			return redirect()->back();
97			}
98			}
99

idevelopment / timecontrol

Pull Request — master (#107)

TypesController::edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like