TaskController::create() - Code Metrics - Inspection of "Update master" - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#107)

by Glenn

created 2016-05-08 00:02 UTC

TaskController::create() A

↳ Parent: TaskController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

namespace App\Http\Controllers;

use App\TasksRequest;
use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;

use App\User;
use App\Tasks;

class TaskController extends Controller
{
    /**
     * TaskController constructor.
     */ 
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data['tasks'] = TasksRequest::paginate(15);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view("tasks.manage_tasks", $data);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $data['users'] = User::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $data['tasks'] = Tasks::all();

        return view("tasks.request_task", $data);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Requests\taskRequestValidator $request
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\taskRequestValidator $request)

    {
       //
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id, The id off the task in the database.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        // 
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id The id off the task in the database.
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Requests\taskValidator $request
     * @param  int $id, the task request id.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Requests\taskValidator $request, $id)

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Request $request
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request)
    {
        TasksRequest::destroy($request->get('integer'));
        session()->flash('message', trans('FlashSession.tasksDestroy'));

        return redirect()->back();
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\TasksRequest;
6			use Illuminate\Http\Request;
7			use App\Http\Requests;
8			use App\Http\Controllers\Controller;
9
10			use App\User;
11			use App\Tasks;
12
13			class TaskController extends Controller
14			{
15			/**
16			* TaskController constructor.
17			*/
18			public function __construct()
19			{
20			$this->middleware('auth');
21			$this->middleware('lang');
22			}
23
24			/**
25			* Display a listing of the resource.
26			*
27			* @return \Illuminate\Http\Response
28			*/
29			public function index()
30			{
31			$data['tasks'] = TasksRequest::paginate(15);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-06 10:25 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
32			return view("tasks.manage_tasks", $data);
33			}
34
35			/**
36			* Show the form for creating a new resource.
37			*
38			* @return \Illuminate\Http\Response
39			*/
40			public function create()
41			{
42			$data['users'] = User::all();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-07 14:37 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
43			$data['tasks'] = Tasks::all();
44
45			return view("tasks.request_task", $data);
46			}
47
48			/**
49			* Store a newly created resource in storage.
50			*
51			* @param Requests\taskRequestValidator $request
52			* @return \Illuminate\Http\Response
53			*/
54			public function store(Requests\taskRequestValidator $request)
			0 ignored issues – show Unused Code introduced 2016-03-25 18:14 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
55			{
56			//
57			}
58
59			/**
60			* Display the specified resource.
61			*
62			* @param int $id, The id off the task in the database.
			0 ignored issues – show Bug introduced 2016-05-06 10:25 UTC by Report Bug Copy Issue Report There is no parameter named `$id,`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
63			* @return \Illuminate\Http\Response
64			*/
65			public function show($id)
			0 ignored issues – show Unused Code introduced 2016-03-25 18:14 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
66			{
67			//
68			}
69
70			/**
71			* Show the form for editing the specified resource.
72			*
73			* @param int $id The id off the task in the database.
74			* @return \Illuminate\Http\Response
75			*/
76			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-03-25 18:14 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
77			{
78			//
79			}
80
81			/**
82			* Update the specified resource in storage.
83			*
84			* @param Requests\taskValidator $request
85			* @param int $id, the task request id.
			0 ignored issues – show Bug introduced 2016-05-06 10:25 UTC by Report Bug Copy Issue Report There is no parameter named `$id,`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
86			* @return \Illuminate\Http\Response
87			*/
88			public function update(Requests\taskValidator $request, $id)
			0 ignored issues – show Unused Code introduced 2016-03-25 18:14 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-25 18:14 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
89			{
90			//
91			}
92
93			/**
94			* Remove the specified resource from storage.
95			*
96			* @param Request $request
97			* @return \Illuminate\Http\Response
98			*/
99			public function destroy(Request $request)
100			{
101			TasksRequest::destroy($request->get('integer'));
102			session()->flash('message', trans('FlashSession.tasksDestroy'));
103
104			return redirect()->back();
105			}
106			}
107

idevelopment / timecontrol

Pull Request — master (#107)

TaskController::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like