DepartmentOutput::includeManagers() - Code Metrics - Inspection of "Update master" - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#107)

by Glenn

created 2016-05-13 13:55 UTC

DepartmentOutput::includeManagers() A

↳ Parent: DepartmentOutput

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace App\Http\TransformersApi;

use App\Departments;
use App\Http\TransformersApi\Relations\DepartmentManager;
use League\Fractal;

/**
 * Class DepartmentTransformer
 */
class DepartmentOutput extends Fractal\TransformerAbstract
{
    /**
     * List of resources to automatically include
     *
     * @var array
     */
    protected $defaultIncludes = ['managers'];
    
    /**
     * Generic array
     *
     * @param  Departments $department
     * @return array
     */
    public function transform(Departments $department)
    {
        return [
            'id'           => (int)    $department->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'name'         => (string) $department->department_name,
            'managers'     => (string) $department->department_manager,
            'description'  => (string) $department->department_description
        ];
    }

    /**
     * Include Managers
     *
     * @param  Departments $department
     * @return Fractal\Resource\Item
     */
    public function includeManagers(Departments $department)
    {
        $data = $department->managers;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return $this->collection($data, new DepartmentManager);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}

1			<?php
2
3			namespace App\Http\TransformersApi;
4
5			use App\Departments;
6			use App\Http\TransformersApi\Relations\DepartmentManager;
7			use League\Fractal;
8
9			/**
10			* Class DepartmentTransformer
11			*/
12			class DepartmentOutput extends Fractal\TransformerAbstract
13			{
14			/**
15			* List of resources to automatically include
16			*
17			* @var array
18			*/
19			protected $defaultIncludes = ['managers'];
20
21			/**
22			* Generic array
23			*
24			* @param Departments $department
25			* @return array
26			*/
27			public function transform(Departments $department)
28			{
29			return [
30			'id' => (int) $department->id,
			0 ignored issues – show Documentation introduced 2016-05-09 20:59 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Departments>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31			'name' => (string) $department->department_name,
32			'managers' => (string) $department->department_manager,
33			'description' => (string) $department->department_description
34			];
35			}
36
37			/**
38			* Include Managers
39			*
40			* @param Departments $department
41			* @return Fractal\Resource\Item
42			*/
43			public function includeManagers(Departments $department)
44			{
45			$data = $department->managers;
			0 ignored issues – show Documentation introduced 2016-05-09 20:59 UTC by Report Bug Copy Issue Report The property `managers` does not exist on `object<App\Departments>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			return $this->collection($data, new DepartmentManager);
			0 ignored issues – show Documentation introduced 2016-05-09 20:59 UTC by Report Bug Copy Issue Report `new \App\Http\Transforme...ons\DepartmentManager()` is of type `object<App\Http\Transfor...ions\DepartmentManager>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			}
48			}

idevelopment / timecontrol

Pull Request — master (#107)

DepartmentOutput::includeManagers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like