HolidaysController::index() - Code Metrics - Inspection of "Merge pull request #238 from idevelopment/patch-23..." - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 76b4cb...55251d )

by Glenn

created 2016-05-14 20:53 UTC

HolidaysController::index() A

↳ Parent: HolidaysController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	2

Metric	Value
dl	0
loc	5
c	2
b	1
f	2
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace App\Http\Controllers;

use App\Holidays;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;

class HolidaysController extends Controller
{
    /**
     * HolidaysController constructor.
     */
    public function __construct()
    {
        $this->middleware('lang');
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data['query'] = Holidays::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('holidays/list', $data);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('holidays/request');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Requests\HolidayValidator $input
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\HolidayValidator $input)

    {
        $holiday              = new Holidays();
        $holiday->user_id     = auth()->user()->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $holiday->type        = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $holiday->from        = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $holiday->until       = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $holiday->description = '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $holiday->save();

        session()->flash('message', '');
        return redirect()->back();
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $data['query'] = Holidays::with('users')->where('id', $id)->get();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('', $data);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int | $id | The database id.
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $data['query'] = Holidays::find($id);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('', $data);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Requests\HolidayValidator $input
     * @param  int | $id | The database id.
     * @return \Illuminate\Http\Response
     */
    public function update(Requests\HolidayValidator $input, $id)

    {
        Holidays::find($id)->update([
            'user_id' => auth()->user()->id
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        ]);

        session()->flash('message', '');
        return redirect()->back(302);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int | $id | The database id.
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Holidays::destroy($id);
        session()->flash('message', 'Vacation request deleted.');
        return redirect()->back(302);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Holidays;
6			use Illuminate\Http\Request;
7
8			use App\Http\Requests;
9			use App\Http\Controllers\Controller;
10
11			class HolidaysController extends Controller
12			{
13			/**
14			* HolidaysController constructor.
15			*/
16			public function __construct()
17			{
18			$this->middleware('lang');
19			$this->middleware('auth');
20			}
21
22			/**
23			* Display a listing of the resource.
24			*
25			* @return \Illuminate\Http\Response
26			*/
27			public function index()
28			{
29			$data['query'] = Holidays::all();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
30			return view('holidays/list', $data);
31			}
32
33			/**
34			* Show the form for creating a new resource.
35			*
36			* @return \Illuminate\Http\Response
37			*/
38			public function create()
39			{
40			return view('holidays/request');
41			}
42
43			/**
44			* Store a newly created resource in storage.
45			*
46			* @param Requests\HolidayValidator $input
47			* @return \Illuminate\Http\Response
48			*/
49			public function store(Requests\HolidayValidator $input)
			0 ignored issues – show Unused Code introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The parameter `$input` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
50			{
51			$holiday = new Holidays();
52			$holiday->user_id = auth()->user()->id;
			0 ignored issues – show Documentation introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<App\Holidays>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
53			$holiday->type = '';
			0 ignored issues – show Documentation introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<App\Holidays>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54			$holiday->from = '';
			0 ignored issues – show Documentation introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The property `from` does not exist on `object<App\Holidays>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55			$holiday->until = '';
			0 ignored issues – show Documentation introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The property `until` does not exist on `object<App\Holidays>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			$holiday->description = '';
			0 ignored issues – show Documentation introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The property `description` does not exist on `object<App\Holidays>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57			$holiday->save();
58
59			session()->flash('message', '');
60			return redirect()->back();
61			}
62
63			/**
64			* Display the specified resource.
65			*
66			* @param int $id
67			* @return \Illuminate\Http\Response
68			*/
69			public function show($id)
70			{
71			$data['query'] = Holidays::with('users')->where('id', $id)->get();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
72			return view('', $data);
73			}
74
75			/**
76			* Show the form for editing the specified resource.
77			*
78			* @param int \| $id \| The database id.
79			* @return \Illuminate\Http\Response
80			*/
81			public function edit($id)
82			{
83			$data['query'] = Holidays::find($id);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
84			return view('', $data);
85			}
86
87			/**
88			* Update the specified resource in storage.
89			*
90			* @param Requests\HolidayValidator $input
91			* @param int \| $id \| The database id.
92			* @return \Illuminate\Http\Response
93			*/
94			public function update(Requests\HolidayValidator $input, $id)
			0 ignored issues – show Unused Code introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report The parameter `$input` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
95			{
96			Holidays::find($id)->update([
97			'user_id' => auth()->user()->id
			0 ignored issues – show Bug introduced 2016-05-14 15:28 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
98			]);
99
100			session()->flash('message', '');
101			return redirect()->back(302);
102			}
103
104			/**
105			* Remove the specified resource from storage.
106			*
107			* @param int \| $id \| The database id.
108			* @return \Illuminate\Http\Response
109			*/
110			public function destroy($id)
111			{
112			Holidays::destroy($id);
113			session()->flash('message', 'Vacation request deleted.');
114			return redirect()->back(302);
115			}
116			}
117

idevelopment / timecontrol

Push — development ( 76b4cb...55251d )

HolidaysController::index() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like