App\Http\Controllers\StaffController

Complexity

Total Complexity

24

Size/Duplication

Total Lines	281
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	10

Importance

Changes	10
Bugs	3	Features	2

20 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	5	1
A	store()	0	23	1
A	updateUser()	0	18	1
A	policies()	0	5	1
A	addpolicies()	0	5	1
A	addRole()	0	13	3
A	editpolicies()	0	7	1
A	destroyRole()	0	7	1
A	permissions()	0	5	1
A	create_permission()	0	4	1
A	save_permission()	0	7	1
A	destroy_permission()	0	8	1
A	show()	0	4	1
A	profile()	0	5	1
A	chPass()	0	4	1
A	update()	0	22	2
A	destroy()	0	10	2
A	create()	0	5	1
A	edit()	0	8	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\User;
use App\Countries;
use App\Teams;
use App\Role;
use Illuminate\Support\Facades\Input;
use Illuminate\Support\Facades\Mail;
use Intervention\Image\Facades\Image;
use App\Permission;
use Bouncer;

class StaffController extends Controller
{

    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display all users.
     *
     * @return mixed
     */
    public function index()
    {
        $data['users'] = User::orderBy('fname', 'asc')->paginate(10);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/users', $data);
    }

    /**
     * Show the form for creating a new employee.
     *
     * @return mixed
     */
    public function create()
    {
        $data['countries'] = Countries::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/create_user', $data);
    }

    /**
     * Store a newly created employee in storage.
     *
     * @param Requests\StaffValidator|Request $request
     * @return mixed
     */
    public function store(Requests\StaffValidator $request)
    {
        $user = new User;
        $user->fname = $request->get('fname');

The property fname does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->name = $request->get('name');

The property name does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->address = $request->get('address');

The property address does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->postal_code = $request->get('postal_code');

The property postal_code does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->city = $request->get('city');

The property city does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->email = $request->get('email');

The property email does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->password = bcrypt($request->get('password'));

The property password does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->save();

        $mailbox = env('MAIL_USERNAME');
        $mail_password = $request->get('password');
        session()->flash('message', "New employee has been added to the application");

        Mail::send('emails.new_user', ['user' => $user, 'password' => $mail_password], function ($m) use ($user, $mailbox) {
            $m->from($mailbox);
            $m->to($user->email)->subject('Your user credentials!');

The property email does not exist on object<App\User>. Since you implemented __get, maybe consider adding a @property annotation.

        });

        return redirect('staff');
    }

    /**
     * Update a user.
     *
     * @param  Int, $id

The doc-type Int, could not be parsed: Expected "|" or "end of type", but got "," at position 3. (view supported doc-types)

     * @param  Request $request
     * @return mixed
     */
    public function updateUser($id, Request $request)
    {
        $user = User::find($id);
        $user->fname = $request->get('fname');
        $user->name = $request->get('name');
        $user->address = $request->get('address');
        $user->postal_code = $request->get('postal_code');
        $user->city = $request->get('city');
        $user->email = $request->get('email');
        $user->assignRole($request->get('user_type'));
        $user->update();

        $user = User::find($id);
        Bouncer::assign($request->get('user_typ'))->to($user);

        session()->flash('message', "User details have been updated");
        return \Redirect::back();
    }


    /**
     * @return mixed
     */
    public function policies()
    {
        $data['roles'] = Role::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/roles', $data);
    }

    /**
     * @return mixed
     */
    public function addpolicies()
    {
        $data['permissions'] = Permission::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/create_role', $data);
    }


    /**
     * @param Request $request
     * @return string
     */
    public function addRole(Request $request)
    {
        $role = Role::create(['name' => $request->get('role_name')]);
        foreach ($request->get('permissions') as $permission) {
            $role->givePermissionTo($permission);

The method givePermissionTo does not exist on object<App\Role>? Since you implemented __call, maybe consider adding a @method annotation.

        }
        if ($assign_role) {

The variable $assign_role does not exist. Did you forget to declare it?

            session()->flash('message', 'New user role has been created');
            return redirect('staff/policies');
        } else {
            return "Mislukt";
        }
    }

    /**
     * @param $id
     * @return mixed
     */
    public function editpolicies($id)
    {
        $role = Role::find($id);

$role is not used, you could remove the assignment.

        $data['permissions'] = Permission::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/edit_role', $data);
    }

    /**
     * Remove the user role.
     *
     * @param  int, $id

The doc-type int, could not be parsed: Expected "|" or "end of type", but got "," at position 3. (view supported doc-types)

     * @return redirect
     */
    public function destroyRole($id)
    {
        $role = Role::find($id);
        $role->delete();
        session()->flash('message', "User role has been removed from the database");
        return redirect('staff/policies');
    }


    /**
     * Show all permission.
     */
    public function permissions()
    {
        $data['permissions'] = Permission::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff/permissions', $data);
    }

    /**
     * Show the form to create a new permission.
     */
    public function create_permission()
    {
        return view('staff/create_permission');
    }

    /**
     *
     * Save the new permission.
     *
     * @param  Request $request
     * @return redirect
     */
    public function save_permission(Request $request)
    {
        // $permission_name = $request->get('permission_name');

59% of this comment could be valid code. Did you maybe forget this after debugging?

        $permission = Permission::create(['name' => $request->get('permission_name')]);

$permission is not used, you could remove the assignment.

        session()->flash('message', "The new permission has been added to the database");
        return redirect('staff/permissions');
    }

    public function destroy_permission($id)
    {
        $permission = Permission::find($id);
        $permission->delete();

        session()->flash('message', "Permission has been removed from the database");
        return redirect('staff/permissions');
    }

    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     * @param $id
     * @return
     */
    public function edit($id)
    {
        $data['user'] = User::findOrFail($id);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['teams'] = Teams::all();
        $data['countries'] = Countries::all();
        $data['roles'] = Role::all();
        return view("staff/edit_user", $data);
    }


    /**
     * @return mixed
     */
    public function profile()
    {
        $data['countries'] = Countries::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view("staff/profile", $data);
    }

    /**
     * change a password
     */
    public function chPass()
    {

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request)
    {
        $user = User::findOrFail(auth()->user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user->fname = $request->get('email');
        $user->name = $request->get('name');
        $user->email = $request->get('email');
        $user->address = $request->get('address');
        $user->email = 'john@foo.com';

        if (Input::file()) {
            $image = Input::file('avatar');
            $filename = time() . '.' . $image->getClientOriginalExtension();
            $path = public_path('profilepics/' . $filename);

            Image::make($image->getRealPath())->resize(200, 200)->save($path);
            $user->image = $filename;
        }

        $user->save();

        return redirect()->back();
    }

    /**
     * Remove the specified employee from the database.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if (! Auth::user()->is('Administrator')) {
            return Redirect::back();
        }

        User::Destroy($id);
        session()->flash('message', "User has been removed from the database");
        return redirect('staff');

The return type of return redirect('staff'); (Illuminate\Http\RedirectResponse) is incompatible with the return type documented by App\Http\Controllers\StaffController::destroy of type Illuminate\Http\Response.

    }
}