App\Http\Controllers\TaskController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	6
Bugs	1	Features	4

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	5	1
A	create()	0	7	1
A	store()	0	4	1
A	show()	0	4	1
A	edit()	0	4	1
A	update()	0	4	1
A	destroy()	0	7	1

<?php

namespace App\Http\Controllers;

use App\TasksRequest;
use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;

use App\User;
use App\Tasks;

class TaskController extends Controller
{
    /**
     * TaskController constructor.
     */ 
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data['tasks'] = TasksRequest::paginate(15);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view("tasks.manage_tasks", $data);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $data['users'] = User::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['tasks'] = Tasks::all();

        return view("tasks.request_task", $data);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  Requests\taskRequestValidator $request
     * @return \Illuminate\Http\Response
     */
    public function store(Requests\taskRequestValidator $request)

The parameter $request is not used and could be removed.

    {
       //
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id, The id off the task in the database.

There is no parameter named $id,. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        // 
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id The id off the task in the database.
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Requests\taskValidator $request
     * @param  int $id, the task request id.

There is no parameter named $id,. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Requests\taskValidator $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Request $request
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request)
    {
        TasksRequest::destroy($request->get('integer'));
        session()->flash('message', trans('FlashSession.tasksDestroy'));

        return redirect()->back();
    }
}